[GitHub] [iotdb] neuyilan commented on a change in pull request #1836: [IOTDB-948] Use binary search when checking the follower's match index when catchup
neuyilan commented on a change in pull request #1836:
URL: https://github.com/apache/iotdb/pull/1836#discussion_r510640073
##
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##
@@ -1691,7 +1693,7 @@ protected TSStatus executeNonQueryPlan(PhysicalPlan plan)
{
} catch (QueryProcessException e) {
logger.error("meet error while processing non-query. ", e);
Throwable cause = e;
- while (cause.getCause() != null){
+ while (cause.getCause() != null && cause.getCause().getCause() != null) {
Review comment:
have changed the code as normal
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1850: add plan index and flush/close listeners
sonarcloud[bot] commented on pull request #1850: URL: https://github.com/apache/iotdb/pull/1850#issuecomment-714920015 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1850=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1850=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1850) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1850=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1850=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] jt2594838 opened a new pull request #1850: add plan index and flush/close listeners
jt2594838 opened a new pull request #1850: URL: https://github.com/apache/iotdb/pull/1850 Add plan index and flush/close listeners to bridge cluster version log management. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] neuyilan commented on a change in pull request #1836: [IOTDB-948] Use binary search when checking the follower's match index when catchup
neuyilan commented on a change in pull request #1836:
URL: https://github.com/apache/iotdb/pull/1836#discussion_r510570408
##
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##
@@ -1691,7 +1693,7 @@ protected TSStatus executeNonQueryPlan(PhysicalPlan plan)
{
} catch (QueryProcessException e) {
logger.error("meet error while processing non-query. ", e);
Throwable cause = e;
- while (cause.getCause() != null){
+ while (cause.getCause() != null && cause.getCause().getCause() != null) {
Review comment:
this is used to fix the UT tests that the exception only shows the
message bug but lacks the exception type. I saw you have fixed in the
commit[1], but I think it's better to be consistent with the single server.
So if you agree with me, I would re-add the exception type you've deleted in
[1], otherwise, I'll change the code here as normal.
[1]
https://github.com/apache/iotdb/commit/83e916a9e7bc618f348b7078bd79e62db6d9d546
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] neuyilan commented on a change in pull request #1836: [IOTDB-948] Use binary search when checking the follower's match index when catchup
neuyilan commented on a change in pull request #1836:
URL: https://github.com/apache/iotdb/pull/1836#discussion_r510570408
##
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##
@@ -1691,7 +1693,7 @@ protected TSStatus executeNonQueryPlan(PhysicalPlan plan)
{
} catch (QueryProcessException e) {
logger.error("meet error while processing non-query. ", e);
Throwable cause = e;
- while (cause.getCause() != null){
+ while (cause.getCause() != null && cause.getCause().getCause() != null) {
Review comment:
this is used to fix the IT tests that the exception only shows the
message bug but lacks the exception type. I saw you have fixed in the
commit[1], but I think it's better to be consistent with the single server.
So if you agree with me, I would re-add the exception type you've deleted in
[1], otherwise, I'll change the code here as normal.
[1]
https://github.com/apache/iotdb/commit/83e916a9e7bc618f348b7078bd79e62db6d9d546
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] zhanglingzhe0820 opened a new pull request #1849: fix concurrent bug
zhanglingzhe0820 opened a new pull request #1849: URL: https://github.com/apache/iotdb/pull/1849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1848: Update comment of VersionController
sonarcloud[bot] commented on pull request #1848: URL: https://github.com/apache/iotdb/pull/1848#issuecomment-714867940 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1848=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1848=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1848) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1848=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1848=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
HTHou commented on a change in pull request #1524:
URL: https://github.com/apache/iotdb/pull/1524#discussion_r510556524
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/memtable/AbstractMemTable.java
##
@@ -100,15 +107,16 @@ private IWritableMemChunk createIfNotExistAndGet(String
deviceId, String measure
protected abstract IWritableMemChunk genMemSeries(MeasurementSchema schema);
@Override
- public void insert(InsertRowPlan insertRowPlan) {
+ public void insert(InsertRowPlan insertRowPlan) throws WriteProcessException
{
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
HTHou commented on a change in pull request #1524:
URL: https://github.com/apache/iotdb/pull/1524#discussion_r510556332
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/memtable/MemTableFlushTaskTest.java
##
@@ -62,7 +63,7 @@ public void tearDown() throws Exception {
}
@Test
- public void testFlushMemTable() throws ExecutionException,
InterruptedException, IOException {
+ public void testFlushMemTable() throws ExecutionException,
InterruptedException, IOException, WriteProcessException {
Review comment:
Fixed
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/memtable/MemTableTestUtils.java
##
@@ -40,7 +41,7 @@
}
public static void produceData(IMemTable iMemTable, long startTime, long
endTime, String deviceId,
- String measurementId, TSDataType dataType) {
+ String measurementId, TSDataType dataType) throws WriteProcessException {
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
HTHou commented on a change in pull request #1524: URL: https://github.com/apache/iotdb/pull/1524#discussion_r510555743 ## File path: server/src/main/java/org/apache/iotdb/db/engine/memtable/IMemTable.java ## @@ -43,9 +43,9 @@ Map> getMemTableMap(); void write(String deviceId, String measurement, MeasurementSchema schema, - long insertTime, Object objectValue); + long insertTime, Object objectValue) throws WriteProcessException; Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
HTHou commented on a change in pull request #1524:
URL: https://github.com/apache/iotdb/pull/1524#discussion_r510555473
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/memtable/PrimitiveMemTableTest.java
##
@@ -49,7 +51,7 @@ public void setUp() {
}
@Test
- public void memSeriesSortIteratorTest() throws IOException {
+ public void memSeriesSortIteratorTest() throws IOException,
WriteProcessException {
Review comment:
Fixed~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
HTHou commented on a change in pull request #1524:
URL: https://github.com/apache/iotdb/pull/1524#discussion_r510555368
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/memtable/AbstractMemTable.java
##
@@ -122,24 +130,24 @@ public void insertTablet(InsertTabletPlan
insertTabletPlan, int start, int end)
throws WriteProcessException {
try {
write(insertTabletPlan, start, end);
- memSize += MemUtils.getRecordSize(insertTabletPlan, start, end);
+ memSize += MemUtils.getRecordSize(insertTabletPlan, start, end,
!enableMemControl);
totalPointsNum += (insertTabletPlan.getMeasurements().length -
insertTabletPlan.getFailedMeasurementNumber())
* (end - start);
} catch (RuntimeException e) {
- throw new WriteProcessException(e.getMessage());
+ throw new WriteProcessException(e);
}
}
@Override
public void write(String deviceId, String measurement, MeasurementSchema
schema, long insertTime,
- Object objectValue) {
+ Object objectValue) throws WriteProcessException {
Review comment:
Fixed~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] jt2594838 commented on a change in pull request #1836: [IOTDB-948] Use binary search when checking the follower's match index when catchup
jt2594838 commented on a change in pull request #1836:
URL: https://github.com/apache/iotdb/pull/1836#discussion_r510555104
##
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##
@@ -1691,7 +1693,7 @@ protected TSStatus executeNonQueryPlan(PhysicalPlan plan)
{
} catch (QueryProcessException e) {
logger.error("meet error while processing non-query. ", e);
Throwable cause = e;
- while (cause.getCause() != null){
+ while (cause.getCause() != null && cause.getCause().getCause() != null) {
Review comment:
Could you please explain this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1716: Restful API v2 (using netty)
sonarcloud[bot] commented on pull request #1716: URL: https://github.com/apache/iotdb/pull/1716#issuecomment-714861181 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) [1.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1716: Restful API v2 (using netty)
sonarcloud[bot] removed a comment on pull request #1716: URL: https://github.com/apache/iotdb/pull/1716#issuecomment-714320619 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) [1.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] samperson1997 commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
samperson1997 commented on a change in pull request #1524:
URL: https://github.com/apache/iotdb/pull/1524#discussion_r510550973
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/memtable/MemTableFlushTaskTest.java
##
@@ -62,7 +63,7 @@ public void tearDown() throws Exception {
}
@Test
- public void testFlushMemTable() throws ExecutionException,
InterruptedException, IOException {
+ public void testFlushMemTable() throws ExecutionException,
InterruptedException, IOException, WriteProcessException {
Review comment:
Remove `WriteProcessException `
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/memtable/MemTableTestUtils.java
##
@@ -40,7 +41,7 @@
}
public static void produceData(IMemTable iMemTable, long startTime, long
endTime, String deviceId,
- String measurementId, TSDataType dataType) {
+ String measurementId, TSDataType dataType) throws WriteProcessException {
Review comment:
Remove `WriteProcessException `
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] samperson1997 commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
samperson1997 commented on a change in pull request #1524:
URL: https://github.com/apache/iotdb/pull/1524#discussion_r510550263
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/memtable/AbstractMemTable.java
##
@@ -122,24 +130,24 @@ public void insertTablet(InsertTabletPlan
insertTabletPlan, int start, int end)
throws WriteProcessException {
try {
write(insertTabletPlan, start, end);
- memSize += MemUtils.getRecordSize(insertTabletPlan, start, end);
+ memSize += MemUtils.getRecordSize(insertTabletPlan, start, end,
!enableMemControl);
totalPointsNum += (insertTabletPlan.getMeasurements().length -
insertTabletPlan.getFailedMeasurementNumber())
* (end - start);
} catch (RuntimeException e) {
- throw new WriteProcessException(e.getMessage());
+ throw new WriteProcessException(e);
}
}
@Override
public void write(String deviceId, String measurement, MeasurementSchema
schema, long insertTime,
- Object objectValue) {
+ Object objectValue) throws WriteProcessException {
Review comment:
`WriteProcessException` could be removed in this class...
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/memtable/IMemTable.java
##
@@ -43,9 +43,9 @@
Map> getMemTableMap();
void write(String deviceId, String measurement, MeasurementSchema schema,
- long insertTime, Object objectValue);
+ long insertTime, Object objectValue) throws WriteProcessException;
Review comment:
remove 3 `WriteProcessException` (one is in line 81)
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/memtable/AbstractMemTable.java
##
@@ -100,15 +107,16 @@ private IWritableMemChunk createIfNotExistAndGet(String
deviceId, String measure
protected abstract IWritableMemChunk genMemSeries(MeasurementSchema schema);
@Override
- public void insert(InsertRowPlan insertRowPlan) {
+ public void insert(InsertRowPlan insertRowPlan) throws WriteProcessException
{
Review comment:
Remove `WriteProcessException`
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/memtable/PrimitiveMemTableTest.java
##
@@ -49,7 +51,7 @@ public void setUp() {
}
@Test
- public void memSeriesSortIteratorTest() throws IOException {
+ public void memSeriesSortIteratorTest() throws IOException,
WriteProcessException {
Review comment:
... so that all `WriteProcessException` in this test could be removed too
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/memtable/MemTableTestUtils.java
##
@@ -40,7 +41,7 @@
}
public static void produceData(IMemTable iMemTable, long startTime, long
endTime, String deviceId,
- String measurementId, TSDataType dataType) {
+ String measurementId, TSDataType dataType) throws WriteProcessException {
Review comment:
Remove `MemTableTestUtils`
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/memtable/MemTableFlushTaskTest.java
##
@@ -62,7 +63,7 @@ public void tearDown() throws Exception {
}
@Test
- public void testFlushMemTable() throws ExecutionException,
InterruptedException, IOException {
+ public void testFlushMemTable() throws ExecutionException,
InterruptedException, IOException, WriteProcessException {
Review comment:
Remove `MemTableFlushTaskTest.java`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] jt2594838 opened a new pull request #1848: Update comment of VersionController
jt2594838 opened a new pull request #1848: URL: https://github.com/apache/iotdb/pull/1848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
HTHou commented on a change in pull request #1524:
URL: https://github.com/apache/iotdb/pull/1524#discussion_r510549586
##
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##
@@ -232,14 +232,16 @@ write_read_free_memory_proportion=4:3:1:2
primitive_array_size=32
# Ratio of memory allocated for buffered arrays, 0.6 by default
-buffered_arrays_memory_proportion=0.4
+buffered_arrays_memory_proportion=0.6
# Flush proportion for system, 0.5 by default
flush_proportion=0.5
# Reject proportion for system, 0.8 by default
reject_proportion=0.8
+# If storage group increased more than this threshold, report to system. The
default value is 16777216
Review comment:
Fixed~
##
File path:
server/src/test/java/org/apache/iotdb/db/utils/datastructure/LongTVListTest.java
##
@@ -30,7 +32,7 @@
@Test
- public void testLongTVList1() {
+ public void testLongTVList1() throws WriteProcessException {
Review comment:
Fixed~
##
File path:
server/src/test/java/org/apache/iotdb/db/utils/datastructure/LongTVListTest.java
##
@@ -21,6 +21,8 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Random;
+
+import org.apache.iotdb.db.exception.WriteProcessException;
Review comment:
Fix~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] samperson1997 commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
samperson1997 commented on a change in pull request #1524:
URL: https://github.com/apache/iotdb/pull/1524#discussion_r509959632
##
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##
@@ -232,14 +232,16 @@ write_read_free_memory_proportion=4:3:1:2
primitive_array_size=32
# Ratio of memory allocated for buffered arrays, 0.6 by default
-buffered_arrays_memory_proportion=0.4
+buffered_arrays_memory_proportion=0.6
# Flush proportion for system, 0.5 by default
flush_proportion=0.5
# Reject proportion for system, 0.8 by default
reject_proportion=0.8
+# If storage group increased more than this threshold, report to system. The
default value is 16777216
Review comment:
```suggestion
# If storage group increased more than this threshold (in byte), report to
system. The default value is 16MB
```
##
File path:
server/src/test/java/org/apache/iotdb/db/utils/datastructure/LongTVListTest.java
##
@@ -30,7 +32,7 @@
@Test
- public void testLongTVList1() {
+ public void testLongTVList1() throws WriteProcessException {
Review comment:
no need to throw `WriteProcessException` in this test : )
##
File path:
server/src/test/java/org/apache/iotdb/db/utils/datastructure/LongTVListTest.java
##
@@ -21,6 +21,8 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Random;
+
+import org.apache.iotdb.db.exception.WriteProcessException;
Review comment:
remove unused import
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] CRZbulabula opened a new pull request #1847: [IOTDB-931] update start-cli bash
CRZbulabula opened a new pull request #1847: URL: https://github.com/apache/iotdb/pull/1847 Fix start-cli bash "-e" command bug This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] CRZbulabula closed pull request #1842: Fixed command line parameters
CRZbulabula closed pull request #1842: URL: https://github.com/apache/iotdb/pull/1842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Alima777 opened a new pull request #1846: [IOTDB-872] Use system timezone in CLI (Session)
Alima777 opened a new pull request #1846: URL: https://github.com/apache/iotdb/pull/1846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Alima777 opened a new pull request #1845: [IOTDB-955] Add more tracing log
Alima777 opened a new pull request #1845: URL: https://github.com/apache/iotdb/pull/1845 Add statistics(start time and end time) of each device in tsfile. Replace end time with total cost time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] wshao08 commented on a change in pull request #1657: Fix for Codesmell check step1
wshao08 commented on a change in pull request #1657:
URL: https://github.com/apache/iotdb/pull/1657#discussion_r509980310
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/merge/recover/MergeLogger.java
##
@@ -46,6 +46,10 @@
private BufferedWriter logStream;
+ public MergeLogger(MergeLogger another) {
Review comment:
Removed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] wshao08 commented on a change in pull request #1657: Fix for Codesmell check step1
wshao08 commented on a change in pull request #1657:
URL: https://github.com/apache/iotdb/pull/1657#discussion_r509979474
##
File path:
server/src/main/java/org/apache/iotdb/db/conf/directories/strategy/RandomOnDiskUsableSpaceStrategy.java
##
@@ -18,15 +18,17 @@
*/
package org.apache.iotdb.db.conf.directories.strategy;
+import com.google.common.primitives.Bytes;
+import com.google.common.primitives.Longs;
+import java.security.SecureRandom;
import java.util.ArrayList;
import java.util.List;
-import java.util.Random;
import org.apache.iotdb.db.exception.DiskSpaceInsufficientException;
import org.apache.iotdb.db.utils.CommonUtils;
public class RandomOnDiskUsableSpaceStrategy extends DirectoryStrategy {
- private Random random = new Random(System.currentTimeMillis());
+ private SecureRandom random = new
SecureRandom(Longs.toByteArray(System.currentTimeMillis()));
Review comment:
Use BytesUtils instead
##
File path:
server/src/test/java/org/apache/iotdb/db/conf/adapter/HyperLogLogTest.java
##
@@ -36,7 +37,7 @@
public void testStreamLibHll() {
final int seed = 12345;
// data on which to calculate distinct count
-Random random = new Random(seed);
+SecureRandom random = new SecureRandom(Ints.toByteArray(seed));
Review comment:
Fixed
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/merge/MergeLogTest.java
##
@@ -39,6 +39,8 @@
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
+import org.slf4j.Logger;
Review comment:
Removed
##
File path:
server/src/test/java/org/apache/iotdb/db/integration/IoTDBAutoCreateSchemaIT.java
##
@@ -35,6 +35,8 @@
import java.sql.ResultSet;
import java.sql.ResultSetMetaData;
import java.sql.Statement;
+import org.slf4j.Logger;
Review comment:
Removed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] wshao08 commented on a change in pull request #1657: Fix for Codesmell check step1
wshao08 commented on a change in pull request #1657:
URL: https://github.com/apache/iotdb/pull/1657#discussion_r509979080
##
File path:
server/src/test/java/org/apache/iotdb/db/sync/receiver/recover/SyncReceiverLogAnalyzerTest.java
##
@@ -22,14 +22,15 @@
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
+import com.google.common.primitives.Ints;
Review comment:
Fixed
##
File path:
server/src/test/java/org/apache/iotdb/db/sync/receiver/load/FileLoaderTest.java
##
@@ -22,15 +22,16 @@
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
+import com.google.common.primitives.Ints;
Review comment:
Fixed
##
File path:
server/src/test/java/org/apache/iotdb/db/integration/IoTDBFlushQueryMergeIT.java
##
@@ -93,11 +95,14 @@ public void selectAllSQLTest() throws
ClassNotFoundException {
boolean hasResultSet = statement.execute("SELECT * FROM root");
Assert.assertTrue(hasResultSet);
- try (ResultSet resultSet = statement.getResultSet()) {
+ ResultSet resultSet = statement.getResultSet();
Review comment:
Fixed
##
File path:
server/src/test/java/org/apache/iotdb/db/integration/IoTDBClearCacheIT.java
##
@@ -36,6 +36,8 @@
import org.junit.Assert;
import org.junit.BeforeClass;
import org.junit.Test;
+import org.slf4j.Logger;
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1716: Restful API v2 (using netty)
sonarcloud[bot] removed a comment on pull request #1716: URL: https://github.com/apache/iotdb/pull/1716#issuecomment-708110257 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) [1.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1716: Restful API v2 (using netty)
sonarcloud[bot] commented on pull request #1716: URL: https://github.com/apache/iotdb/pull/1716#issuecomment-714320619 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) [1.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/iotdb/pull/1524#issuecomment-712791507 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/iotdb/pull/1524#issuecomment-714298475 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1524=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) [2.9% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1524=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] QiAnXinCodeSafe opened a new issue #1844: There is a vulnerability in Spring Boot 1.5.4.RELEASE ,upgrade recommended
QiAnXinCodeSafe opened a new issue #1844: URL: https://github.com/apache/iotdb/issues/1844 https://github.com/apache/iotdb/blob/64dc16bb7ef26b9acb021d0eca5e6c4ad246a437/grafana/pom.xml#L51-L58 CVE-2017-8046 CVE-2018-1196 CVE-2020-5421 Recommended upgrade version：1.5.15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/iotdb/pull/460#issuecomment-714230624 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/iotdb/pull/460#issuecomment-714269456 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
