[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8835: [IOTDB-5401] Reduce the estimated size of memory retained after calling next in SeriesAggregationScanOperator

2023-01-11 Thread GitBox
sonarcloud[bot] commented on PR #8835: URL: https://github.com/apache/iotdb/pull/8835#issuecomment-1378507192 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] liuminghui233 opened a new pull request, #8835: [IOTDB-5401] Reduce the estimated size of memory retained after calling next

2023-01-11 Thread GitBox
liuminghui233 opened a new pull request, #8835: URL: https://github.com/apache/iotdb/pull/8835 Reduce the estimated size of memory retained after calling next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [iotdb] wanghui42 opened a new pull request, #8834: [doc] Fix MQTT file name

2023-01-11 Thread GitBox
wanghui42 opened a new pull request, #8834: URL: https://github.com/apache/iotdb/pull/8834 Fixing MQTT file name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [iotdb] RYH61 opened a new pull request, #8833: [IOTDB-5091] add space quota

2023-01-11 Thread GitBox
RYH61 opened a new pull request, #8833: URL: https://github.com/apache/iotdb/pull/8833 see [https://apache-iotdb.feishu.cn/docx/doxcnFGEYjz13CayP87oOIRrcqd](https://apache-iotdb.feishu.cn/docx/doxcnFGEYjz13CayP87oOIRrcqd) -- This is an automated message from the Apache Git Service. To res

[GitHub] [iotdb] RYH61 closed pull request #8265: [To multi_tenancy][IOTDB-5091] add space quota: device and timeseries num limit

2023-01-11 Thread GitBox
RYH61 closed pull request #8265: [To multi_tenancy][IOTDB-5091] add space quota: device and timeseries num limit URL: https://github.com/apache/iotdb/pull/8265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [iotdb] HeimingZ opened a new pull request, #8832: [IOTDB-5338] WAL buffer flush threshold optimaztion

2023-01-11 Thread GitBox
HeimingZ opened a new pull request, #8832: URL: https://github.com/apache/iotdb/pull/8832 1. use serialized size to control fsync. 2. use timeout poll method to increase batch size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8807: [IOTDB-5345] Use the logical clock to identify the snapshot version of IoTConsensus

2023-01-11 Thread GitBox
OneSizeFitsQuorum commented on code in PR #8807: URL: https://github.com/apache/iotdb/pull/8807#discussion_r1066691384 ## consensus/src/test/java/org/apache/iotdb/consensus/iot/StabilityTest.java: ## @@ -96,9 +103,10 @@ public void snapshotTest() throws Exception {

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8830: [IOTDB-5398] Handle failure in schema query if there is exception occurs during the iteration

2023-01-11 Thread GitBox
MarcosZyk commented on code in PR #8830: URL: https://github.com/apache/iotdb/pull/8830#discussion_r1066690759 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/schema/source/PathsUsingTemplateSource.java: ## @@ -114,5 +114,15 @@ public boolean hasNext() {

[GitHub] [iotdb] DanielWang2035 opened a new pull request, #8831: [mqtt][IOTDB-5390] Could not connect with mqtt, when mqtt_host is not set

2023-01-11 Thread GitBox
DanielWang2035 opened a new pull request, #8831: URL: https://github.com/apache/iotdb/pull/8831 see https://issues.apache.org/jira/browse/IOTDB-5390 Set the default mqtt host to be the same as dn_rpc_address, so the mqtt client on other devices can connect to iotdb without setting the

[GitHub] [iotdb] JackieTien97 merged pull request #8818: modify doc of KillQuery & ShowQueries as not supported

2023-01-11 Thread GitBox
JackieTien97 merged PR #8818: URL: https://github.com/apache/iotdb/pull/8818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8830: [IOTDB-5398] Handle failure in schema query if there is exception occurs during the iteration

2023-01-10 Thread GitBox
Cpaulyz opened a new pull request, #8830: URL: https://github.com/apache/iotdb/pull/8830 ## Description * Handle failure in schema query if there is exception occurs during the iteration. * Add UT to mock exception and check whether Operator throws runtime exception correctlly.

[GitHub] [iotdb] BUAAserein opened a new pull request, #8829: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-10 Thread GitBox
BUAAserein opened a new pull request, #8829: URL: https://github.com/apache/iotdb/pull/8829 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] BUAAserein opened a new pull request, #8828: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-10 Thread GitBox
BUAAserein opened a new pull request, #8828: URL: https://github.com/apache/iotdb/pull/8828 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] neuyilan closed pull request #8632: [IOTDB-5299][To rel/1.0] The metrics of the size of files is incorrect when the datanode restart

2023-01-10 Thread GitBox
neuyilan closed pull request #8632: [IOTDB-5299][To rel/1.0] The metrics of the size of files is incorrect when the datanode restart URL: https://github.com/apache/iotdb/pull/8632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [iotdb] BUAAserein opened a new pull request, #8827: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-10 Thread GitBox
BUAAserein opened a new pull request, #8827: URL: https://github.com/apache/iotdb/pull/8827 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] MarcosZyk opened a new pull request, #8826: [IOTDB-5399] Implement concurrent auto create schema of multi devices

2023-01-10 Thread GitBox
MarcosZyk opened a new pull request, #8826: URL: https://github.com/apache/iotdb/pull/8826 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concu

[GitHub] [iotdb] BUAAserein opened a new pull request, #8825: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-10 Thread GitBox
BUAAserein opened a new pull request, #8825: URL: https://github.com/apache/iotdb/pull/8825 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] BUAAserein opened a new pull request, #8824: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-10 Thread GitBox
BUAAserein opened a new pull request, #8824: URL: https://github.com/apache/iotdb/pull/8824 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] Beyyes opened a new pull request, #8823: Cherry-pick commit `78a8528` and `c06147e` from rel/1.0 to rc/1.0.1

2023-01-10 Thread GitBox
Beyyes opened a new pull request, #8823: URL: https://github.com/apache/iotdb/pull/8823 Cherry-pick commit `78a8528` and `c06147e`. https://user-images.githubusercontent.com/6756545/211738615-ad47b2bc-aa2c-4ccd-a0e8-da4721c5d674.png";> -- This is an automated message from the Ap

[GitHub] [iotdb] BUAAserein opened a new pull request, #8822: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-10 Thread GitBox
BUAAserein opened a new pull request, #8822: URL: https://github.com/apache/iotdb/pull/8822 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] jun0315 closed pull request #7858: [IOTDB-4686] SchemaReader for schema query operator-refactor traverser

2023-01-10 Thread GitBox
jun0315 closed pull request #7858: [IOTDB-4686] SchemaReader for schema query operator-refactor traverser URL: https://github.com/apache/iotdb/pull/7858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [iotdb] BUAAserein commented on a diff in pull request #8807: [IOTDB-5345] Use the logical clock to identify the snapshot version of IoTConsensus

2023-01-10 Thread GitBox
BUAAserein commented on code in PR #8807: URL: https://github.com/apache/iotdb/pull/8807#discussion_r1066561608 ## consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java: ## @@ -370,6 +365,21 @@ private String calculateSnapshotPath(String snapshotId,

[GitHub] [iotdb] BUAAserein commented on a diff in pull request #8807: [IOTDB-5345] Use the logical clock to identify the snapshot version of IoTConsensus

2023-01-10 Thread GitBox
BUAAserein commented on code in PR #8807: URL: https://github.com/apache/iotdb/pull/8807#discussion_r1066561485 ## consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java: ## @@ -287,13 +285,10 @@ public DataSet read(IConsensusRequest request) { p

[GitHub] [iotdb] HTHou merged pull request #8819: Fix testGetSlots bug

2023-01-10 Thread GitBox
HTHou merged PR #8819: URL: https://github.com/apache/iotdb/pull/8819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #8797: [IOTDB-5310] Added removing status to region migration

2023-01-10 Thread GitBox
CRZbulabula commented on code in PR #8797: URL: https://github.com/apache/iotdb/pull/8797#discussion_r1066537694 ## confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/statemachine/RegionMigrateProcedure.java: ## @@ -87,6 +87,7 @@ protected Flow executeFromState(

[GitHub] [iotdb] Beyyes commented on a diff in pull request #8797: [IOTDB-5310] Added removing status to region migration

2023-01-10 Thread GitBox
Beyyes commented on code in PR #8797: URL: https://github.com/apache/iotdb/pull/8797#discussion_r1066536575 ## confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/DataNodeRemoveHandler.java: ## @@ -75,6 +75,16 @@ public static String getIdWithRpcEndpoint(TDataNode

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8821: [IOTDB-5381] Formatting variables output

2023-01-10 Thread GitBox
sonarcloud[bot] commented on PR #8821: URL: https://github.com/apache/iotdb/pull/8821#issuecomment-1378184791 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] CRZbulabula opened a new pull request, #8821: [IOTDB-5381] Formatting variables output

2023-01-10 Thread GitBox
CRZbulabula opened a new pull request, #8821: URL: https://github.com/apache/iotdb/pull/8821 **Updates:** 1. ConfigNode and DataNode now will log their environment variables at the begining of startup like below: ``` ## ConfigNode 2023-01-11 10:55:42,558 [main] INFO o.a.i.c.

[GitHub] [iotdb] choubenson opened a new pull request, #8820: [IOTDB-4684]Devices with the same name but different alignment properties are compacted into the wrong alignment property

2023-01-10 Thread GitBox
choubenson opened a new pull request, #8820: URL: https://github.com/apache/iotdb/pull/8820 **Description** After the nonAligned device is deleted, an aligned device with the same name is created, and it will be compacted into the nonAligned device after compaction. Similarly, after t

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8819: Fix testGetSlots bug

2023-01-10 Thread GitBox
sonarcloud[bot] commented on PR #8819: URL: https://github.com/apache/iotdb/pull/8819#issuecomment-1378160389 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] CRZbulabula opened a new pull request, #8819: Fix testGetSlots bug

2023-01-10 Thread GitBox
CRZbulabula opened a new pull request, #8819: URL: https://github.com/apache/iotdb/pull/8819 A case in current testGetSlots test is often failed due to the different number of CPU cores on the test machine. Therefore this is a small commit to fix this bug. -- This is an automated message

[GitHub] [iotdb] MarcosZyk merged pull request #8816: [IOTDB-5391] Implement SchemaReader using iterative Traverser

2023-01-10 Thread GitBox
MarcosZyk merged PR #8816: URL: https://github.com/apache/iotdb/pull/8816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] Wei-hao-Li opened a new pull request, #8818: mark KillQuery are not supported

2023-01-10 Thread GitBox
Wei-hao-Li opened a new pull request, #8818: URL: https://github.com/apache/iotdb/pull/8818 KillQuery and Show Queries are not supported in rel/1.0, but has implemented in master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [iotdb] Beyyes merged pull request #8798: [IOTDB-5389] Cause DataNode startup to fail when wal_mode is disabled in IoTConsensus

2023-01-10 Thread GitBox
Beyyes merged PR #8798: URL: https://github.com/apache/iotdb/pull/8798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] Beyyes merged pull request #8817: [To rel/1.0][IOTDB-5389] Cause DataNode startup to fail when wal_mode is disabled in IoTConsensus

2023-01-10 Thread GitBox
Beyyes merged PR #8817: URL: https://github.com/apache/iotdb/pull/8817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] panagiotisl commented on pull request #8766: Chimp compression

2023-01-10 Thread GitBox
panagiotisl commented on PR #8766: URL: https://github.com/apache/iotdb/pull/8766#issuecomment-1377136003 Also some timing comparisons/experiments with three different datasets: # 5,000,000 values (Stocks-Germany) GORILLA Encoding time: 1163 GORILLA Decoding time: 158 CHIMP En

[GitHub] [iotdb] JackieTien97 merged pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-10 Thread GitBox
JackieTien97 merged PR #7693: URL: https://github.com/apache/iotdb/pull/7693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] THUMarkLau merged pull request #8812: [To Rel/1.0][Metrics][IOTDB-5288][IOTDB-5163] Fix the file metrics is wrong

2023-01-10 Thread GitBox
THUMarkLau merged PR #8812: URL: https://github.com/apache/iotdb/pull/8812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8817: [To rel/1.0][IOTDB-5389] Cause DataNode startup to fail when wal_mode is disabled in IoTConsensus

2023-01-10 Thread GitBox
sonarcloud[bot] commented on PR #8817: URL: https://github.com/apache/iotdb/pull/8817#issuecomment-1377085559 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8807: [IOTDB-5345] Use the logical clock to identify the snapshot version of IoTConsensus

2023-01-10 Thread GitBox
OneSizeFitsQuorum commented on code in PR #8807: URL: https://github.com/apache/iotdb/pull/8807#discussion_r1065633051 ## consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java: ## @@ -287,13 +285,10 @@ public DataSet read(IConsensusRequest request) {

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8798: [IOTDB-5389] Cause DataNode startup to fail when wal_mode is disabled in IoTConsensus

2023-01-10 Thread GitBox
sonarcloud[bot] commented on PR #8798: URL: https://github.com/apache/iotdb/pull/8798#issuecomment-1377079622 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] panagiotisl commented on pull request #8766: Chimp compression

2023-01-10 Thread GitBox
panagiotisl commented on PR #8766: URL: https://github.com/apache/iotdb/pull/8766#issuecomment-1377079167 > I have used the above example to make tests with 4 different configurations using the first 1,000 values of the basel-wind dataset (see Figure in the PR text). The results are

[GitHub] [iotdb] OneSizeFitsQuorum opened a new pull request, #8817: [To rel/1.0][IOTDB-5389] Cause DataNode startup to fail when wal_mode is disabled in IoTConsensus

2023-01-10 Thread GitBox
OneSizeFitsQuorum opened a new pull request, #8817: URL: https://github.com/apache/iotdb/pull/8817 cherry-pick [pull/8798](https://github.com/apache/iotdb/pull/8798) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] xingtanzjr merged pull request #8803: [To rel/1.0][IOTDB-5285] TimePartition may be error when restarting with different time partition configuration

2023-01-10 Thread GitBox
xingtanzjr merged PR #8803: URL: https://github.com/apache/iotdb/pull/8803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8816: [IOTDB-5391] Implement SchemaReader using iterative Traverser

2023-01-10 Thread GitBox
Cpaulyz opened a new pull request, #8816: URL: https://github.com/apache/iotdb/pull/8816 ## Description The current SchemaReader uses the result set returned from the original SchemaRegion to generate an iterator; however, the new Traverser supports the iterator pattern, allowing the

[GitHub] [iotdb] BUAAserein commented on a diff in pull request #8807: [IOTDB-5345] Use the logical clock to identify the snapshot version of IoTConsensus

2023-01-10 Thread GitBox
BUAAserein commented on code in PR #8807: URL: https://github.com/apache/iotdb/pull/8807#discussion_r1065554295 ## consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java: ## @@ -379,12 +389,13 @@ private void clearOldSnapshot() { thisNode.g

[GitHub] [iotdb] BUAAserein commented on a diff in pull request #8807: [IOTDB-5345] Use the logical clock to identify the snapshot version of IoTConsensus

2023-01-10 Thread GitBox
BUAAserein commented on code in PR #8807: URL: https://github.com/apache/iotdb/pull/8807#discussion_r1065565831 ## consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java: ## @@ -370,6 +365,21 @@ private String calculateSnapshotPath(String snapshotId,

[GitHub] [iotdb] DanielWang2035 opened a new pull request, #8815: [To rel/1.0][mqtt][IOTDB-5390] Could not connect with mqtt, when mqtt_host is not set

2023-01-10 Thread GitBox
DanielWang2035 opened a new pull request, #8815: URL: https://github.com/apache/iotdb/pull/8815 see https://issues.apache.org/jira/browse/IOTDB-5390 Set the default mqtt host to 0.0.0.0, so the mqtt client on other devices can connect to iotdb without setting the mqtt_host config. -

[GitHub] [iotdb] automatous opened a new issue, #8814: [Bug] can't connect to node TEndPoint

2023-01-10 Thread GitBox
automatous opened a new issue, #8814: URL: https://github.com/apache/iotdb/issues/8814 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar. ### Version IoTDB> show version; +---+--

[GitHub] [iotdb] ericpai commented on a diff in pull request #8786: [IOTDB-5370] Implement MultilevelPriorityQueue for query schedule

2023-01-10 Thread GitBox
ericpai commented on code in PR #8786: URL: https://github.com/apache/iotdb/pull/8786#discussion_r1065557168 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/DriverScheduler.java: ## @@ -82,8 +90,7 @@ public static DriverScheduler getInstance() { private D

[GitHub] [iotdb] BUAAserein commented on a diff in pull request #8807: [IOTDB-5345] Use the logical clock to identify the snapshot version of IoTConsensus

2023-01-10 Thread GitBox
BUAAserein commented on code in PR #8807: URL: https://github.com/apache/iotdb/pull/8807#discussion_r1065554295 ## consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java: ## @@ -379,12 +389,13 @@ private void clearOldSnapshot() { thisNode.g

[GitHub] [iotdb] lancelly commented on a diff in pull request #8786: [IOTDB-5370] Implement MultilevelPriorityQueue for query schedule

2023-01-10 Thread GitBox
lancelly commented on code in PR #8786: URL: https://github.com/apache/iotdb/pull/8786#discussion_r1065554162 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/DriverScheduler.java: ## @@ -82,8 +90,7 @@ public static DriverScheduler getInstance() { private

[GitHub] [iotdb] ericpai commented on a diff in pull request #8786: [IOTDB-5370] Implement MultilevelPriorityQueue for query schedule

2023-01-10 Thread GitBox
ericpai commented on code in PR #8786: URL: https://github.com/apache/iotdb/pull/8786#discussion_r1065552233 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/DriverScheduler.java: ## @@ -82,8 +90,7 @@ public static DriverScheduler getInstance() { private D

[GitHub] [iotdb] ericpai commented on a diff in pull request #8786: [IOTDB-5370] Implement MultilevelPriorityQueue for query schedule

2023-01-10 Thread GitBox
ericpai commented on code in PR #8786: URL: https://github.com/apache/iotdb/pull/8786#discussion_r1065549535 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/DriverTaskThread.java: ## @@ -44,17 +45,21 @@ public class DriverTaskThread extends AbstractDriverThrea

[GitHub] [iotdb] bigreybear opened a new pull request, #8813: [IOTDB-4960]SchemaFile implements separate FileChannel for read/write operation

2023-01-10 Thread GitBox
bigreybear opened a new pull request, #8813: URL: https://github.com/apache/iotdb/pull/8813 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] conc

[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8807: [IOTDB-5345] Use the logical clock to identify the snapshot version of IoTConsensus

2023-01-10 Thread GitBox
OneSizeFitsQuorum commented on code in PR #8807: URL: https://github.com/apache/iotdb/pull/8807#discussion_r1065522254 ## consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java: ## @@ -370,6 +365,21 @@ private String calculateSnapshotPath(String snaps

[GitHub] [iotdb] HTHou merged pull request #8808: Fix wal manager test

2023-01-10 Thread GitBox
HTHou merged PR #8808: URL: https://github.com/apache/iotdb/pull/8808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] JackieTien97 merged pull request #8806: Change config in SourceHandleTest according to IoTDBDescriptor

2023-01-10 Thread GitBox
JackieTien97 merged PR #8806: URL: https://github.com/apache/iotdb/pull/8806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8812: [To Rel/1.0][Metrics][IOTDB-5288][IOTDB-5163] Fix the file metrics is wrong

2023-01-10 Thread GitBox
sonarcloud[bot] commented on PR #8812: URL: https://github.com/apache/iotdb/pull/8812#issuecomment-1376907179 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] THUMarkLau opened a new pull request, #8812: [To Rel/1.0][Metrics][IOTDB-5288][IOTDB-5163] Fix the file metrics is wrong

2023-01-10 Thread GitBox
THUMarkLau opened a new pull request, #8812: URL: https://github.com/apache/iotdb/pull/8812 See [IOTDB-5288](https://issues.apache.org/jira/browse/IOTDB-5288), [IOTDB-5163](https://issues.apache.org/jira/browse/IOTDB-5163). This PR moves the edition of metrics to the end of compaction

[GitHub] [iotdb] choubenson opened a new pull request, #8811: [To rel/1.0][IOTDB-5392] accelerate pointPriorityReader in fast compaction

2023-01-09 Thread GitBox
choubenson opened a new pull request, #8811: URL: https://github.com/apache/iotdb/pull/8811 In the fast compaction, the overlapping pages will be put into the pointPriorityReader, and the points are spit out in order. Every time a point is spit out, an element must be popped out from the pr

[GitHub] [iotdb] THUMarkLau merged pull request #8805: [IOTDB-5288][IOTDB-5163] Fix the file metrics is wrong

2023-01-09 Thread GitBox
THUMarkLau merged PR #8805: URL: https://github.com/apache/iotdb/pull/8805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] choubenson opened a new pull request, #8810: [IOTDB-5392] accelerate pointPriorityReader in fast compaction

2023-01-09 Thread GitBox
choubenson opened a new pull request, #8810: URL: https://github.com/apache/iotdb/pull/8810 In the fast compaction, the overlapping pages will be put into the pointPriorityReader, and the points are spit out in order. Every time a point is spit out, an element must be popped out from the pr

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8809: [To rel/1.0] Separate SYNC_CONNECTION_ERROR and DISPATCH_ERROR

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8809: URL: https://github.com/apache/iotdb/pull/8809#issuecomment-1376838122 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] Beyyes commented on a diff in pull request #8797: [IOTDB-5310] Added removing status to region migration

2023-01-09 Thread GitBox
Beyyes commented on code in PR #8797: URL: https://github.com/apache/iotdb/pull/8797#discussion_r1065413475 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/heartbeat/RegionCache.java: ## @@ -31,6 +31,8 @@ public class RegionCache { private final Li

[GitHub] [iotdb] HTHou commented on a diff in pull request #8809: [To rel/1.0] Separate SYNC_CONNECTION_ERROR and DISPATCH_ERROR

2023-01-09 Thread GitBox
HTHou commented on code in PR #8809: URL: https://github.com/apache/iotdb/pull/8809#discussion_r1065406170 ## docs/UserGuide/Reference/Status-Codes.md: ## @@ -42,122 +42,124 @@ With Status Code, instead of writing codes like `if (e.getErrorMessage().contain Here is a list of

[GitHub] [iotdb] HTHou commented on a diff in pull request #8809: [To rel/1.0] Separate SYNC_CONNECTION_ERROR and DISPATCH_ERROR

2023-01-09 Thread GitBox
HTHou commented on code in PR #8809: URL: https://github.com/apache/iotdb/pull/8809#discussion_r1065405867 ## docs/zh/UserGuide/Reference/Status-Codes.md: ## @@ -43,122 +43,125 @@ try { 这里是状态码和相对应信息的列表: -|状态码|状态类型|状态信息| -|:--|:---|:---| -|200|SUCCESS_STATUS|成功状态| -|201|INCO

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8785: [To rel/1.0][IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager parame

2023-01-09 Thread GitBox
OneSizeFitsQuorum merged PR #8785: URL: https://github.com/apache/iotdb/pull/8785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] HTHou merged pull request #8726: Separate SYNC_CONNECTION_ERROR and DISPATCH_ERROR

2023-01-09 Thread GitBox
HTHou merged PR #8726: URL: https://github.com/apache/iotdb/pull/8726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] BUAAserein opened a new pull request, #8807: [IOTDB-5345] Use the logical clock to identify the snapshot version of IoTConsensus

2023-01-09 Thread GitBox
BUAAserein opened a new pull request, #8807: URL: https://github.com/apache/iotdb/pull/8807 ## Description ### Please see details in [IOTDB-5345](https://issues.apache.org/jira/browse/IOTDB-5345). -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [iotdb] lancelly opened a new pull request, #8806: Change config in SourceHandleTest according to IoTDBDescriptor

2023-01-09 Thread GitBox
lancelly opened a new pull request, #8806: URL: https://github.com/apache/iotdb/pull/8806 Before this pr, maxBytesCanReserve of SourceHandle is a constant in SourceHandleTest. When calling sourceHandle.setMaxBytesCanReserve(5 * mockTsBlockSize), if IoTDBDescriptor.getInstance().getConfig()

[GitHub] [iotdb] MarcosZyk merged pull request #8804: Eliminate LocalConfigNode and Fix NPE while forceMLog

2023-01-09 Thread GitBox
MarcosZyk merged PR #8804: URL: https://github.com/apache/iotdb/pull/8804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] xingtanzjr merged pull request #8769: [To rel/1.0][IOTDB-5207] Reconstruct compaction package

2023-01-09 Thread GitBox
xingtanzjr merged PR #8769: URL: https://github.com/apache/iotdb/pull/8769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8805: [IOTDB-5288][IOTDB-5163] Fix the file metrics is wrong

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8805: URL: https://github.com/apache/iotdb/pull/8805#issuecomment-1376727392 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] THUMarkLau opened a new pull request, #8805: [IOTDB-5288][IOTDB-5163] Fix the file metrics is wrong

2023-01-09 Thread GitBox
THUMarkLau opened a new pull request, #8805: URL: https://github.com/apache/iotdb/pull/8805 See [IOTDB-5288](https://issues.apache.org/jira/browse/IOTDB-5288), [IOTDB-5163](https://issues.apache.org/jira/browse/IOTDB-5163). This PR moves the edition of metrics to the end of compaction

[GitHub] [iotdb] MarcosZyk opened a new pull request, #8804: Eliminate LocalConfigNode and Fix NPE while forceMLog

2023-01-09 Thread GitBox
MarcosZyk opened a new pull request, #8804: URL: https://github.com/apache/iotdb/pull/8804 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concu

[GitHub] [iotdb] MarcosZyk merged pull request #8802: Eliminate LocalSchemaProcessor and stale code

2023-01-09 Thread GitBox
MarcosZyk merged PR #8802: URL: https://github.com/apache/iotdb/pull/8802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] Beyyes merged pull request #8790: [IOTDB-5328] Rename "REMOVE_DATANODE_PROCESS" in MIGRATE_REGION_PROCEDURE to "REGION_MIGRATE_PROCESS"

2023-01-09 Thread GitBox
Beyyes merged PR #8790: URL: https://github.com/apache/iotdb/pull/8790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] ericpai merged pull request #8795: [IOTDB-5387] Refine IT: Make JVM parameters mutable easily

2023-01-09 Thread GitBox
ericpai merged PR #8795: URL: https://github.com/apache/iotdb/pull/8795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

[GitHub] [iotdb] HeimingZ opened a new pull request, #8803: [IOTDB-5285] TimePartition may be error when restarting with different time partition configuration

2023-01-09 Thread GitBox
HeimingZ opened a new pull request, #8803: URL: https://github.com/apache/iotdb/pull/8803 cherry-pick from master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [iotdb] HTHou commented on pull request #8766: Chimp compression

2023-01-09 Thread GitBox
HTHou commented on PR #8766: URL: https://github.com/apache/iotdb/pull/8766#issuecomment-1376635141 I did a simple test. After executed the following sql. ![136561673316878_ pic](https://user-images.githubusercontent.com/25913899/211446856-f7787c4f-9ec3-42fb-9e84-4ccebfe88f9c.jpg)

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8800: [IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager parameters for con

2023-01-09 Thread GitBox
OneSizeFitsQuorum merged PR #8800: URL: https://github.com/apache/iotdb/pull/8800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] 0x55aa commented on issue #8801: python client error when disable wal(禁用wal之后,python客户端连接错误)

2023-01-09 Thread GitBox
0x55aa commented on issue #8801: URL: https://github.com/apache/iotdb/issues/8801#issuecomment-1376597745 i change to `data_region_consensus_protocol_class=org.apache.iotdb.consensus.simple.SimpleConsensus`, it works.thanks a lot -- This is an automated message from the Apache Git Servic

[GitHub] [iotdb] 0x55aa closed issue #8801: python client error when disable wal(禁用wal之后,python客户端连接错误)

2023-01-09 Thread GitBox
0x55aa closed issue #8801: python client error when disable wal(禁用wal之后,python客户端连接错误) URL: https://github.com/apache/iotdb/issues/8801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [iotdb] MarcosZyk opened a new pull request, #8802: Eliminate LocalSchemaProcessor and staled code

2023-01-09 Thread GitBox
MarcosZyk opened a new pull request, #8802: URL: https://github.com/apache/iotdb/pull/8802 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concu

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8726: Separate SYNC_CONNECTION_ERROR and DISPATCH_ERROR

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8726: URL: https://github.com/apache/iotdb/pull/8726#issuecomment-1376591995 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] HTHou commented on issue #8801: python client error when disable wal(禁用wal之后,python客户端连接错误)

2023-01-09 Thread GitBox
HTHou commented on issue #8801: URL: https://github.com/apache/iotdb/issues/8801#issuecomment-1376587523 IoTConsensus is using wal. If using IoTConsensus (default for DataRegion), wal can not be disabled. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [iotdb] github-actions[bot] commented on issue #8801: python client error when disable wal(禁用wal之后,python客户端连接错误)

2023-01-09 Thread GitBox
github-actions[bot] commented on issue #8801: URL: https://github.com/apache/iotdb/issues/8801#issuecomment-1376570080 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To resp

[GitHub] [iotdb] 0x55aa opened a new issue, #8801: python client error when disable wal(禁用wal之后,python客户端连接错误)

2023-01-09 Thread GitBox
0x55aa opened a new issue, #8801: URL: https://github.com/apache/iotdb/issues/8801 ### Discussed in https://github.com/apache/iotdb/discussions/8794 Originally posted by **0x55aa** January 9, 2023 version: 1.0.0 版本:1.0.0 in conf file iotdb-common.properties, set

[GitHub] [iotdb] JackieTien97 merged pull request #8432: [IOTDB-4005] Pipeline fragmentInstance to implement parallel execution

2023-01-09 Thread GitBox
JackieTien97 merged PR #8432: URL: https://github.com/apache/iotdb/pull/8432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8785: [To rel/1.0][IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager pa

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8785: URL: https://github.com/apache/iotdb/pull/8785#issuecomment-1375780290 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8800: [IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager parameters for

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8800: URL: https://github.com/apache/iotdb/pull/8800#issuecomment-1375771687 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] OneSizeFitsQuorum opened a new pull request, #8800: [IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager parameters

2023-01-09 Thread GitBox
OneSizeFitsQuorum opened a new pull request, #8800: URL: https://github.com/apache/iotdb/pull/8800 remove unused parameters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8432: [IOTDB-4005] Pipeline fragmentInstance to implement parallel execution

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8432: URL: https://github.com/apache/iotdb/pull/8432#issuecomment-1375743555 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] SpriCoder opened a new pull request, #8799: [IOTDB-5257] Optimize SyncLog Logic in IoT Consensus

2023-01-09 Thread GitBox
SpriCoder opened a new pull request, #8799: URL: https://github.com/apache/iotdb/pull/8799 Design Doc: https://apache-iotdb.feishu.cn/docx/MFuxdGITsomDLHxrf6fcfxegnUf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8432: [IOTDB-4005] Pipeline fragmentInstance to implement parallel execution

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8432: URL: https://github.com/apache/iotdb/pull/8432#issuecomment-1375603495 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8432: [IOTDB-4005] Pipeline fragmentInstance to implement parallel execution

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8432: URL: https://github.com/apache/iotdb/pull/8432#issuecomment-1375539146 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8432: [IOTDB-4005] Pipeline fragmentInstance to implement parallel execution

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8432: URL: https://github.com/apache/iotdb/pull/8432#issuecomment-1375498375 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #8432: [IOTDB-4005] Pipeline fragmentInstance to implement parallel execution

2023-01-09 Thread GitBox
JackieTien97 commented on code in PR #8432: URL: https://github.com/apache/iotdb/pull/8432#discussion_r1064277638 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/fragment/FragmentInstanceExecution.java: ## @@ -124,9 +127,11 @@ private void initialize(CounterStat failed

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8798: [IOTDB-5389] Cause DataNode starup to fail when wal_mode is disabled in IoTConsensus

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8798: URL: https://github.com/apache/iotdb/pull/8798#issuecomment-1375483625 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

<    1   2   3   4   5   6   7   8   9   10   >