[GitHub] [iotdb] OneSizeFitsQuorum opened a new pull request, #8798: [IOTDB-5389] Cause DataNode starup to fail when set wal_mode is disabled in IoTConsensus

2023-01-09 Thread GitBox
OneSizeFitsQuorum opened a new pull request, #8798: URL: https://github.com/apache/iotdb/pull/8798 see [jira5389](https://issues.apache.org/jira/browse/IOTDB-5389) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [iotdb] HTHou merged pull request #8787: Jenkins disable integration

2023-01-09 Thread GitBox
HTHou merged PR #8787: URL: https://github.com/apache/iotdb/pull/8787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] MarcosZyk merged pull request #8792: [IOTDB-5386] Implement SchemaSource Component to Simplify Schema Operators

2023-01-09 Thread GitBox
MarcosZyk merged PR #8792: URL: https://github.com/apache/iotdb/pull/8792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] qiaojialin merged pull request #8796: Change version of master branch to 1.1.0-SNAPSHOT

2023-01-09 Thread GitBox
qiaojialin merged PR #8796: URL: https://github.com/apache/iotdb/pull/8796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] xingtanzjr merged pull request #8774: [To rel/0.13][IOTDB-5206] Set empty target resource to DELETED and then delete it after compaction

2023-01-09 Thread GitBox
xingtanzjr merged PR #8774: URL: https://github.com/apache/iotdb/pull/8774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8666: [IOTDB-5320] Add executeAggregationQuery interface in session API (java)

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8666: URL: https://github.com/apache/iotdb/pull/8666#issuecomment-1375328726 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8666: [IOTDB-5320] Add executeAggregationQuery interface in session API (java)

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8666: URL: https://github.com/apache/iotdb/pull/8666#issuecomment-1375294597 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] liuminghui233 commented on a diff in pull request #8666: [IOTDB-5320] Add executeAggregationQuery interface in session API (java)

2023-01-09 Thread GitBox
liuminghui233 commented on code in PR #8666: URL: https://github.com/apache/iotdb/pull/8666#discussion_r1064398475 ## isession/src/main/java/org/apache/iotdb/isession/util/Aggregation.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iotdb] HTHou merged pull request #8791: [IOTDB-3662] upgrade audit log

2023-01-09 Thread GitBox
HTHou merged PR #8791: URL: https://github.com/apache/iotdb/pull/8791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8666: [IOTDB-5320] Add executeAggregationQuery interface in session API (java)

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #8666: URL: https://github.com/apache/iotdb/pull/8666#issuecomment-1375269338 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] liuminghui233 merged pull request #8772: [IoTDB-5374] Implement MLNode basic service framework

2023-01-09 Thread GitBox
liuminghui233 merged PR #8772: URL: https://github.com/apache/iotdb/pull/8772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.

[GitHub] [iotdb] MarcosZyk merged pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-08 Thread GitBox
MarcosZyk merged PR #8765: URL: https://github.com/apache/iotdb/pull/8765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8796: Change version of master branch to 1.1.0-SNAPSHOT

2023-01-08 Thread GitBox
sonarcloud[bot] commented on PR #8796: URL: https://github.com/apache/iotdb/pull/8796#issuecomment-1375197814 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] Caideyipi opened a new pull request, #8797: [IOTDB-5310] Added removing status to region migration

2023-01-08 Thread GitBox
Caideyipi opened a new pull request, #8797: URL: https://github.com/apache/iotdb/pull/8797 ## IOTDB-5310 ![image](https://user-images.githubusercontent.com/87789683/211257163-56456d8b-63a2-4604-b3ae-36a0f9800e1c.png) ![image](https://user-images.githubusercontent.com/87789683/21125713

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8795: [IOTDB-5387] Refine IT: Make JVM parameters mutable easily

2023-01-08 Thread GitBox
sonarcloud[bot] commented on PR #8795: URL: https://github.com/apache/iotdb/pull/8795#issuecomment-1375195184 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] HTHou opened a new pull request, #8796: Change version to 1.1.0-SNAPSHOT

2023-01-08 Thread GitBox
HTHou opened a new pull request, #8796: URL: https://github.com/apache/iotdb/pull/8796 ## Description Change version of master branch to 1.1.0-SNAPSHOT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [iotdb] ericpai opened a new pull request, #8795: [IOTDB-5387] Refine IT: Make JVM parameters mutable easily

2023-01-08 Thread GitBox
ericpai opened a new pull request, #8795: URL: https://github.com/apache/iotdb/pull/8795 See JIRA: https://issues.apache.org/jira/browse/IOTDB-5387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] xingtanzjr merged pull request #8793: Merge back new commits from 1.0.1 to 1.0 to keep that 1.0 includes all commits of 1.0.1

2023-01-08 Thread GitBox
xingtanzjr merged PR #8793: URL: https://github.com/apache/iotdb/pull/8793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] xingtanzjr opened a new pull request, #8793: Merge back new commits from 1.0.1 to 1.0 to keep that 1.0 includes all commits of 1.0.1

2023-01-08 Thread GitBox
xingtanzjr opened a new pull request, #8793: URL: https://github.com/apache/iotdb/pull/8793 ## Description As we talked, we need to ensure all commits in `rc-x.y.z` exists in `rel/x.y`. Let's do the merge back to `1.0`. ## How this branch comes from ? 1. Check out a new branch (

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-08 Thread GitBox
Cpaulyz commented on code in PR #8765: URL: https://github.com/apache/iotdb/pull/8765#discussion_r1064305558 ## server/src/main/java/org/apache/iotdb/db/metadata/mnode/iterator/AbstractTraverserIterator.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-08 Thread GitBox
Cpaulyz commented on code in PR #8765: URL: https://github.com/apache/iotdb/pull/8765#discussion_r1064296746 ## node-commons/src/main/java/org/apache/iotdb/commons/schema/tree/AbstractTreeVisitor.java: ## @@ -284,10 +293,41 @@ protected final String[] generateFullPathNodes() {

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-08 Thread GitBox
Cpaulyz commented on code in PR #8765: URL: https://github.com/apache/iotdb/pull/8765#discussion_r1064295913 ## server/src/main/java/org/apache/iotdb/db/metadata/mtree/store/CachedMTreeStore.java: ## @@ -609,4 +621,19 @@ public void close() { } } } + + private cl

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-08 Thread GitBox
Cpaulyz commented on code in PR #8765: URL: https://github.com/apache/iotdb/pull/8765#discussion_r1064294772 ## server/src/main/java/org/apache/iotdb/db/metadata/schemaregion/SchemaRegionMemoryImpl.java: ## @@ -1180,72 +1174,37 @@ private void recoverActivatingSchemaTemplate(IA

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-08 Thread GitBox
Cpaulyz commented on code in PR #8765: URL: https://github.com/apache/iotdb/pull/8765#discussion_r1064294581 ## server/src/main/java/org/apache/iotdb/db/metadata/mtree/traverser/counter/DatabaseCounter.java: ## @@ -22,19 +22,33 @@ import org.apache.iotdb.commons.path.PartialPat

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-08 Thread GitBox
Cpaulyz commented on code in PR #8765: URL: https://github.com/apache/iotdb/pull/8765#discussion_r1064293772 ## server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTreeBelowSGMemoryImpl.java: ## @@ -697,7 +754,7 @@ public IMeasurementMNode getMeasurementMNode(PartialPath p

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-08 Thread GitBox
Cpaulyz commented on code in PR #8765: URL: https://github.com/apache/iotdb/pull/8765#discussion_r1064293236 ## server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTreeBelowSGCachedImpl.java: ## @@ -578,39 +592,78 @@ public boolean isEmptyInternalMNode(IMNode node) throws

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-08 Thread GitBox
Cpaulyz commented on code in PR #8765: URL: https://github.com/apache/iotdb/pull/8765#discussion_r1064292189 ## server/src/main/java/org/apache/iotdb/db/metadata/mtree/ConfigMTree.java: ## @@ -460,19 +458,19 @@ protected void transferToResult(IMNode node) { */ public Pair

[GitHub] [iotdb] SpriCoder commented on pull request #8632: [IOTDB-5299][To rel/1.0] The metrics of the size of files is incorrect when the datanode restart

2023-01-08 Thread GitBox
SpriCoder commented on PR #8632: URL: https://github.com/apache/iotdb/pull/8632#issuecomment-1375119723 Please check the CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8788: Revert "[IOTDB-5209] Limit the read rate of compaction execution"

2023-01-08 Thread GitBox
sonarcloud[bot] commented on PR #8788: URL: https://github.com/apache/iotdb/pull/8788#issuecomment-1375089621 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] THUMarkLau merged pull request #8788: Revert "[IOTDB-5209] Limit the read rate of compaction execution"

2023-01-08 Thread GitBox
THUMarkLau merged PR #8788: URL: https://github.com/apache/iotdb/pull/8788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] ZhanGHanG9991 commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-08 Thread GitBox
ZhanGHanG9991 commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1064271315 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/IWindowManager.java: ## @@ -88,4 +88,27 @@ public interface IWindowManager { * @return

[GitHub] [iotdb] MarcosZyk opened a new pull request, #8792: [IOTDB-5386] Implement SchemaSource Component to Simplify Schema Operators

2023-01-08 Thread GitBox
MarcosZyk opened a new pull request, #8792: URL: https://github.com/apache/iotdb/pull/8792 ## Description ### Motivation Schema query has several result types, including device, timeseries and MTree node. Currently, we implemented scan operators for each type's info query, whi

[GitHub] [iotdb] SpriCoder merged pull request #8789: Update ClientManager Javadoc

2023-01-08 Thread GitBox
SpriCoder merged PR #8789: URL: https://github.com/apache/iotdb/pull/8789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8789: Update ClientManager Javadoc

2023-01-08 Thread GitBox
sonarcloud[bot] commented on PR #8789: URL: https://github.com/apache/iotdb/pull/8789#issuecomment-1375045077 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] Caideyipi opened a new pull request, #8790: [IOTDB-5328] Rename "REMOVE_DATANODE_PROCESS" in MIGRATE_REGION_PROCEDURE to "REGION_MIGRATE_PROCEDURE"

2023-01-08 Thread GitBox
Caideyipi opened a new pull request, #8790: URL: https://github.com/apache/iotdb/pull/8790 ## IOTDB-5328 1、Renaming 2、Bug fix This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write -

[GitHub] [iotdb] xingtanzjr opened a new pull request, #8788: Revert "[IOTDB-5209] Limit the read rate of compaction execution"

2023-01-08 Thread GitBox
xingtanzjr opened a new pull request, #8788: URL: https://github.com/apache/iotdb/pull/8788 This reverts commit c5d91a8c284eff1674b42fa049a2b3beec1df616. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
sonarcloud[bot] commented on PR #8787: URL: https://github.com/apache/iotdb/pull/8787#issuecomment-1375026607 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241885 ## server/src/test/resources/logback-test.xml: ## @@ -54,6 +54,10 @@ + + + + Review Comment: ```suggestion ``` -- This is an au

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241811 ## server/src/test/java/org/apache/iotdb/db/utils/EnvironmentUtils.java: ## @@ -157,6 +169,7 @@ public static void cleanEnv() throws IOException, StorageEngineException {

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241712 ## server/src/test/java/org/apache/iotdb/db/utils/EnvironmentUtils.java: ## @@ -134,17 +143,20 @@ public static void cleanEnv() throws IOException, StorageEngineException

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241629 ## server/src/test/java/org/apache/iotdb/db/utils/EnvironmentUtils.java: ## @@ -134,17 +143,20 @@ public static void cleanEnv() throws IOException, StorageEngineException

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241566 ## server/src/test/java/org/apache/iotdb/db/utils/EnvironmentUtils.java: ## @@ -134,17 +143,20 @@ public static void cleanEnv() throws IOException, StorageEngineException

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241499 ## server/src/test/java/org/apache/iotdb/db/utils/EnvironmentUtils.java: ## @@ -113,18 +114,26 @@ public static void cleanEnv() throws IOException, StorageEngineException

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241260 ## server/src/test/java/org/apache/iotdb/db/utils/EnvironmentUtils.java: ## @@ -101,8 +101,9 @@ public class EnvironmentUtils { public static void cleanEnv() throws IO

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241151 ## server/src/test/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessorTest.java: ## @@ -95,8 +95,11 @@ public void setUp() throws DataRegionException { @After

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241072 ## server/src/main/java/org/apache/iotdb/db/wal/recover/WALRecoverManager.java: ## @@ -209,11 +209,14 @@ public void setAllDataRegionScannedLatch(CountDownLatch allDataReg

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064241000 ## server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java: ## @@ -160,6 +162,10 @@ public void waitAllCompactionFinish() { if (total

[GitHub] [iotdb] HTHou commented on a diff in pull request #8787: Jenkins disable integration

2023-01-08 Thread GitBox
HTHou commented on code in PR #8787: URL: https://github.com/apache/iotdb/pull/8787#discussion_r1064240960 ## server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java: ## @@ -146,11 +146,13 @@ public void waitAndStop(long milliseconds) { @TestOn

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8432: [IOTDB-4005] Pipeline fragmentInstance to implement parallel execution

2023-01-08 Thread GitBox
sonarcloud[bot] commented on PR #8432: URL: https://github.com/apache/iotdb/pull/8432#issuecomment-1374821860 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-08 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1064107773 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/process/SlidingWindowAggregationOperator.java: ## @@ -24,8 +24,12 @@ import org.apache.iotdb.db.mpp.exe

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8785: [To rel/1.0][IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager pa

2023-01-07 Thread GitBox
sonarcloud[bot] commented on PR #8785: URL: https://github.com/apache/iotdb/pull/8785#issuecomment-1374740692 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] OneSizeFitsQuorum opened a new pull request, #8785: [To rel/1.0][IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager

2023-01-07 Thread GitBox
OneSizeFitsQuorum opened a new pull request, #8785: URL: https://github.com/apache/iotdb/pull/8785 cherry-pick [pull/8779](https://github.com/apache/iotdb/pull/8779) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8779: [IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager parameters for con

2023-01-07 Thread GitBox
OneSizeFitsQuorum merged PR #8779: URL: https://github.com/apache/iotdb/pull/8779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8779: [IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager parameters for

2023-01-07 Thread GitBox
sonarcloud[bot] commented on PR #8779: URL: https://github.com/apache/iotdb/pull/8779#issuecomment-1374715884 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8765: [IOTDB-4982] Replace recursion algorithm in Traverser with iteration algorithm

2023-01-07 Thread GitBox
MarcosZyk commented on code in PR #8765: URL: https://github.com/apache/iotdb/pull/8765#discussion_r1064071479 ## node-commons/src/main/java/org/apache/iotdb/commons/schema/tree/AbstractTreeVisitor.java: ## @@ -284,10 +293,41 @@ protected final String[] generateFullPathNodes() {

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1064019210 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/EventBooleanWindow.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r106325 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/TimeWindowManager.java: ## @@ -65,14 +80,11 @@ public void next() { // belong to previous wi

[GitHub] [iotdb] xiaoyekanren commented on pull request #8779: [IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager parameters for co

2023-01-07 Thread GitBox
xiaoyekanren commented on PR #8779: URL: https://github.com/apache/iotdb/pull/8779#issuecomment-1374468443 approve ![image](https://user-images.githubusercontent.com/7812383/211151158-417fce4d-8bfb-4de0-b26f-cdd635da298b.png) ![image](https://user-images.githubusercontent.com/

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1063984239 ## server/src/test/java/org/apache/iotdb/db/mpp/execution/operator/OperatorMemoryTest.java: ## @@ -1405,14 +1407,17 @@ public void rawDataAggregationOperatorTest() throws

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1063984206 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/WindowParameter.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [iotdb] HTHou commented on pull request #8766: Chimp compression

2023-01-07 Thread GitBox
HTHou commented on PR #8766: URL: https://github.com/apache/iotdb/pull/8766#issuecomment-1374428776 Hi, there are more code to be update, in order to make Chimp can be used in IoTDB. server/src/main/java/org/apache/iotdb/db/utils/SchemaUtils.java tsfile/src/main/java/org/apache/io

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1063983335 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/WindowParameter.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1063983302 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/WindowParameter.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1063983275 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/WindowParameter.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1063982572 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/process/RawDataAggregationOperator.java: ## @@ -46,19 +46,23 @@ public class RawDataAggregationOperator

[GitHub] [iotdb] ep1github commented on issue #8421: [Bug] REST-API exception on "downsampling aggregate query" when time range with no data is selected

2023-01-07 Thread GitBox
ep1github commented on issue #8421: URL: https://github.com/apache/iotdb/issues/8421#issuecomment-1374426335 @CloudWise-Lukemiao The error is unfortunately **not** yet fixed. I have cecked the issue against the current rel/1.0 branch and the error message is unchanged. Attention: th

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1063982071 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/TimeWindowManager.java: ## @@ -35,10 +42,18 @@ public class TimeWindowManager implements IWindowM

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-07 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1063981664 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-07 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1063981610 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #8644: [IOTDB-4674] Reimplement settle by compaction

2023-01-07 Thread GitBox
xingtanzjr commented on code in PR #8644: URL: https://github.com/apache/iotdb/pull/8644#discussion_r1063981554 ## server/src/main/java/org/apache/iotdb/db/engine/settle/SettleRequestHandler.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [iotdb] qiaojialin commented on pull request #8766: Chimp compression

2023-01-07 Thread GitBox
qiaojialin commented on PR #8766: URL: https://github.com/apache/iotdb/pull/8766#issuecomment-1374414511 Hi Panagiotis, thanks for contribution! Please update the UserGuide, then users could see this encoding: docs/UserGuide/Data-Concept/Encoding.md docs/zh/UserGuide/Data-Conce

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-07 Thread GitBox
JackieTien97 commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1063961361 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/process/SlidingWindowAggregationOperator.java: ## @@ -24,8 +24,12 @@ import org.apache.iotdb.db.m

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8779: [IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager parameters for

2023-01-06 Thread GitBox
sonarcloud[bot] commented on PR #8779: URL: https://github.com/apache/iotdb/pull/8779#issuecomment-1374406665 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8770: [To rel/1.0] [IOTDB-5312] Consolidate ClientManagers in Datanodes for unified management

2023-01-06 Thread GitBox
OneSizeFitsQuorum merged PR #8770: URL: https://github.com/apache/iotdb/pull/8770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum opened a new pull request, #8779: [IOTDB-5384] add core_client_count_for_each_node_in_client_manager and max_client_count_for_each_node_in_client_manager parameters

2023-01-06 Thread GitBox
OneSizeFitsQuorum opened a new pull request, #8779: URL: https://github.com/apache/iotdb/pull/8779 see [jira5384](https://issues.apache.org/jira/browse/IOTDB-5384) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8770: [To rel/1.0] [IOTDB-5312] Consolidate ClientManagers in Datanodes for unified management

2023-01-06 Thread GitBox
OneSizeFitsQuorum commented on code in PR #8770: URL: https://github.com/apache/iotdb/pull/8770#discussion_r1063969742 ## consensus/src/main/java/org/apache/iotdb/consensus/ratis/RatisConsensus.java: ## @@ -812,11 +813,7 @@ public KeyedObjectPool createClientPool( Clie

[GitHub] [iotdb] Beyyes merged pull request #8777: Revert commit 5126711 on master

2023-01-06 Thread GitBox
Beyyes merged PR #8777: URL: https://github.com/apache/iotdb/pull/8777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] ccliushou commented on issue #8618: 关于0.13版本的TsFile 同步方式bug

2023-01-06 Thread GitBox
ccliushou commented on issue #8618: URL: https://github.com/apache/iotdb/issues/8618#issuecomment-1374396783 首先感谢您的回答。针对数据同步,我又进行了测试,发现还是存在一定的问题。测试的版本为:0.13.0 测试过程如下: 1、根据文档描述,配置了 发送端和接收端; 2、删除接收端所有的存储组; 3、在发送端,执行tools\start-sync-client ,发送端将数据(root.XXX存储组)同步到接收端;在两端分别确认时间序列的数据量,

[GitHub] [iotdb] Beyyes merged pull request #8776: Revert the commit 5126711

2023-01-06 Thread GitBox
Beyyes merged PR #8776: URL: https://github.com/apache/iotdb/pull/8776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] SzyWilliam commented on a diff in pull request #8770: [To rel/1.0] [IOTDB-5312] Consolidate ClientManagers in Datanodes for unified management

2023-01-06 Thread GitBox
SzyWilliam commented on code in PR #8770: URL: https://github.com/apache/iotdb/pull/8770#discussion_r1063956308 ## consensus/src/main/java/org/apache/iotdb/consensus/ratis/RatisConsensus.java: ## @@ -812,11 +813,7 @@ public KeyedObjectPool createClientPool( ClientManag

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8777: Revert commit 5126711 on master

2023-01-06 Thread GitBox
sonarcloud[bot] commented on PR #8777: URL: https://github.com/apache/iotdb/pull/8777#issuecomment-1374361962 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8776: Revert the commit 5126711

2023-01-06 Thread GitBox
sonarcloud[bot] commented on PR #8776: URL: https://github.com/apache/iotdb/pull/8776#issuecomment-1374360746 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] xingtanzjr opened a new pull request, #8777: Revert commit 5126711 on master

2023-01-06 Thread GitBox
xingtanzjr opened a new pull request, #8777: URL: https://github.com/apache/iotdb/pull/8777 # Description revert commit 5126711 because this commit decrease the performance of read/write -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [iotdb] xingtanzjr opened a new pull request, #8776: Revert the commit 5126711

2023-01-06 Thread GitBox
xingtanzjr opened a new pull request, #8776: URL: https://github.com/apache/iotdb/pull/8776 ## Description Revert the commit 5126711 because this commit made the performance change regarding write/read -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-06 Thread GitBox
MarcosZyk commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1063938293 ## schema-engine-tag/src/main/java/org/apache/iotdb/lsm/manager/FlushManager.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-06 Thread GitBox
MarcosZyk commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1063937040 ## schema-engine-tag/src/main/java/org/apache/iotdb/lsm/manager/FlushManager.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-06 Thread GitBox
MarcosZyk commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1063934476 ## schema-engine-tag/src/main/java/org/apache/iotdb/db/metadata/tagSchemaRegion/tagIndex/query/MemChunkQuery.java: ## @@ -53,7 +53,8 @@ public List getChildren( * @

[GitHub] [iotdb-web-workbench] dependabot[bot] opened a new pull request, #41: build(deps): bump json5 and @vue/cli-service in /frontend

2023-01-06 Thread GitBox
dependabot[bot] opened a new pull request, #41: URL: https://github.com/apache/iotdb-web-workbench/pull/41 Bumps [json5](https://github.com/json5/json5) to 2.2.3 and updates ancestor dependencies [json5](https://github.com/json5/json5), [json5](https://github.com/json5/json5) and [@vue/cli

[GitHub] [iotdb] ericpai merged pull request #8775: [To rel/1.0][IOTDB-5379] Fix the unit of Prometheus timer metric values

2023-01-06 Thread GitBox
ericpai merged PR #8775: URL: https://github.com/apache/iotdb/pull/8775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

[GitHub] [iotdb] MarcosZyk merged pull request #8771: [IOTDB-5378] Implement Iterating Query for MTree Node Query

2023-01-06 Thread GitBox
MarcosZyk merged PR #8771: URL: https://github.com/apache/iotdb/pull/8771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8771: [IOTDB-5378] Implement Iterating Query for MTree Node Query

2023-01-06 Thread GitBox
MarcosZyk commented on code in PR #8771: URL: https://github.com/apache/iotdb/pull/8771#discussion_r1063425060 ## server/src/main/java/org/apache/iotdb/db/metadata/plan/schemaregion/read/IShowNodesPlan.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8771: [IOTDB-5378] Implement Iterating Query for MTree Node Query

2023-01-06 Thread GitBox
MarcosZyk commented on code in PR #8771: URL: https://github.com/apache/iotdb/pull/8771#discussion_r1063424040 ## server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTreeBelowSGCachedImpl.java: ## @@ -1065,4 +1011,39 @@ public void updateMNode(IMNode node) throws MetadataE

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8775: [To rel/1.0][IOTDB-5379] Fix the unit of Prometheus timer metric values (#8773)

2023-01-06 Thread GitBox
sonarcloud[bot] commented on PR #8775: URL: https://github.com/apache/iotdb/pull/8775#issuecomment-1373576419 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] ericpai opened a new pull request, #8775: [To rel/1.0][IOTDB-5379] Fix the unit of Prometheus timer metric values (#8773)

2023-01-06 Thread GitBox
ericpai opened a new pull request, #8775: URL: https://github.com/apache/iotdb/pull/8775 A cherry-pick of #8773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [iotdb] ericpai merged pull request #8773: [IOTDB-5379] Fix the unit of Prometheus timer metric values

2023-01-06 Thread GitBox
ericpai merged PR #8773: URL: https://github.com/apache/iotdb/pull/8773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

[GitHub] [iotdb] panagiotisl commented on a diff in pull request #8766: Chimp compression

2023-01-06 Thread GitBox
panagiotisl commented on code in PR #8766: URL: https://github.com/apache/iotdb/pull/8766#discussion_r1063355884 ## tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/DoublePrecisionChimpDecoder.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [iotdb] panagiotisl commented on a diff in pull request #8766: Chimp compression

2023-01-06 Thread GitBox
panagiotisl commented on code in PR #8766: URL: https://github.com/apache/iotdb/pull/8766#discussion_r1063355884 ## tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/DoublePrecisionChimpDecoder.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [iotdb] HTHou commented on a diff in pull request #8766: Chimp compression

2023-01-06 Thread GitBox
HTHou commented on code in PR #8766: URL: https://github.com/apache/iotdb/pull/8766#discussion_r1063335356 ## tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/DoublePrecisionChimpDecoder.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [iotdb] panagiotisl commented on a diff in pull request #8766: Chimp compression

2023-01-06 Thread GitBox
panagiotisl commented on code in PR #8766: URL: https://github.com/apache/iotdb/pull/8766#discussion_r1063293330 ## tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/DoublePrecisionChimpDecoder.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8771: [IOTDB-5378] Implement Iterating Query for MTree Node Query

2023-01-06 Thread GitBox
Cpaulyz commented on code in PR #8771: URL: https://github.com/apache/iotdb/pull/8771#discussion_r1063289486 ## server/src/main/java/org/apache/iotdb/db/metadata/plan/schemaregion/read/IShowNodesPlan.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (A

<    1   2   3   4   5   6   7   8   9   10   >