[GitHub] [iotdb] choubenson opened a new pull request, #6625: Fix compaction CI

2022-07-07 Thread GitBox
choubenson opened a new pull request, #6625: URL: https://github.com/apache/iotdb/pull/6625 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] conc

[GitHub] [iotdb] choubenson closed pull request #6625: Fix compaction CI

2022-07-07 Thread GitBox
choubenson closed pull request #6625: Fix compaction CI URL: https://github.com/apache/iotdb/pull/6625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: r

[GitHub] [iotdb] liuminghui233 merged pull request #6626: Fix compaction test

2022-07-07 Thread GitBox
liuminghui233 merged PR #6626: URL: https://github.com/apache/iotdb/pull/6626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6606: [IOTDB-3100] Semantics change of TsFile filename

2022-07-07 Thread GitBox
sonarcloud[bot] commented on PR #6606: URL: https://github.com/apache/iotdb/pull/6606#issuecomment-1178624532 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] hmily3913 opened a new issue, #6627: align by device clauses are not supported

2022-07-08 Thread GitBox
hmily3913 opened a new issue, #6627: URL: https://github.com/apache/iotdb/issues/6627 **Describe the bug** grafana下query中control设置 align by device执行报错,提示align by device clauses are not supported. **Screenshots** ![image](https://user-images.githubusercontent.com/3221165/177

[GitHub] [iotdb] github-actions[bot] commented on issue #6627: align by device clauses are not supported

2022-07-08 Thread GitBox
github-actions[bot] commented on issue #6627: URL: https://github.com/apache/iotdb/issues/6627#issuecomment-1178653987 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To resp

[GitHub] [iotdb] imquanke commented on a diff in pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-08 Thread GitBox
imquanke commented on code in PR #6611: URL: https://github.com/apache/iotdb/pull/6611#discussion_r916549295 ## confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfig.java: ## @@ -62,6 +65,9 @@ public class ConfigNodeConfig { /** The maximum number of Sche

[GitHub] [iotdb] lyssom commented on a diff in pull request #6599: [IOTDB-2569]Support ZSTD Compression

2022-07-08 Thread GitBox
lyssom commented on code in PR #6599: URL: https://github.com/apache/iotdb/pull/6599#discussion_r916552573 ## LICENSE-binary: ## @@ -229,6 +229,7 @@ com.fasterxml.jackson.core:jackson-core:2.10.0 com.fasterxml.jackson.core:jackson-databind:2.10.0 javax.inject:javax.inject:1 n

[GitHub] [iotdb] imquanke commented on a diff in pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-08 Thread GitBox
imquanke commented on code in PR #6611: URL: https://github.com/apache/iotdb/pull/6611#discussion_r916628773 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyRegionAllocator.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [iotdb] qiaojialin merged pull request #6498: [IOTDB-3656] Loader Tool for TsFile

2022-07-08 Thread GitBox
qiaojialin merged PR #6498: URL: https://github.com/apache/iotdb/pull/6498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] selectbook opened a new pull request, #6628: [IOTDB-3520] Support executeBatchStatement for MPP framework

2022-07-08 Thread GitBox
selectbook opened a new pull request, #6628: URL: https://github.com/apache/iotdb/pull/6628 ## Support executeBatchStatement for MPP framework -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [iotdb] choubenson opened a new pull request, #6629: [To rel/0.12]Avoid serializing resource file and adding mods to file that don't contain the device when deleting data

2022-07-08 Thread GitBox
choubenson opened a new pull request, #6629: URL: https://github.com/apache/iotdb/pull/6629 **Description** The resource file will be reserialized every time data is deleted When there is no device corresponding to the timeseries to be deleted in the tsfile, there will still be mod

[GitHub] [iotdb] liuzhen1207 commented on pull request #6599: [IOTDB-2569]Support ZSTD Compression

2022-07-08 Thread GitBox
liuzhen1207 commented on PR #6599: URL: https://github.com/apache/iotdb/pull/6599#issuecomment-1178858704 ![1657278302629](https://user-images.githubusercontent.com/15992443/177980514-26d3af4c-ee3e-4ae2-ac89-cedcbdf7e9bc.png) ZSTD对写入性能有些影响(见数据)。 -- This is an automated message

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-08 Thread GitBox
CRZbulabula commented on code in PR #6611: URL: https://github.com/apache/iotdb/pull/6611#discussion_r916779438 ## confignode/src/assembly/resources/conf/iotdb-confignode.properties: ## @@ -81,6 +81,11 @@ target_config_nodes=0.0.0.0:22277 # Datatype: Double # data_region_per_p

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-08 Thread GitBox
sonarcloud[bot] commented on PR #6622: URL: https://github.com/apache/iotdb/pull/6622#issuecomment-1179221278 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] MarcosZyk merged pull request #6608: [IOTDB-3560]Support basic create and query template

2022-07-08 Thread GitBox
MarcosZyk merged PR #6608: URL: https://github.com/apache/iotdb/pull/6608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] HeimingZ opened a new pull request, #6630: [IOTDB-3787] Multi-leader consensus follower's wal accumulates

2022-07-08 Thread GitBox
HeimingZ opened a new pull request, #6630: URL: https://github.com/apache/iotdb/pull/6630 Fix this problem by updating safely deleted search index after current sync index is updated by removeBatch. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [iotdb] wangchao316 commented on pull request #6580: [IOTDB-3305] cluster-show operation currently does not have the privilege to be granted

2022-07-09 Thread GitBox
wangchao316 commented on PR #6580: URL: https://github.com/apache/iotdb/pull/6580#issuecomment-1179513227 I have a question,if I create a storage group , Does I have read permission of this storage group? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [iotdb] wangchao316 commented on pull request #6515: [IOTDB-3727] Support clear cache in new cluster

2022-07-09 Thread GitBox
wangchao316 commented on PR #6515: URL: https://github.com/apache/iotdb/pull/6515#issuecomment-1179513700 this function ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-09 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917265095 ## confignode/src/main/java/org/apache/iotdb/confignode/client/AsyncDataNodeClientPool.java: ## @@ -212,6 +216,64 @@ public void createDataRegion( } } + /** +

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-09 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917265122 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -123,6 +127,153 @@ private void deleteRegions( } } + /** +

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-09 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917265122 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -123,6 +127,153 @@ private void deleteRegions( } } + /** +

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-09 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917265236 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -123,6 +127,153 @@ private void deleteRegions( } } + /** +

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-09 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917265257 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -124,6 +128,147 @@ private void deleteRegions( } } + /** +

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-09 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917265281 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -124,6 +128,147 @@ private void deleteRegions( } } + /** +

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-09 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917265320 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/DataNodeRemoveManager.java: ## @@ -0,0 +1,689 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iotdb] SpriCoder commented on pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-09 Thread GitBox
SpriCoder commented on PR #6624: URL: https://github.com/apache/iotdb/pull/6624#issuecomment-1179548607 Test on 3C3D: ![image](https://user-images.githubusercontent.com/46039728/178108766-727438fe-949c-4555-8f47-140b57c3e6db.png) -- This is an automated message from the Apache Git

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-09 Thread GitBox
sonarcloud[bot] commented on PR #6622: URL: https://github.com/apache/iotdb/pull/6622#issuecomment-1179568211 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] cmlmakahts opened a new pull request, #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-10 Thread GitBox
cmlmakahts opened a new pull request, #6631: URL: https://github.com/apache/iotdb/pull/6631 Support grammar SHOW (SCHEMA | DATA)? REGIONS (OF STORAGE GROUP prefixPath? (COMMA prefixPath)*)? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [iotdb] wangchao316 commented on a diff in pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-10 Thread GitBox
wangchao316 commented on code in PR #6631: URL: https://github.com/apache/iotdb/pull/6631#discussion_r917479873 ## docs/UserGuide/Maintenance-Tools/Maintenance-Command.md: ## @@ -179,6 +180,81 @@ IoTDB> show schema regions +++--+-+--

[GitHub] [iotdb] HTHou closed pull request #6623: Bump jetty-server from 9.4.35.v20201120 to 10.0.10

2022-07-10 Thread GitBox
HTHou closed pull request #6623: Bump jetty-server from 9.4.35.v20201120 to 10.0.10 URL: https://github.com/apache/iotdb/pull/6623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [iotdb] dependabot[bot] commented on pull request #6623: Bump jetty-server from 9.4.35.v20201120 to 10.0.10

2022-07-10 Thread GitBox
dependabot[bot] commented on PR #6623: URL: https://github.com/apache/iotdb/pull/6623#issuecomment-1179864695 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

[GitHub] [iotdb] lyssom commented on pull request #6599: [IOTDB-2569]Support ZSTD Compression

2022-07-10 Thread GitBox
lyssom commented on PR #6599: URL: https://github.com/apache/iotdb/pull/6599#issuecomment-1179872162 > ![1657278302629](https://user-images.githubusercontent.com/15992443/177980514-26d3af4c-ee3e-4ae2-ac89-cedcbdf7e9bc.png) ZSTD对写入性能有些影响(见数据)。 您好,,麻烦请问这个测试方法是怎样的呢?或者有测试脚本吗?

[GitHub] [iotdb] imquanke commented on a diff in pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-10 Thread GitBox
imquanke commented on code in PR #6611: URL: https://github.com/apache/iotdb/pull/6611#discussion_r917492411 ## confignode/src/assembly/resources/conf/iotdb-confignode.properties: ## @@ -81,6 +81,11 @@ target_config_nodes=0.0.0.0:22277 # Datatype: Double # data_region_per_proc

[GitHub] [iotdb] RYH61 commented on pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-10 Thread GitBox
RYH61 commented on PR #6631: URL: https://github.com/apache/iotdb/pull/6631#issuecomment-1179884093 Can we support `Show regions of [storage group/device/timeseries] prefixPath`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-10 Thread GitBox
CRZbulabula commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917495968 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [iotdb] HTHou commented on a diff in pull request #6599: [IOTDB-2569]Support ZSTD Compression

2022-07-10 Thread GitBox
HTHou commented on code in PR #6599: URL: https://github.com/apache/iotdb/pull/6599#discussion_r917511824 ## LICENSE-binary: ## @@ -278,6 +277,7 @@ BSD 3-Clause org.antlr:antlr-runtime:4.8-1 org.ow2.asm:asm:5.0.4 org.jline:jline:3.21.0 +com.github.luben.zstd-jni:1.3.2-6 Revi

[GitHub] [iotdb] HTHou commented on a diff in pull request #6599: [IOTDB-2569]Support ZSTD Compression

2022-07-10 Thread GitBox
HTHou commented on code in PR #6599: URL: https://github.com/apache/iotdb/pull/6599#discussion_r917511824 ## LICENSE-binary: ## @@ -278,6 +277,7 @@ BSD 3-Clause org.antlr:antlr-runtime:4.8-1 org.ow2.asm:asm:5.0.4 org.jline:jline:3.21.0 +com.github.luben.zstd-jni:1.3.2-6 Revi

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-10 Thread GitBox
CRZbulabula commented on code in PR #6631: URL: https://github.com/apache/iotdb/pull/6631#discussion_r917513103 ## confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java: ## @@ -500,6 +500,11 @@ public TSStatus flush(TFlushReq req)

[GitHub] [iotdb] HTHou commented on a diff in pull request #6628: [IOTDB-3520] Support executeBatchStatement for MPP framework

2022-07-10 Thread GitBox
HTHou commented on code in PR #6628: URL: https://github.com/apache/iotdb/pull/6628#discussion_r917519123 ## server/src/main/java/org/apache/iotdb/db/service/thrift/impl/ClientRPCServiceImpl.java: ## @@ -602,7 +602,63 @@ public TSExecuteStatementResp executeStatement(TSExecuteS

[GitHub] [iotdb] liuzhen1207 commented on pull request #6599: [IOTDB-2569]Support ZSTD Compression

2022-07-10 Thread GitBox
liuzhen1207 commented on PR #6599: URL: https://github.com/apache/iotdb/pull/6599#issuecomment-1179932698 2台8C32G 机器,1台安装iotdb,1台benchmark: iotdb参数配置: MAX_HEAP_SIZE="16G" wal_buffer_size_in_byte=1048576 default_storage_group_level=2 compressor=ZSTD和SNAPPY对比,ZSTD对写入性能影响大。

[GitHub] [iotdb] HTHou commented on a diff in pull request #6628: [IOTDB-3520] Support executeBatchStatement for MPP framework

2022-07-10 Thread GitBox
HTHou commented on code in PR #6628: URL: https://github.com/apache/iotdb/pull/6628#discussion_r917524102 ## server/src/main/java/org/apache/iotdb/db/service/thrift/impl/ClientRPCServiceImpl.java: ## @@ -602,7 +602,63 @@ public TSExecuteStatementResp executeStatement(TSExecuteS

[GitHub] [iotdb] HTHou merged pull request #6555: [CLIENT-PY]Optimize the performance of filling null values

2022-07-10 Thread GitBox
HTHou merged PR #6555: URL: https://github.com/apache/iotdb/pull/6555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] xingtanzjr commented on pull request #6630: [IOTDB-3787] Multi-leader consensus follower's wal accumulates

2022-07-10 Thread GitBox
xingtanzjr commented on PR #6630: URL: https://github.com/apache/iotdb/pull/6630#issuecomment-1179942686 Talked with @HeimingZ regarding to this issue, we think this fix will resolve the problem led by previous PR 6617 -- This is an automated message from the Apache Git Service. To respon

[GitHub] [iotdb] xingtanzjr merged pull request #6630: [IOTDB-3787] Multi-leader consensus follower's wal accumulates

2022-07-10 Thread GitBox
xingtanzjr merged PR #6630: URL: https://github.com/apache/iotdb/pull/6630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] wangchao316 commented on a diff in pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-10 Thread GitBox
wangchao316 commented on code in PR #6611: URL: https://github.com/apache/iotdb/pull/6611#discussion_r917570743 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/CopySetRegionAllocator.java: ## @@ -42,11 +42,9 @@ public class CopySetRegionAlloc

[GitHub] [iotdb] HTHou merged pull request #6619: for the Chinese version of User Guide,delete an extra symbol

2022-07-10 Thread GitBox
HTHou merged PR #6619: URL: https://github.com/apache/iotdb/pull/6619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-10 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917573817 ## confignode/src/test/resources/confignode1conf/iotdb-confignode.properties: ## @@ -20,7 +20,7 @@ internal_address=0.0.0.0 internal_port=22277 consensus_port=22278

[GitHub] [iotdb] qiaojialin merged pull request #6613: [IOTDB-3718] Unify retry logic of SyncClientPool in ConfigNode

2022-07-10 Thread GitBox
qiaojialin merged PR #6613: URL: https://github.com/apache/iotdb/pull/6613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] imquanke commented on a diff in pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-10 Thread GitBox
imquanke commented on code in PR #6611: URL: https://github.com/apache/iotdb/pull/6611#discussion_r917579456 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/CopySetRegionAllocator.java: ## @@ -42,11 +42,9 @@ public class CopySetRegionAllocato

[GitHub] [iotdb] dh-cloud opened a new pull request, #6632: fix aligned timeseries,downsampling query has many null results

2022-07-10 Thread GitBox
dh-cloud opened a new pull request, #6632: URL: https://github.com/apache/iotdb/pull/6632 ## Description when use Aligned timeseries, we found the Downsampling Aggregate Query has many null results in function calcFromBatch(),curReadCurArrayIndex use the max curReadCurArrayInd

[GitHub] [iotdb] imquanke commented on a diff in pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-10 Thread GitBox
imquanke commented on code in PR #6611: URL: https://github.com/apache/iotdb/pull/6611#discussion_r917585077 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/CopySetRegionAllocator.java: ## @@ -42,11 +42,9 @@ public class CopySetRegionAllocato

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-10 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917585865 ## confignode/src/test/resources/confignode1conf/iotdb-confignode.properties: ## @@ -20,7 +20,7 @@ internal_address=0.0.0.0 internal_port=22277 consensus_port=22278 -

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-10 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917586537 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] qiaojialin commented on a diff in pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-10 Thread GitBox
qiaojialin commented on code in PR #6611: URL: https://github.com/apache/iotdb/pull/6611#discussion_r917586506 ## confignode/src/assembly/resources/conf/iotdb-confignode.properties: ## @@ -81,6 +81,13 @@ target_config_nodes=0.0.0.0:22277 # Datatype: Double # data_region_per_pr

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-10 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917586780 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] qiaojialin commented on a diff in pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-10 Thread GitBox
qiaojialin commented on code in PR #6631: URL: https://github.com/apache/iotdb/pull/6631#discussion_r917588346 ## docs/zh/UserGuide/Maintenance-Tools/Maintenance-Command.md: ## @@ -174,6 +176,90 @@ IoTDB> show schema regions +++--+-+

[GitHub] [iotdb] HTHou commented on issue #6627: align by device clauses are not supported in grafana plugin

2022-07-10 Thread GitBox
HTHou commented on issue #6627: URL: https://github.com/apache/iotdb/issues/6627#issuecomment-1180026166 Hi, this is a known issue, we will solve it in v0.14. 您好,这是一个已知问题,我们将会在0.14版本里解决 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [iotdb] liuminghui233 commented on pull request #6632: fix aligned timeseries,downsampling query has many null results

2022-07-10 Thread GitBox
liuminghui233 commented on PR #6632: URL: https://github.com/apache/iotdb/pull/6632#issuecomment-1180027113 This issue may be fixed in 0.13.1-SHAPSHOT by #5796. You can cherry-pick to master branch ~ -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-10 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917593431 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-10 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917593895 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-10 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917597084 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-10 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917598567 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917604993 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917611093 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917611093 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917613588 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-11 Thread GitBox
sonarcloud[bot] commented on PR #6622: URL: https://github.com/apache/iotdb/pull/6622#issuecomment-1180052671 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917617435 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917618364 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917621747 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917621509 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] imquanke commented on a diff in pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-11 Thread GitBox
imquanke commented on code in PR #6611: URL: https://github.com/apache/iotdb/pull/6611#discussion_r917624606 ## confignode/src/assembly/resources/conf/iotdb-confignode.properties: ## @@ -81,6 +81,13 @@ target_config_nodes=0.0.0.0:22277 # Datatype: Double # data_region_per_proc

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917625845 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917627861 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] lyssom commented on a diff in pull request #6599: [IOTDB-2569]Support ZSTD Compression

2022-07-11 Thread GitBox
lyssom commented on code in PR #6599: URL: https://github.com/apache/iotdb/pull/6599#discussion_r917632036 ## LICENSE-binary: ## @@ -278,6 +277,7 @@ BSD 3-Clause org.antlr:antlr-runtime:4.8-1 org.ow2.asm:asm:5.0.4 org.jline:jline:3.21.0 +com.github.luben.zstd-jni:1.3.2-6 Rev

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917632398 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917632650 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917634870 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917637337 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917638203 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917638520 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917639346 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917639858 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917640684 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] lyssom commented on pull request #6599: [IOTDB-2569]Support ZSTD Compression

2022-07-11 Thread GitBox
lyssom commented on PR #6599: URL: https://github.com/apache/iotdb/pull/6599#issuecomment-1180079878 > 2台8C32G 机器,1台安装iotdb,1台benchmark: iotdb参数配置: MAX_HEAP_SIZE="16G" wal_buffer_size_in_byte=1048576 default_storage_group_level=2 > > compressor=ZSTD和SNAPPY对比,ZSTD对写入性能影响大。 benchmark参数配

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917645068 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917650481 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
xingtanzjr commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917652307 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iotdb] SzyWilliam commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-11 Thread GitBox
SzyWilliam commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917645491 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -121,6 +125,157 @@ private void deleteRegions( } } + /** +

[GitHub] [iotdb] SzyWilliam commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-11 Thread GitBox
SzyWilliam commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917656393 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/DataNodeRemoveManager.java: ## @@ -0,0 +1,793 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [iotdb] ericpai opened a new pull request, #6633: Refine Analyzer and LogicalPlanner

2022-07-11 Thread GitBox
ericpai opened a new pull request, #6633: URL: https://github.com/apache/iotdb/pull/6633 Currently, puting analyzing and logical plan generation in a private inner class has some drawbacks: 1. The Outer analyzer and LogicalPlanner logics are mixed with the StatementVisitor implementation

[GitHub] [iotdb] HTHou merged pull request #6618: [IOTDB-3736] Remove DELETED status for TsFileResource

2022-07-11 Thread GitBox
HTHou merged PR #6618: URL: https://github.com/apache/iotdb/pull/6618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] cmlmakahts commented on a diff in pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-11 Thread GitBox
cmlmakahts commented on code in PR #6631: URL: https://github.com/apache/iotdb/pull/6631#discussion_r917729288 ## confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java: ## @@ -500,6 +500,11 @@ public TSStatus flush(TFlushReq req)

[GitHub] [iotdb] cmlmakahts commented on a diff in pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-11 Thread GitBox
cmlmakahts commented on code in PR #6631: URL: https://github.com/apache/iotdb/pull/6631#discussion_r917732857 ## docs/zh/UserGuide/Maintenance-Tools/Maintenance-Command.md: ## @@ -174,6 +176,90 @@ IoTDB> show schema regions +++--+-+

[GitHub] [iotdb] cmlmakahts commented on a diff in pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-11 Thread GitBox
cmlmakahts commented on code in PR #6631: URL: https://github.com/apache/iotdb/pull/6631#discussion_r917732857 ## docs/zh/UserGuide/Maintenance-Tools/Maintenance-Command.md: ## @@ -174,6 +176,90 @@ IoTDB> show schema regions +++--+-+

[GitHub] [iotdb] cmlmakahts commented on pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-11 Thread GitBox
cmlmakahts commented on PR #6631: URL: https://github.com/apache/iotdb/pull/6631#issuecomment-1180181508 > Can we support `Show regions of [storage group/device/timeseries] prefixPath`? It's a good idea, but a bit complicate. Maybe we can just support conditions in sg level currently

[GitHub] [iotdb] Cpaulyz opened a new pull request, #6634: [IOTDB-3788] insertRecord support insert Binary as TEXT DataType

2022-07-11 Thread GitBox
Cpaulyz opened a new pull request, #6634: URL: https://github.com/apache/iotdb/pull/6634 ### Description * Support insert Binary as TEXT DataType * Add `testInsertBinaryAsText` in IT. (New IT-framework doesn't support session API now. So I add test in old IT and it will be migrated lat

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-11 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917762816 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -121,6 +125,157 @@ private void deleteRegions( } } + /** +

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-11 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917763707 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/DataNodeRemoveManager.java: ## @@ -0,0 +1,793 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

<    1   2   3   4   5   6   7   8   9   10   >