[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917768975 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917773192 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,710 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917774416 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917775086 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-11 Thread GitBox
SpriCoder commented on code in PR #6624: URL: https://github.com/apache/iotdb/pull/6624#discussion_r917775725 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/PartitionCache.java: ## @@ -0,0 +1,757 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iotdb] yschengzi opened a new pull request, #6635: [IOTDB-3656] load-tsfile-tool rename to rewrite-tsfile-tool

2022-07-11 Thread GitBox
yschengzi opened a new pull request, #6635: URL: https://github.com/apache/iotdb/pull/6635 rename load-tsfile-tool to rewrite-tsfile-tool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [iotdb] coveralls commented on pull request #6633: Refine Analyzer and LogicalPlanner

2022-07-11 Thread GitBox
coveralls commented on PR #6633: URL: https://github.com/apache/iotdb/pull/6633#issuecomment-1180266126 [![Coverage Status](https://coveralls.io/builds/50748429/badge)](https://coveralls.io/builds/50748429) Coverage increased (+0.03%) to 45.053% when pulling **42769b8f40c5de09e08

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6633: Refine Analyzer and LogicalPlanner

2022-07-11 Thread GitBox
sonarcloud[bot] commented on PR #6633: URL: https://github.com/apache/iotdb/pull/6633#issuecomment-1180270986 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-11 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917843740 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -124,6 +128,147 @@ private void deleteRegions( } } + /** +

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-11 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r917844672 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/DataNodeRemoveManager.java: ## @@ -0,0 +1,793 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iotdb] ericpai merged pull request #6633: Refine Analyzer and LogicalPlanner

2022-07-11 Thread GitBox
ericpai merged PR #6633: URL: https://github.com/apache/iotdb/pull/6633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

[GitHub] [iotdb] wangchao316 merged pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-11 Thread GitBox
wangchao316 merged PR #6631: URL: https://github.com/apache/iotdb/pull/6631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.ap

[GitHub] [iotdb] THUMarkLau opened a new pull request, #6636: [IOTDB-3795] Remove setting read-only when handling compaction exception

2022-07-11 Thread GitBox
THUMarkLau opened a new pull request, #6636: URL: https://github.com/apache/iotdb/pull/6636 See [IOTDB-3795](https://issues.apache.org/jira/browse/IOTDB-3795) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [iotdb] qiaojialin merged pull request #6636: [IOTDB-3795] Remove setting read-only when handling compaction exception

2022-07-11 Thread GitBox
qiaojialin merged PR #6636: URL: https://github.com/apache/iotdb/pull/6636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] THUMarkLau opened a new pull request, #6637: [IOTDB-3795] Remove setting read-only when handling compaction exception

2022-07-11 Thread GitBox
THUMarkLau opened a new pull request, #6637: URL: https://github.com/apache/iotdb/pull/6637 See [IOTDB-3795](https://issues.apache.org/jira/browse/IOTDB-3795) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [iotdb] CRZbulabula opened a new pull request, #6638: [IOTDB-3799] Create read_consistency_level parameter

2022-07-11 Thread GitBox
CRZbulabula opened a new pull request, #6638: URL: https://github.com/apache/iotdb/pull/6638 We need a new global config parameter to indicate the read consistency level: 1. strong: the read requests are always sent to leader replica 2. weak: the read requests are sent to random rep

[GitHub] [iotdb] THUMarkLau merged pull request #6637: [IOTDB-3795] Remove setting read-only when handling compaction exception

2022-07-11 Thread GitBox
THUMarkLau merged PR #6637: URL: https://github.com/apache/iotdb/pull/6637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-11 Thread GitBox
sonarcloud[bot] commented on PR #6622: URL: https://github.com/apache/iotdb/pull/6622#issuecomment-1180475858 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6639: Fix InnerSpaceCompactionExceptionTest

2022-07-11 Thread GitBox
sonarcloud[bot] commented on PR #6639: URL: https://github.com/apache/iotdb/pull/6639#issuecomment-1180605783 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] THUMarkLau merged pull request #6639: Fix InnerSpaceCompactionExceptionTest

2022-07-11 Thread GitBox
THUMarkLau merged PR #6639: URL: https://github.com/apache/iotdb/pull/6639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-11 Thread GitBox
CRZbulabula commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r918066223 ## thrift/src/main/thrift/datanode.thrift: ## @@ -145,6 +156,10 @@ struct TSchemaFetchResponse { 1: required binary serializedSchemaTree } +struct TDisableDataNo

[GitHub] [iotdb] HTHou merged pull request #6634: [IOTDB-3788] insertRecord support insert Binary as TEXT DataType

2022-07-11 Thread GitBox
HTHou merged PR #6634: URL: https://github.com/apache/iotdb/pull/6634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] huangdh12 opened a new issue, #6640: IoTDBDatabaseMetaData call getCatalogs Fail

2022-07-11 Thread GitBox
huangdh12 opened a new issue, #6640: URL: https://github.com/apache/iotdb/issues/6640 Exception in thread "main" java.lang.NullPointerException at org.apache.iotdb.jdbc.GroupedLSBWatermarkEncoder.(GroupedLSBWatermarkEncoder.java:44) at org.apache.iotdb.jdbc.IoTDBDatabaseMeta

[GitHub] [iotdb] github-actions[bot] commented on issue #6640: IoTDBDatabaseMetaData call getCatalogs Fail

2022-07-11 Thread GitBox
github-actions[bot] commented on issue #6640: URL: https://github.com/apache/iotdb/issues/6640#issuecomment-1181244059 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To resp

[GitHub] [iotdb] HTHou merged pull request #6628: [IOTDB-3520] Support executeBatchStatement for MPP framework

2022-07-11 Thread GitBox
HTHou merged PR #6628: URL: https://github.com/apache/iotdb/pull/6628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] wangchao316 merged pull request #6611: [IOTDB-3728] Greedy Region Allocator

2022-07-11 Thread GitBox
wangchao316 merged PR #6611: URL: https://github.com/apache/iotdb/pull/6611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.ap

[GitHub] [iotdb] Beyyes commented on a diff in pull request #6631: [IOTDB-3792] Show region tool support query condition of storage group

2022-07-11 Thread GitBox
Beyyes commented on code in PR #6631: URL: https://github.com/apache/iotdb/pull/6631#discussion_r918506699 ## tsfile/src/main/java/org/apache/iotdb/tsfile/utils/ReadWriteIOUtils.java: ## @@ -815,6 +815,19 @@ public static void writeStringList(List list, ByteBuffer buffer) {

[GitHub] [iotdb] lyssom opened a new pull request, #6642: [IOTDB-3624]Meet error when inserting data in SQL without timestamp

2022-07-12 Thread GitBox
lyssom opened a new pull request, #6642: URL: https://github.com/apache/iotdb/pull/6642 ## Description fix it: https://issues.apache.org/jira/browse/IOTDB-3624 ### Content1 ... ### Content2 ... ### Content3 ... Thi

[GitHub] [iotdb] CRZbulabula opened a new pull request, #6643: [IOTDB-3765] Reinforce DataNode startup process

2022-07-12 Thread GitBox
CRZbulabula opened a new pull request, #6643: URL: https://github.com/apache/iotdb/pull/6643 The startup process of DataNode now only needs one RPC communication and we start the RPC service of DataNode in the end of startup process such that the client can get service as soon as connected.

[GitHub] [iotdb] HTHou merged pull request #6548: [To rel/0.13][IOTDB-3247] Recover aligned sensors after deleting timeseries, query lost data

2022-07-12 Thread GitBox
HTHou merged PR #6548: URL: https://github.com/apache/iotdb/pull/6548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-12 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r918668342 ## confignode/src/main/java/org/apache/iotdb/confignode/consensus/response/DataNodeToStatusResp.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [iotdb] liuminghui233 opened a new pull request, #6644: [IOTDB-3796] Throw exception while using without null clause in MPP

2022-07-12 Thread GitBox
liuminghui233 opened a new pull request, #6644: URL: https://github.com/apache/iotdb/pull/6644 see [IOTDB-3796](https://issues.apache.org/jira/browse/IOTDB-3796). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-12 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r918682973 ## thrift-confignode/src/main/thrift/confignode.thrift: ## @@ -48,6 +58,11 @@ struct TDataNodeRegisterResp { 4: optional TGlobalConfig globalConfig } +struct TData

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-12 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r918685032 ## thrift/src/main/thrift/datanode.thrift: ## @@ -145,6 +156,10 @@ struct TSchemaFetchResponse { 1: required binary serializedSchemaTree } +struct TDisableDataNode

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-12 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r918685114 ## thrift/src/main/thrift/datanode.thrift: ## @@ -35,12 +35,23 @@ struct TInvalidateCacheReq { 2: required string fullPath } -struct TMigrateRegionReq{ -1: r

[GitHub] [iotdb] Cpaulyz opened a new pull request, #6646: [To rel/0.13][IOTDB-3803] failed to insert data of TEXT by session

2022-07-12 Thread GitBox
Cpaulyz opened a new pull request, #6646: URL: https://github.com/apache/iotdb/pull/6646 ### Description Some optimisation of session about TSDataType.TEXT: * insertRecord support Binary type data(#5382) * insertTabalet support TEXT type data(#6634) * document, example and test ab

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-12 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r918687557 ## thrift-confignode/src/main/thrift/confignode.thrift: ## @@ -29,6 +29,16 @@ struct TDataNodeRegisterReq { 2: optional map statusMap } +struct TDataNodeRemoveReq

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-12 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r918687839 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -131,6 +135,157 @@ private void doRetryWait(int retryNum) { } }

[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-12 Thread GitBox
BanDuWuZi commented on code in PR #6236: URL: https://github.com/apache/iotdb/pull/6236#discussion_r918688051 ## confignode/src/main/java/org/apache/iotdb/confignode/client/SyncDataNodeClientPool.java: ## @@ -131,6 +135,157 @@ private void doRetryWait(int retryNum) { } }

[GitHub] [iotdb] HTHou commented on a diff in pull request #6645: [IOTDB-3805] Document and example of TEXT session interface

2022-07-12 Thread GitBox
HTHou commented on code in PR #6645: URL: https://github.com/apache/iotdb/pull/6645#discussion_r918691792 ## docs/UserGuide/API/Programming-Java-Native-API.md: ## @@ -364,6 +364,17 @@ void insertTablets(Map tablet) * Insert a Record, which contains multiple measurement value

[GitHub] [iotdb] HTHou commented on a diff in pull request #6646: [To rel/0.13][IOTDB-3803] failed to insert data of TEXT by session

2022-07-12 Thread GitBox
HTHou commented on code in PR #6646: URL: https://github.com/apache/iotdb/pull/6646#discussion_r918692350 ## docs/UserGuide/API/Programming-Java-Native-API.md: ## @@ -366,6 +366,17 @@ void insertTablets(Map tablet) * Insert a Record, which contains multiple measurement value

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #6646: [To rel/0.13][IOTDB-3803] failed to insert data of TEXT by session

2022-07-12 Thread GitBox
Cpaulyz commented on code in PR #6646: URL: https://github.com/apache/iotdb/pull/6646#discussion_r918696024 ## docs/UserGuide/API/Programming-Java-Native-API.md: ## @@ -366,6 +366,17 @@ void insertTablets(Map tablet) * Insert a Record, which contains multiple measurement valu

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #6645: [IOTDB-3805] Document and example of TEXT session interface

2022-07-12 Thread GitBox
Cpaulyz commented on code in PR #6645: URL: https://github.com/apache/iotdb/pull/6645#discussion_r918696219 ## docs/UserGuide/API/Programming-Java-Native-API.md: ## @@ -364,6 +364,17 @@ void insertTablets(Map tablet) * Insert a Record, which contains multiple measurement valu

[GitHub] [iotdb] xingtanzjr opened a new pull request, #6647: Add more log to the cancellation operation of FragmentInstanceStateTracker

2022-07-12 Thread GitBox
xingtanzjr opened a new pull request, #6647: URL: https://github.com/apache/iotdb/pull/6647 ## Description During our test, we found that sometimes the FragmentInstanceStateTracker may won't be cancelled successfully after the QueryExecution finishing. And it would print lots of logs suc

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #6647: Add more log to the cancellation operation of FragmentInstanceStateTracker

2022-07-12 Thread GitBox
JackieTien97 commented on code in PR #6647: URL: https://github.com/apache/iotdb/pull/6647#discussion_r918713729 ## server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FixedRateFragInsStateTracker.java: ## @@ -43,9 +43,13 @@ public class FixedRateFragInsStateTracker exte

[GitHub] [iotdb] xingtanzjr merged pull request #6624: [IOTDB-3352][IOTDB-3782] Fix the cache problem in PartitionCache and Optimize.

2022-07-12 Thread GitBox
xingtanzjr merged PR #6624: URL: https://github.com/apache/iotdb/pull/6624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] liuminghui233 opened a new pull request, #6648: [IOTDB-3475] Fix ResultSet format for empty query

2022-07-12 Thread GitBox
liuminghui233 opened a new pull request, #6648: URL: https://github.com/apache/iotdb/pull/6648 see IOTDB-3475. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [iotdb] HTHou opened a new pull request, #6649: Add back the logic of blocking insert before holding writelock

2022-07-12 Thread GitBox
HTHou opened a new pull request, #6649: URL: https://github.com/apache/iotdb/pull/6649 ## Description In current 0.13 version, we have a logic of blocking insert if system rejected before holding writelock. See https://github.com/apache/iotdb/blob/203b15bae6a007416f5ad8bd40f64

[GitHub] [iotdb] MrQuansy opened a new pull request, #6650: [IOTDB-3797] Print detail info in session when connection fails

2022-07-12 Thread GitBox
MrQuansy opened a new pull request, #6650: URL: https://github.com/apache/iotdb/pull/6650 Jira: https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-3797 When client connects server timeout, it is better print the ip and port that the client trying to connect in error log. -- Thi

[GitHub] [iotdb] SpriCoder opened a new pull request, #6651: [IOTDB-3807] fix the update of safelyDeletedIndex when single replica.

2022-07-12 Thread GitBox
SpriCoder opened a new pull request, #6651: URL: https://github.com/apache/iotdb/pull/6651 To fix the update of safelyDeletedIndex when single replica, we can just set safelyDeletedIndex to Long.MAX_VALUE and is's no need to update in single replica. -- This is an automated message fro

[GitHub] [iotdb] yunchan86 opened a new pull request, #6652: [IOTDB-3756]Support mount template and query mount info

2022-07-12 Thread GitBox
yunchan86 opened a new pull request, #6652: URL: https://github.com/apache/iotdb/pull/6652 Support mount template and query mount info ```sql IoTDB> create schema template t1 (temperature FLOAT encoding=RLE, status BOOLEAN encoding=PLAIN compression=SNAPPY) Msg: The statement is exe

[GitHub] [iotdb] wangchao316 merged pull request #6236: [IOTDB-3457] start new feature: data node shrink

2022-07-12 Thread GitBox
wangchao316 merged PR #6236: URL: https://github.com/apache/iotdb/pull/6236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.ap

[GitHub] [iotdb] THUMarkLau merged pull request #6641: [To rel/0.13] Fix InnerSpaceCompactionExceptionTest

2022-07-12 Thread GitBox
THUMarkLau merged PR #6641: URL: https://github.com/apache/iotdb/pull/6641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] JackieTien97 opened a new pull request, #6653: [IOTDB-3809] Make query error more specific in Coordinator

2022-07-12 Thread GitBox
JackieTien97 opened a new pull request, #6653: URL: https://github.com/apache/iotdb/pull/6653 In this or, we print more specific error message in coordinator instead of fragment instance cannot be dispatched. You can more details about it in [feishu doc](https://apache-iotdb.feishu.cn/do

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6647: Add more log to the cancellation operation of FragmentInstanceStateTracker

2022-07-12 Thread GitBox
sonarcloud[bot] commented on PR #6647: URL: https://github.com/apache/iotdb/pull/6647#issuecomment-1181641422 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] coveralls commented on pull request #6647: Add more log to the cancellation operation of FragmentInstanceStateTracker

2022-07-12 Thread GitBox
coveralls commented on PR #6647: URL: https://github.com/apache/iotdb/pull/6647#issuecomment-1181646117 [![Coverage Status](https://coveralls.io/builds/50789925/badge)](https://coveralls.io/builds/50789925) Coverage decreased (-0.03%) to 44.956% when pulling **24d544b46d260cf1fba

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6648: [IOTDB-3475] Fix ResultSet format for empty query

2022-07-12 Thread GitBox
sonarcloud[bot] commented on PR #6648: URL: https://github.com/apache/iotdb/pull/6648#issuecomment-1181673344 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6644: [IOTDB-3796] Throw exception while using without null clause in MPP

2022-07-12 Thread GitBox
sonarcloud[bot] commented on PR #6644: URL: https://github.com/apache/iotdb/pull/6644#issuecomment-1181676030 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] coveralls commented on pull request #6644: [IOTDB-3796] Throw exception while using without null clause in MPP

2022-07-12 Thread GitBox
coveralls commented on PR #6644: URL: https://github.com/apache/iotdb/pull/6644#issuecomment-1181682105 [![Coverage Status](https://coveralls.io/builds/50790983/badge)](https://coveralls.io/builds/50790983) Coverage decreased (-0.02%) to 44.967% when pulling **75a6917749cfa13a56d

[GitHub] [iotdb] yifuzhou opened a new pull request, #6654: [IOTDB-3800]Add Node Type Column to 'SHOW CHILD PATHS' query

2022-07-12 Thread GitBox
yifuzhou opened a new pull request, #6654: URL: https://github.com/apache/iotdb/pull/6654 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concur

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6649: Add back the logic of blocking insert before holding writelock

2022-07-12 Thread GitBox
sonarcloud[bot] commented on PR #6649: URL: https://github.com/apache/iotdb/pull/6649#issuecomment-1181704740 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-12 Thread GitBox
JackieTien97 commented on code in PR #6622: URL: https://github.com/apache/iotdb/pull/6622#discussion_r918847673 ## server/src/main/java/org/apache/iotdb/db/mpp/aggregation/Aggregator.java: ## @@ -108,16 +111,12 @@ public void outputResult(ColumnBuilder[] columnBuilder) { }

[GitHub] [iotdb] qiaojialin merged pull request #6649: Add back the logic of blocking insert before holding writelock

2022-07-12 Thread GitBox
qiaojialin merged PR #6649: URL: https://github.com/apache/iotdb/pull/6649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6653: [IOTDB-3809] Make query error more specific in Coordinator

2022-07-12 Thread GitBox
sonarcloud[bot] commented on PR #6653: URL: https://github.com/apache/iotdb/pull/6653#issuecomment-1181762354 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] coveralls commented on pull request #6653: [IOTDB-3809] Make query error more specific in Coordinator

2022-07-12 Thread GitBox
coveralls commented on PR #6653: URL: https://github.com/apache/iotdb/pull/6653#issuecomment-1181769700 [![Coverage Status](https://coveralls.io/builds/50794039/badge)](https://coveralls.io/builds/50794039) Coverage decreased (-0.1%) to 43.805% when pulling **8322e9e83ddc4db1122c

[GitHub] [iotdb] HTHou merged pull request #6650: [IOTDB-3797] Print detailed info in session when connection fails

2022-07-12 Thread GitBox
HTHou merged PR #6650: URL: https://github.com/apache/iotdb/pull/6650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] HTHou merged pull request #6645: [IOTDB-3805] Document and example of TEXT session interface

2022-07-12 Thread GitBox
HTHou merged PR #6645: URL: https://github.com/apache/iotdb/pull/6645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #6652: [IOTDB-3756]Support mount template and query mount info

2022-07-12 Thread GitBox
MarcosZyk commented on code in PR #6652: URL: https://github.com/apache/iotdb/pull/6652#discussion_r919547823 ## confignode/src/main/java/org/apache/iotdb/confignode/manager/ClusterSchemaManager.java: ## @@ -373,6 +376,34 @@ public TGetTemplateResp getTemplate(String req) {

[GitHub] [iotdb] JackieTien97 merged pull request #6629: [To rel/0.12]Avoid serializing resource file and adding mods to file that don't contain the device when deleting data

2022-07-12 Thread GitBox
JackieTien97 merged PR #6629: URL: https://github.com/apache/iotdb/pull/6629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] JackieTien97 merged pull request #6647: Add more log to the cancellation operation of FragmentInstanceStateTracker

2022-07-12 Thread GitBox
JackieTien97 merged PR #6647: URL: https://github.com/apache/iotdb/pull/6647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] HTHou merged pull request #6656: [To rel/0.13][IOTDB-3797] Print detailed info in session when connection fails

2022-07-12 Thread GitBox
HTHou merged PR #6656: URL: https://github.com/apache/iotdb/pull/6656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] HTHou merged pull request #6646: [To rel/0.13][IOTDB-3803] failed to insert data of TEXT by session

2022-07-12 Thread GitBox
HTHou merged PR #6646: URL: https://github.com/apache/iotdb/pull/6646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] SzyWilliam opened a new pull request, #6657: [IOTDB-3650] Add memory control for RatisConsensus

2022-07-12 Thread GitBox
SzyWilliam opened a new pull request, #6657: URL: https://github.com/apache/iotdb/pull/6657 Control: 1. queued write requests 2. heap memory usage 3. direct memory usage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [iotdb] liuminghui233 commented on a diff in pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-12 Thread GitBox
liuminghui233 commented on code in PR #6622: URL: https://github.com/apache/iotdb/pull/6622#discussion_r919603784 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/source/SeriesAggregationScanOperator.java: ## @@ -96,337 +57,6 @@ public SeriesAggregationScanOper

[GitHub] [iotdb] liuminghui233 commented on a diff in pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-12 Thread GitBox
liuminghui233 commented on code in PR #6622: URL: https://github.com/apache/iotdb/pull/6622#discussion_r919605044 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/source/AlignedSeriesScanUtil.java: ## @@ -57,6 +59,60 @@ public AlignedSeriesScanUtil(

[GitHub] [iotdb] liuminghui233 commented on a diff in pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-12 Thread GitBox
liuminghui233 commented on code in PR #6622: URL: https://github.com/apache/iotdb/pull/6622#discussion_r919605122 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/source/AlignedSeriesScanUtil.java: ## @@ -57,6 +59,60 @@ public AlignedSeriesScanUtil(

[GitHub] [iotdb] liuminghui233 commented on a diff in pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-12 Thread GitBox
liuminghui233 commented on code in PR #6622: URL: https://github.com/apache/iotdb/pull/6622#discussion_r919607734 ## server/src/main/java/org/apache/iotdb/db/mpp/aggregation/Aggregator.java: ## @@ -108,16 +111,12 @@ public void outputResult(ColumnBuilder[] columnBuilder) {

[GitHub] [iotdb] MarcosZyk merged pull request #6652: [IOTDB-3756]Support mount template and query mount info

2022-07-12 Thread GitBox
MarcosZyk merged PR #6652: URL: https://github.com/apache/iotdb/pull/6652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6648: [IOTDB-3475] Fix ResultSet format for empty query

2022-07-12 Thread GitBox
sonarcloud[bot] commented on PR #6648: URL: https://github.com/apache/iotdb/pull/6648#issuecomment-1182752670 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6658: [To rel/0.13] rpc service should start after StorageEngine

2022-07-12 Thread GitBox
sonarcloud[bot] commented on PR #6658: URL: https://github.com/apache/iotdb/pull/6658#issuecomment-1182764892 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] xingtanzjr merged pull request #6638: [IOTDB-3799] Create read_consistency_level parameter

2022-07-12 Thread GitBox
xingtanzjr merged PR #6638: URL: https://github.com/apache/iotdb/pull/6638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] qiaojialin merged pull request #6658: [To rel/0.13] rpc service should start after StorageEngine

2022-07-12 Thread GitBox
qiaojialin merged PR #6658: URL: https://github.com/apache/iotdb/pull/6658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] Cpaulyz closed pull request #6035: [IOTDB-3191] implement sync receiver pipe manager in mpp framework

2022-07-12 Thread GitBox
Cpaulyz closed pull request #6035: [IOTDB-3191] implement sync receiver pipe manager in mpp framework URL: https://github.com/apache/iotdb/pull/6035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [iotdb] bigreybear opened a new pull request, #6660: Take memTableMap into account for memory control

2022-07-12 Thread GitBox
bigreybear opened a new pull request, #6660: URL: https://github.com/apache/iotdb/pull/6660 When `memory_control` for memTables enabled, memory overhead of `memTableMap` might be non-negligible if there is a massive amount measurement. This PR take the `memTableMap` into accont while

[GitHub] [iotdb] cornmonster opened a new pull request, #6661: [IOTDB-3784] tag aggregation

2022-07-12 Thread GitBox
cornmonster opened a new pull request, #6661: URL: https://github.com/apache/iotdb/pull/6661 Please see: https://issues.apache.org/jira/browse/IOTDB-3784 For SQL grammar changes and examples: https://apache-iotdb.feishu.cn/docx/doxcnJRODVJEuadoIuBW0uHnmvc -- This is an automated messag

[GitHub] [iotdb] xingtanzjr opened a new pull request, #6662: [IoTDB-3674] Fix the issue that TransformNode is not considered in ExchangeNodeAddr

2022-07-13 Thread GitBox
xingtanzjr opened a new pull request, #6662: URL: https://github.com/apache/iotdb/pull/6662 ## Description The TransformNode is not considered in ExchangeNodeAddr, which will lead to some planning error if the plan contains TransformNode and will be distributed in several regions.

[GitHub] [iotdb] FangJL9495 opened a new pull request, #6663: [IOTDB-3721] Keep each FI's execution timeout consistent with timeout set in session

2022-07-13 Thread GitBox
FangJL9495 opened a new pull request, #6663: URL: https://github.com/apache/iotdb/pull/6663 [IOTDB-3721] Keep each FI's execution timeout consistent with timeout set in session https://issues.apache.org/jira/browse/IOTDB-3721 -- This is an automated message from the Apache Git Service.

[GitHub] [iotdb] HTHou opened a new pull request, #6664: [To rel/0.13] [IOTDB-3816] Fix /zero bug in recover

2022-07-13 Thread GitBox
HTHou opened a new pull request, #6664: URL: https://github.com/apache/iotdb/pull/6664 ## Description Memtable's seriesNumber is 0, we need to avoid "/ by zero". This PR has: - [ ] been self-reviewed. - [ ] concurrent read

[GitHub] [iotdb] qiaojialin merged pull request #6664: [To rel/0.13] [IOTDB-3816] Fix /zero bug in recover

2022-07-13 Thread GitBox
qiaojialin merged PR #6664: URL: https://github.com/apache/iotdb/pull/6664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] MarcosZyk merged pull request #6659: [IOTDB-3811] Add registeredConfigNode into NodeInfo's snapshot

2022-07-13 Thread GitBox
MarcosZyk merged PR #6659: URL: https://github.com/apache/iotdb/pull/6659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #6622: [IOTDB-3714] Refactor operators related to aggregate query to support batch processing

2022-07-13 Thread GitBox
JackieTien97 commented on code in PR #6622: URL: https://github.com/apache/iotdb/pull/6622#discussion_r919565650 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/source/AlignedSeriesAggregationScanOperator.java: ## @@ -77,10 +40,8 @@ public AlignedSeriesAggrega

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #6654: [IOTDB-3800]Add Node Type Column to 'SHOW CHILD PATHS' query

2022-07-13 Thread GitBox
MarcosZyk commented on code in PR #6654: URL: https://github.com/apache/iotdb/pull/6654#discussion_r919834146 ## server/src/main/java/org/apache/iotdb/db/metadata/mtree/IMTreeBelowSG.java: ## @@ -136,8 +137,8 @@ List getMeasurementPaths(PartialPath pathPattern, boolean isPre

[GitHub] [iotdb] HTHou merged pull request #6665: [To rel/0.13] Fix operation sync endless loop

2022-07-13 Thread GitBox
HTHou merged PR #6665: URL: https://github.com/apache/iotdb/pull/6665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] coveralls commented on pull request #6662: [IoTDB-3674] Fix the issue that TransformNode is not considered in ExchangeNodeAddr

2022-07-13 Thread GitBox
coveralls commented on PR #6662: URL: https://github.com/apache/iotdb/pull/6662#issuecomment-1183006018 [![Coverage Status](https://coveralls.io/builds/50824392/badge)](https://coveralls.io/builds/50824392) Coverage decreased (-0.003%) to 43.533% when pulling **bf5b8389ea33ef36e5

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6662: [IoTDB-3674] Fix the issue that TransformNode is not considered in ExchangeNodeAddr

2022-07-13 Thread GitBox
sonarcloud[bot] commented on PR #6662: URL: https://github.com/apache/iotdb/pull/6662#issuecomment-1183008783 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] yifuzhou commented on a diff in pull request #6654: [IOTDB-3800]Add Node Type Column to 'SHOW CHILD PATHS' query

2022-07-13 Thread GitBox
yifuzhou commented on code in PR #6654: URL: https://github.com/apache/iotdb/pull/6654#discussion_r919896929 ## server/src/main/java/org/apache/iotdb/db/metadata/mtree/IMTreeBelowSG.java: ## @@ -136,8 +137,8 @@ List getMeasurementPaths(PartialPath pathPattern, boolean isPre

[GitHub] [iotdb] yifuzhou commented on a diff in pull request #6654: [IOTDB-3800]Add Node Type Column to 'SHOW CHILD PATHS' query

2022-07-13 Thread GitBox
yifuzhou commented on code in PR #6654: URL: https://github.com/apache/iotdb/pull/6654#discussion_r919897167 ## server/src/main/java/org/apache/iotdb/db/metadata/mnode/IMNode.java: ## @@ -88,6 +88,22 @@ public interface IMNode extends Serializable { boolean isMeasurement();

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #6654: [IOTDB-3800]Add Node Type Column to 'SHOW CHILD PATHS' query

2022-07-13 Thread GitBox
MarcosZyk commented on code in PR #6654: URL: https://github.com/apache/iotdb/pull/6654#discussion_r919928418 ## server/src/main/java/org/apache/iotdb/db/metadata/mnode/StorageGroupEntityMNode.java: ## @@ -81,6 +81,11 @@ public boolean isStorageGroup() { return true; }

[GitHub] [iotdb] MarcosZyk commented on pull request #6654: [IOTDB-3800]Add Node Type Column to 'SHOW CHILD PATHS' query

2022-07-13 Thread GitBox
MarcosZyk commented on PR #6654: URL: https://github.com/apache/iotdb/pull/6654#issuecomment-1183060379 Please update the User-Guide doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6664: [To rel/0.13] [IOTDB-3816] Fix /zero bug in recover

2022-07-13 Thread GitBox
sonarcloud[bot] commented on PR #6664: URL: https://github.com/apache/iotdb/pull/6664#issuecomment-1183085530 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

<    1   2   3   4   5   6   7   8   9   10   >