[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #107: [IOTDB-50]fix bug IOTDB-50

[GitBox]

Beyyes commented on a change in pull request #107: [IOTDB-50]fix bug IOTDB-50
URL: https://github.com/apache/incubator-iotdb/pull/107#discussion_r267648247
 
 

 ##
 File path: 
tsfile/src/test/java/org/apache/iotdb/tsfile/utils/TsFileGeneratorForTest.java
 ##
 @@ -108,7 +113,7 @@ static private void generateSampleInputDataFile() throws 
IOException {
   if (i % 9 == 0) {
 d1 += ",s5," + "false";
   }
-  if (i % 10 == 0) {
+  if (i % 10 == 0 && i < minRowCount) {
 
 Review comment:
   why add `minRowCount` and `maxRowCount`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #107: [IOTDB-50]fix bug IOTDB-50

[GitBox]

Beyyes commented on a change in pull request #107: [IOTDB-50]fix bug IOTDB-50
URL: https://github.com/apache/incubator-iotdb/pull/107#discussion_r267648143
 
 

 ##
 File path: 
tsfile/src/test/java/org/apache/iotdb/tsfile/read/ReadOnlyTsFileTest.java
 ##
 @@ -111,6 +106,38 @@ public void queryTest() throws IOException {
   count++;
 }
 Assert.assertEquals(101, count);
+  }
 
+  @Test
+  public void test2() throws InterruptedException, WriteProcessException, 
IOException {
+int minRowCount = 1000, maxRowCount=10;
 
 Review comment:
   format


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services