[GitHub] [incubator-iotdb] SailVR commented on pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem

2020-06-30 Thread GitBox 


SailVR commented on pull request #1443:
URL: https://github.com/apache/incubator-iotdb/pull/1443#issuecomment-652152738


   > > Good job.
   > > However, what will happen if the user defined limit is larger than the 
fetch size? It seems that you didn't deal with this case in your code.
   > 
   > When the limit is larger than fetchSize, we press fetchSize several times 
in the background. Let me add one test when limit>fetchSize
   
   IoTDBSimpleQueryIT.testShowTimeseriesDataSet4()



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-iotdb] SailVR commented on pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem

2020-06-30 Thread GitBox 


SailVR commented on pull request #1443:
URL: https://github.com/apache/incubator-iotdb/pull/1443#issuecomment-652152321


   > Good job.
   > 
   > However, what will happen if the user defined limit is larger than the 
fetch size? It seems that you didn't deal with this case in your code.
   
   When the limit is larger than fetchSize, we press fetchSize several times in 
the background. Let me add one test when limit>fetchSize



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org