[GitHub] [incubator-iotdb] jixuan1989 commented on issue #339: [IOTDB-158] add metrics service

2019-10-14 Thread GitBox
jixuan1989 commented on issue #339: [IOTDB-158] add metrics service
URL: https://github.com/apache/incubator-iotdb/pull/339#issuecomment-542006976
 
 
   One more thing, if there is a markdown document for introducing the tool, it 
could be better.  You can put the markdown file under: 
`docs/Documentation/UserGuide/9-System Tools` (For Chinese version, put it 
under `docs/Documentation-CHN/UserGuide/9-System Tools` 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-iotdb] jixuan1989 commented on issue #339: [IOTDB-158] add metrics service

2019-10-14 Thread GitBox
jixuan1989 commented on issue #339: [IOTDB-158] add metrics service
URL: https://github.com/apache/incubator-iotdb/pull/339#issuecomment-542006014
 
 
   > Usually where we need something like this we download the resource as part 
of the build and take the parts we need and then reference that file. By 
actually adding it to the repo, I guess you have to mention it in the LICENSE 
or NOTICE files.
   
   Declare it in the LICENSE and NOTICE is a choice. You can find a better way 
in the following discussion:
   
   
https://lists.apache.org/thread.html/29be94b4fa6d201445e736946d1e04f29050349ab5ee0a72717e8d84@%3Cdev.iotdb.apache.org%3E
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services