[GitHub] [incubator-iotdb] jt2594838 commented on issue #258: [IOTDB-143]Development of merge
jt2594838 commented on issue #258: [IOTDB-143]Development of merge URL: https://github.com/apache/incubator-iotdb/pull/258#issuecomment-521864538 1. I have provided a config to perform quick recovery. Since there are modifications of existing files, the recovery cannot be delayed or the file status may not be correct. 2. We lack a mechanism of compatibility, which is definitely a BIG job to do. I think we should consider it later instead of messing up here. 3. The design document is merely an introduction of what my idea is, as long as it does not conflict the methodology behind it, I do not think I should explain each line of code in that. And if you follow the calling stack instead of read the source file form top to bottom, you will find most of the fields only function in limited places. There are not many branches in that file and it is almost a straight line, but if you do not follow it, getting lost may be easy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on issue #258: [IOTDB-143]Development of merge
jt2594838 commented on issue #258: [IOTDB-143]Development of merge URL: https://github.com/apache/incubator-iotdb/pull/258#issuecomment-515871478 ![image](https://user-images.githubusercontent.com/23610645/62028087-04ba8980-b212-11e9-9453-aa35b3c34d1c.png) A simple experiment showing the time saved by not using full merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on issue #258: [IOTDB-143]Development of merge
jt2594838 commented on issue #258: [IOTDB-143]Development of merge URL: https://github.com/apache/incubator-iotdb/pull/258#issuecomment-513118429 I have done some simple performance tests on merge and found what makes up its main time consumption, here is the result: ![image](https://user-images.githubusercontent.com/23610645/61516070-b26db180-aa36-11e9-9b6d-6c13aa639189.png) Clearly, writing is not a bottleneck when doing a merge and the query on unseq data takes significantly more time than on seq data (in this experiment, seq data has the same amount as unseq data), overall, the time spent on reading unseq data, reading seq data, writing merged data is 5:3:1. In order to speed-up merge, speeding up querying is the first concern. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services