[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-25 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r494226587 ## File path: tsfile/src/test/java/org/apache/iotdb/tsfile/write/writer/MeasurementSchemaSerializeTest.java ## @@ -0,0 +1,37 @@ +package org.a

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-24 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r494226587 ## File path: tsfile/src/test/java/org/apache/iotdb/tsfile/write/writer/MeasurementSchemaSerializeTest.java ## @@ -0,0 +1,37 @@ +package org.a

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492563096 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/CompressionType.java ## @@ -52,6 +52,35 @@ public static Compre

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492600924 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/write/schema/MeasurementSchema.java ## @@ -98,12 +98,11 @@ public static Measuremen

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492600695 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/TSEncoding.java ## @@ -51,6 +51,35 @@ public static TSEncoding

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492563096 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/CompressionType.java ## @@ -52,6 +52,35 @@ public static Compre