[kudu-CR] dist-test: support test result reporting

2019-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13068 ) Change subject: dist-test: support test result reporting .. Patch Set 1: Verified+1 Overriding Jenkins, known Java flakes. -- To view,

[kudu-CR] dist-test: support test result reporting

2019-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13068 ) Change subject: dist-test: support test result reporting .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] master: use AuthzProvider to generate authz tokens

2019-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: master: use AuthzProvider to generate authz tokens .. Patch Set 6: Code-Review+1 -- To view, visit

[kudu-CR] dist-test: support test result reporting

2019-04-19 Thread Adar Dembo (Code Review)
Hello Mike Percy, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13068 to review the following change. Change subject: dist-test: support test result reporting ..

[kudu-CR] hybrid clock: use different message when injecting errors

2019-04-19 Thread Adar Dembo (Code Review)
Hello Mike Percy, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13067 to review the following change. Change subject: hybrid_clock: use different message when injecting errors

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. [ksck] Make ksck tool more concurrent Though ksck fetches tserver info

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [master] modernize code w.r.t. virtual/override keywords

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13066 ) Change subject: [master] modernize code w.r.t. virtual/override keywords .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. Patch Set 6: (3 comments)

[kudu-CR] Bump Sentry version

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] Bump Sentry version

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 2: (1 comment)

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: (1 comment)

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: (2 comments)

[kudu-CR] [catalog manager] simplify lifecycle of authz provider

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13062 ) Change subject: [catalog_manager] simplify lifecycle of authz provider .. Patch Set 1: Code-Review+2 Hao and I had a related discussion

[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 ) Change subject: [docs] updated master-related scenarios w.r.t. CM roles .. Patch Set 2: (1 comment)

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. Patch Set 5: (3 comments)

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. Patch Set 4: (2 comments) The test failures look legitimate.

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13011 ) Change subject: generic_iterators: MergeIterator whole block copy optimization .. Patch Set 6: Verified+1 Overriding Jenkins, unrelated

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13011 ) Change subject: generic_iterators: MergeIterator whole block copy optimization .. generic_iterators: MergeIterator whole block

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13011 ) Change subject: generic_iterators: MergeIterator whole block copy optimization .. Removed reviewer Kudu Jenkins with the

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-17 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13011 to look at the new patch set (#6). Change subject: generic_iterators: MergeIterator whole block copy optimization

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13011 ) Change subject: generic_iterators: MergeIterator whole block copy optimization .. Patch Set 6: (3 comments)

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13010 ) Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization .. generic_iterators: refactor

[kudu-CR] rowblock: add copying functionality

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. rowblock: add copying functionality This patch adds RowBlock::CopyTo, a

[kudu-CR] SelectionVector: pad extra bits with zeroes in constructor

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13009 ) Change subject: SelectionVector: pad extra bits with zeroes in constructor .. SelectionVector: pad extra bits with zeroes in

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13010 ) Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization .. Removed reviewer Kudu Jenkins

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13010 ) Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization .. Patch Set 5: Verified+1 Overriding

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13010 ) Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization .. Patch Set 5: > As far as I can tell you

[kudu-CR] rowblock: add copying functionality

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by

[kudu-CR] rowblock: add copying functionality

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Patch Set 5: Verified+1 Overriding Jenkins, known Java test flakes. -- To view,

[kudu-CR] SelectionVector: pad extra bits with zeroes in constructor

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13009 ) Change subject: SelectionVector: pad extra bits with zeroes in constructor .. Patch Set 5: (1 comment)

[kudu-CR] Bump Sentry version

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13059/1//COMMIT_MSG Commit

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. Patch Set 3: (4 comments)

[kudu-CR] [master] remove tserver service proto from libmaster

2019-04-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13054 ) Change subject: [master] remove tserver_service_proto from libmaster .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] rowblock: add copying functionality

2019-04-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Patch Set 5: (1 comment)

[kudu-CR] rowblock: add copying functionality

2019-04-16 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13008 to look at the new patch set (#5). Change subject: rowblock: add copying functionality ..

[kudu-CR] bitmap: add copy operation

2019-04-16 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13007 ) Change subject: bitmap: add copy operation .. bitmap: add copy operation This can be used to copy an arbitrary subsection of a

[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM

2019-04-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 ) Change subject: WIP [docs] updated master-related scenarios w.r.t. CM .. Patch Set 1: (2 comments)

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-16 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13021 ) Change subject: log_block_manager: reenable dead container deletion at runtime .. Removed reviewer Kudu Jenkins with the

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-16 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13021 ) Change subject: log_block_manager: reenable dead container deletion at runtime .. log_block_manager: reenable dead container

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-16 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, Andrew Wong, helifu, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13021 to look at the new patch set (#2). Change subject: log_block_manager: reenable dead container deletion at runtime

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13021 ) Change subject: log_block_manager: reenable dead container deletion at runtime .. Patch Set 2: (1 comment)

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-15 Thread Adar Dembo (Code Review)
Hello Andrew Wong, helifu, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13021 to review the following change. Change subject: log_block_manager: reenable dead container deletion at runtime

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13011 ) Change subject: generic_iterators: MergeIterator whole block copy optimization .. Removed reviewer Kudu Jenkins with the

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13011 ) Change subject: generic_iterators: MergeIterator whole block copy optimization .. Patch Set 4: Verified+1 Overriding Jenkins, unrelated

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization .. Removed Verified+1 by Adar Dembo -- To view, visit

[kudu-CR] SelectionVector: pad extra bits with zeroes in constructor

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13009 ) Change subject: SelectionVector: pad extra bits with zeroes in constructor .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] SelectionVector: pad extra bits with zeroes in constructor

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13009 ) Change subject: SelectionVector: pad extra bits with zeroes in constructor .. Patch Set 4: Verified+1 Overriding Jenkins, known flaky

[kudu-CR] KUDU-2466: implement three-heap merge algorithm

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12947 ) Change subject: KUDU-2466: implement three-heap merge algorithm .. KUDU-2466: implement three-heap merge algorithm This patch

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 4: Code-Review+1 Would be good to get another set

[kudu-CR] KUDU-2466: implement three-heap merge algorithm

2019-04-15 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12947 to look at the new patch set (#10). Change subject: KUDU-2466: implement three-heap merge algorithm

[kudu-CR] bitmap: add copy operation

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13007 to look at the new patch set (#3). Change subject: bitmap: add copy operation .. bitmap:

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13010 to look at the new patch set (#4). Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13011 to look at the new patch set (#4). Change subject: generic_iterators: MergeIterator whole block copy optimization

[kudu-CR] rowblock: add copying functionality

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13008 to look at the new patch set (#4). Change subject: rowblock: add copying functionality .. rowblock: add

[kudu-CR] SelectionVector: pad extra bits with zeroes in constructor

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13009 to look at the new patch set (#4). Change subject: SelectionVector: pad extra bits with zeroes in constructor

[kudu-CR] generic iterators: pass rowset bounds into grouping iterators

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12946 ) Change subject: generic_iterators: pass rowset bounds into grouping iterators .. generic_iterators: pass rowset bounds into

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 3: (2 comments)

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 3: (2 comments)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (1 comment)

[kudu-CR] rowblock: add copying functionality

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Patch Set 3: Verified+1 Overriding Jenkins, known Java flakes. -- To view,

[kudu-CR] rowblock: add copying functionality

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by

[kudu-CR] WIP: [backup] Add incremental backup/restore support

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: WIP: [backup] Add incremental backup/restore support .. Patch Set 2: (11 comments)

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13010 ) Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization .. Patch Set 3: Verified+1 Overriding

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13010 ) Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization .. Removed reviewer Kudu Jenkins

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (5 comments) I only skimmed the new tests; I

[kudu-CR] rowblock: add copying functionality

2019-04-14 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13008 to look at the new patch set (#3). Change subject: rowblock: add copying functionality ..

[kudu-CR] [jenkins] fix collection of Java dist-test logs

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13014 ) Change subject: [jenkins] fix collection of Java dist-test logs .. Patch Set 1: (1 comment)

[kudu-CR] rowblock: add copying functionality

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13008 ) Change subject: rowblock: add copying functionality .. Patch Set 2: Verified+1 Overriding Jenkins, hit KUDU-2059. -- To view, visit

[kudu-CR] [build] Fix the java compatibility checker script

2019-04-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13004 ) Change subject: [build] Fix the java compatibility checker script .. Patch Set 1: (2 comments) What are the next steps once this is

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-12 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13010 to look at the new patch set (#2). Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization

[kudu-CR] KUDU-2466: implement three-heap merge algorithm

2019-04-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12947 ) Change subject: KUDU-2466: implement three-heap merge algorithm .. Patch Set 9: (4 comments)

[kudu-CR] KUDU-2466: implement three-heap merge algorithm

2019-04-12 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12947 to look at the new patch set (#9). Change subject: KUDU-2466: implement three-heap merge algorithm

[kudu-CR] SelectionVector: pad extra bits with zeroes in constructor

2019-04-12 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13009 to review the following change. Change subject: SelectionVector: pad extra bits with zeroes in constructor

[kudu-CR] generic iterators: pass rowset bounds into grouping iterators

2019-04-12 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12946 to look at the new patch set (#7). Change subject: generic_iterators: pass rowset bounds into grouping iterators

[kudu-CR] generic iterators: pass rowset bounds into grouping iterators

2019-04-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12946 ) Change subject: generic_iterators: pass rowset bounds into grouping iterators .. Patch Set 6: (3 comments)

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-12 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13010 to review the following change. Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-12 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13011 to review the following change. Change subject: generic_iterators: MergeIterator whole block copy optimization

[kudu-CR] rowblock: add copying functionality

2019-04-12 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13008 to review the following change. Change subject: rowblock: add copying functionality .. rowblock: add

[kudu-CR] bitmap: add copy operation

2019-04-12 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13007 to review the following change. Change subject: bitmap: add copy operation .. bitmap: add copy operation

[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12997 ) Change subject: [docs] updated docs w.r.t. collocation practices .. Patch Set 4: (1 comment)

[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12997 ) Change subject: [docs] updated docs w.r.t. collocation practices .. Patch Set 2: (1 comment)

[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12997 ) Change subject: [docs] updated docs w.r.t. collocation practices .. Patch Set 1: (5 comments)

[kudu-CR] [docs] Add maximum tablet size recommendations

2019-04-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12979 ) Change subject: [docs] Add maximum tablet size recommendations .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12976 ) Change subject: tool: fixes for kudu local_replica dump rowset .. tool: fixes for kudu local_replica dump rowset This patch

[kudu-CR] experiments: merge iterator optimization tests

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12587 ) Change subject: experiments: merge iterator optimization tests .. experiments: merge iterator optimization tests Here's a brief

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 3: (2 comments)

[kudu-CR] [docs] Adjust latency and bandwidth limitations

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12970 ) Change subject: [docs] Adjust latency and bandwidth limitations .. Patch Set 3: (1 comment)

[kudu-CR] tools: escape brackets when generating XML

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 ) Change subject: tools: escape brackets when generating XML .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [docs] Adjust latency and bandwidth limitations

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12970 ) Change subject: [docs] Adjust latency and bandwidth limitations .. Patch Set 2: (1 comment)

[kudu-CR] [docs] Adjust latency and bandwidth limitations

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12970 ) Change subject: [docs] Adjust latency and bandwidth limitations .. Patch Set 1: (1 comment)

[kudu-CR] tools: escape brackets when generating XML

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 ) Change subject: tools: escape brackets when generating XML .. Patch Set 2: (1 comment)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 11: (1 comment)

[kudu-CR] [master] introduce SentryPrivilegesFetcher

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: [master] introduce SentryPrivilegesFetcher .. Patch Set 12: Code-Review+1 (1 comment)

[kudu-CR] [SentryPrivilegesFetcher] deduplicate RPCs to Sentry

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12967 ) Change subject: [SentryPrivilegesFetcher] deduplicate RPCs to Sentry .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12976 to look at the new patch set (#4). Change subject: tool: fixes for kudu local_replica dump rowset

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12976 ) Change subject: tool: fixes for kudu local_replica dump rowset .. Patch Set 2: (2 comments)

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12976 to look at the new patch set (#3). Change subject: tool: fixes for kudu local_replica dump rowset

[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12944 ) Change subject: generic_iterators: switch MergeIterator to intrusive list of states .. generic_iterators: switch MergeIterator

[kudu-CR] generic iterators: implement three-heap merge algorithm

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12947 ) Change subject: generic_iterators: implement three-heap merge algorithm .. Removed reviewer Kudu Jenkins with the following

  1   2   3   4   5   6   7   8   9   10   >