[kudu-CR] [authz] updated SentryAuthzProvider caching strategy

2019-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13069 ) Change subject: [authz] updated SentryAuthzProvider caching strategy .. Patch Set 2: (3 comments) I need to head out now, but jotted

[kudu-CR] master: use AuthzProvider to generate authz tokens

2019-04-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13013 to look at the new patch set (#7). Change subject: master: use AuthzProvider to generate authz tokens

[kudu-CR] Bump Sentry version

2019-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Bump Sentry version The motivation is to get access to SENTRY-2471, which includes a fix

[kudu-CR] master: use AuthzProvider to generate authz tokens

2019-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: master: use AuthzProvider to generate authz tokens .. Patch Set 6: (1 comment)

[kudu-CR] master: use AuthzProvider to generate authz tokens

2019-04-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13013 to look at the new patch set (#6). Change subject: master: use AuthzProvider to generate authz tokens

[kudu-CR] master: use AuthzProvider to generate authz tokens

2019-04-19 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13013 to look at the new patch set (#5). Change subject: master: use AuthzProvider to generate authz tokens

[kudu-CR] Bump Sentry version

2019-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#3) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Bump Sentry version The motivation is to get access to

[kudu-CR] master: use AuthzProvider to generate authz tokens

2019-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: master: use AuthzProvider to generate authz tokens .. Patch Set 5: (4 comments)

[kudu-CR] Bump Sentry version

2019-04-19 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13059 To

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: (3 comments)

[kudu-CR] [catalog manager] simplify lifecycle of authz provider

2019-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13062 ) Change subject: [catalog_manager] simplify lifecycle of authz provider .. Patch Set 1: Code-Review+2 (1 comment) LGTM but I second

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: (3 comments) High level pass so far, so just

[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles

2019-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 ) Change subject: [docs] updated master-related scenarios w.r.t. CM roles .. Patch Set 2: (1 comment)

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13021 ) Change subject: log_block_manager: reenable dead container deletion at runtime .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13021 ) Change subject: log_block_manager: reenable dead container deletion at runtime .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (1 comment)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (1 comment)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (4 comments)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (1 comment)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (3 comments)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-13 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13013 to look at the new patch set (#4). Change subject: WIP master: use AuthzProvider to generate authz tokens

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-13 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13013 to look at the new patch set (#3). Change subject: WIP master: use AuthzProvider to generate authz tokens

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-13 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13013 to look at the new patch set (#2). Change subject: WIP master: use AuthzProvider to generate authz tokens .. WIP

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-13 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13013 Change subject: WIP master: use AuthzProvider to generate authz tokens .. WIP master: use AuthzProvider to generate authz tokens This

[kudu-CR] KUDU-2762: Improve write transaction tracing

2019-04-12 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12999 ) Change subject: KUDU-2762: Improve write transaction tracing .. KUDU-2762: Improve write transaction tracing The trace logging

[kudu-CR] KUDU-2762: Improve write transaction tracing

2019-04-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12999 ) Change subject: KUDU-2762: Improve write transaction tracing .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [mini-sentry] do not run the "store-cleaner" thread

2019-04-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12995 ) Change subject: [mini-sentry] do not run the "store-cleaner" thread .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [mini-sentry] increase timeout for Sentry startup

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12990 ) Change subject: [mini-sentry] increase timeout for Sentry startup .. Patch Set 1: Code-Review+2 Interesting, I wonder if Hao has any

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12976 ) Change subject: tool: fixes for kudu local_replica dump rowset .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [SentryPrivilegesFetcher] deduplicate RPCs to Sentry

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12967 ) Change subject: [SentryPrivilegesFetcher] deduplicate RPCs to Sentry .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] [master] introduce SentryPrivilegesFetcher

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: [master] introduce SentryPrivilegesFetcher .. Patch Set 13: Code-Review+2 (1 comment)

[kudu-CR](branch-1.9.x) tools: escape brackets when generating XML

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12988 ) Change subject: tools: escape brackets when generating XML .. tools: escape brackets when generating XML When building the

[kudu-CR](branch-1.9.x) tools: escape brackets when generating XML

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12988 Change subject: tools: escape brackets when generating XML .. tools: escape brackets when generating XML When building the site, we

[kudu-CR] tools: escape brackets when generating XML

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12981 ) Change subject: tools: escape brackets when generating XML .. tools: escape brackets when generating XML When building the

[kudu-CR] tools: escape brackets when generating XML

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 ) Change subject: tools: escape brackets when generating XML .. Patch Set 3: Verified+1 Failure seems unrelated. -- To view, visit

[kudu-CR] tools: escape brackets when generating XML

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: tools: escape brackets when generating XML .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12981 To unsubscribe, visit

[kudu-CR] tools: escape brackets when generating XML

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 ) Change subject: tools: escape brackets when generating XML .. Patch Set 3: (1 comment)

[kudu-CR] tools: escape brackets when generating XML

2019-04-10 Thread Andrew Wong (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12981 to look at the new patch set (#3). Change subject: tools: escape brackets when generating XML

[kudu-CR] [SentryPrivilegesFetcher] deduplicate RPCs to Sentry

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12967 ) Change subject: [SentryPrivilegesFetcher] deduplicate RPCs to Sentry .. Patch Set 3: Code-Review+1 (1 comment) LGTM, just one

[kudu-CR] [master] introduce SentryPrivilegesFetcher

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: [master] introduce SentryPrivilegesFetcher .. Patch Set 12: Code-Review+1 (6 comments)

[kudu-CR] tools: escape brackets when generating XML

2019-04-10 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 ) Change subject: tools: escape brackets when generating XML .. Patch Set 2: This should be backported to 1.9.x as well. -- To view,

[kudu-CR] tools: escape brackets when generating XML

2019-04-09 Thread Andrew Wong (Code Review)
Hello Will Berkeley, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12981 to look at the new patch set (#2). Change subject: tools: escape brackets when generating XML

[kudu-CR] tools: escape brackets when generating XML

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12981 Change subject: tools: escape brackets when generating XML .. tools: escape brackets when generating XML When building the site, we

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12976 ) Change subject: tool: fixes for kudu local_replica dump rowset .. Patch Set 2: (2 comments)

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. sentry: populate TablePrivilegePBs This patch allows the authz provider

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12945 To

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#7). Change subject: sentry: populate TablePrivilegePBs

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 7: (1 comment)

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 5: -Verified Rebased -- To view, visit

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#6). Change subject: sentry: populate TablePrivilegePBs

[kudu-CR] sentry authz provider-test: fix logical conflict

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: sentry_authz_provider-test: fix logical conflict .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12971 To unsubscribe,

[kudu-CR] sentry authz provider-test: fix logical conflict

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12971 ) Change subject: sentry_authz_provider-test: fix logical conflict .. Patch Set 1: Verified+1 Known flake. -- To view, visit

[kudu-CR] sentry authz provider-test: fix logical conflict

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12971 ) Change subject: sentry_authz_provider-test: fix logical conflict .. sentry_authz_provider-test: fix logical conflict A couple

[kudu-CR] sentry authz provider-test: fix logical conflict

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12971 to review the following change. Change subject: sentry_authz_provider-test: fix logical conflict ..

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 3: Code-Review+2 Thanks for checking! -- To view, visit

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. KUDU-2764: reduce runtime of

[kudu-CR] [HaClient] introduce client metrics

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: [HaClient] introduce client metrics .. Patch Set 6: Code-Review+2 (1 comment)

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 2: (3 comments)

[kudu-CR] [SentryAuthzProvider] deduplicate RPCs to Sentry

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12967 ) Change subject: [SentryAuthzProvider] deduplicate RPCs to Sentry .. Patch Set 1: (6 comments)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12966 to look at the new patch set (#4). Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12966 to look at the new patch set (#2). Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 3: > Patch Set 3: > > (2 comments) Actually after

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryPrivilegesFetcher .. Patch Set 10: (1 comment)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12966 to look at the new patch set (#3). Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 1: > Patch Set 1: > > How important is this

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 5: Verified+1 A couple of Java flakies. -- To view, visit

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: sentry: populate TablePrivilegePBs .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12941 To unsubscribe, visit

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 5: (6 comments)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12966 Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. KUDU-2764: reduce runtime of sentry_authz_provider-test This

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#5). Change subject: sentry: populate TablePrivilegePBs

[kudu-CR] authz: authorize ListTablets

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11752 ) Change subject: authz: authorize ListTablets .. authz: authorize ListTablets See the comment in tablet_service.h for details.

[kudu-CR] [HaClient] introduce client metrics

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: [HaClient] introduce client metrics .. Patch Set 5: Code-Review+1 (1 comment)

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 4: (3 comments)

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-08 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#4). Change subject: sentry: populate TablePrivilegePBs

[kudu-CR] authz: authorize ListTablets

2019-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11752 ) Change subject: authz: authorize ListTablets .. Patch Set 4: Verified+1 Flaky: KUDU-2718 -- To view, visit

[kudu-CR] authz: authorize ListTablets

2019-04-08 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: authz: authorize ListTablets .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11752 To unsubscribe, visit

[kudu-CR] authz: authorize ListTablets

2019-04-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11752 ) Change subject: authz: authorize ListTablets .. Patch Set 4: (1 comment)

[kudu-CR] tool: perf tablet scan action

2019-04-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 1: (1 comment)

[kudu-CR] sentry: generate TablePrivilegePBs

2019-04-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: generate TablePrivilegePBs .. Patch Set 3: (6 comments)

[kudu-CR] sentry: generate TablePrivilegePBs

2019-04-07 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#3). Change subject: sentry: generate TablePrivilegePBs

[kudu-CR] authz: authorize ListTablets

2019-04-06 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11752 to look at the new patch set (#4). Change subject: authz: authorize ListTablets

[kudu-CR] authz: authorize ListTablets

2019-04-06 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11752 to look at the new patch set (#3). Change subject: authz: authorize ListTablets

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 11: (3 comments)

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryPrivilegesFetcher .. Patch Set 9: (17 comments)

[kudu-CR] tool: perf tablet scan action

2019-04-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 1: (1 comment)

[kudu-CR] authz: authorize ListTablets

2019-04-05 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11752 to look at the new patch set (#2). Change subject: authz: authorize ListTablets .. authz:

[kudu-CR] authz: add interface for generating authz tokens

2019-04-05 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/12896 ) Change subject: authz: add interface for generating authz tokens .. Abandoned This is being done in another patch. -- To view, visit

[kudu-CR] wip sentry: generate authz tokens

2019-04-05 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/12897 ) Change subject: wip sentry: generate authz tokens .. Abandoned This is split into multiple other patches. -- To view, visit

[kudu-CR] sentry: generate table privileges

2019-04-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#2). Change subject: sentry: generate table privileges .. sentry: generate table

[kudu-CR] sentry: generate table privileges

2019-04-05 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12941 Change subject: sentry: generate table privileges .. sentry: generate table privileges This patch adds token generation to the authz

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 10: (1 comment)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 10: (9 comments)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#10). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#9). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#8). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#7). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#6). Change subject: sentry: sanitize and parse privileges from Sentry

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 5: (1 comment)

  1   2   3   4   5   6   7   8   9   10   >