[kudu-CR] KUDU-3371 [fs] make LogBlockContainer a base class

2023-05-11 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19610 ) Change subject: KUDU-3371 [fs] make LogBlockContainer a base class .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate

2023-05-11 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19794 ) Change subject: [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate .. Patch Set 7:

[kudu-CR] KUDU-3452 Allow creating tablets under replicated tables

2023-05-11 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Allow creating tablets under replicated tables .. Patch Set 23: (3 comments)

[kudu-CR] KUDU-3452 Allow creating tablets under replicated tables

2023-05-11 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19571 to look at the new patch set (#23). Change subject: KUDU-3452 Allow creating tablets under replicated tables

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-11 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 ) Change subject: [KUDU-3452] Make validate tablet creating task not affected .. Patch Set 21: (1 comment) > Patch Set 20: > > (1 comment)

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-11 Thread Wang Xixu (Code Review)
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19594 to look at the new patch set (#21). Change subject: [KUDU-3452] Make validate tablet creating task not affected

[kudu-CR] KUDU-1945 Add Python example for non-unique PK

2023-05-11 Thread Marton Greber (Code Review)
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19874 to look at the new patch set (#3). Change subject: KUDU-1945 Add Python example for non-unique PK

[kudu-CR] KUDU-3448 Add support for encrypting TSKs

2023-05-11 Thread Attila Bukor (Code Review)
Hello Mahesh Reddy, Marton Greber, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Ádám Bakai, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19617 to look at the new patch set (#8). Change subject: KUDU-3448 Add support for

[kudu-CR] [tests] fix flakiness in TestLogCleanupOnStartup

2023-05-11 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19871 ) Change subject: [tests] fix flakiness in TestLogCleanupOnStartup .. Patch Set 1: I cherry-picked this patch and ran a dist-test job as

[kudu-CR] KUDU-3448 Move password retrieval to master init

2023-05-11 Thread Attila Bukor (Code Review)
Hello Marton Greber, Zoltan Chovan, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19873 to look at the new patch set (#3). Change subject: KUDU-3448 Move password retrieval to master init

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-11 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 ) Change subject: [KUDU-3452] Make validate tablet creating task not affected .. Patch Set 20: (1 comment)

[kudu-CR] KUDU-3452 Allow creating tablets under replicated tables

2023-05-11 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Allow creating tablets under replicated tables .. Patch Set 22: (3 comments)

[kudu-CR] KUDU-1945 Add Python example for non-unique PK

2023-05-11 Thread Marton Greber (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19874 to look at the new patch set (#2). Change subject: KUDU-1945 Add Python example for non-unique PK .. KUDU-1945 Add

[kudu-CR] KUDU-1945 Add Python example for non-unique PK

2023-05-11 Thread Marton Greber (Code Review)
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19874 Change subject: KUDU-1945 Add Python example for non-unique PK .. KUDU-1945 Add Python example for non-unique PK In commit

[kudu-CR](gh-pages) KUDU-1945 Update faq with non-unique PK

2023-05-11 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19860 ) Change subject: KUDU-1945 Update faq with non-unique PK .. Patch Set 3: Verified+1 -- To view, visit

[kudu-CR](gh-pages) KUDU-1945 Update faq with non-unique PK

2023-05-11 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19860 ) Change subject: KUDU-1945 Update faq with non-unique PK .. KUDU-1945 Update faq with non-unique PK Change-Id:

[kudu-CR] KUDU-1945 Update docs with non-unique PK

2023-05-11 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19809 ) Change subject: KUDU-1945 Update docs with non-unique PK .. KUDU-1945 Update docs with non-unique PK Added small update

[kudu-CR] KUDU-3448 Add support for encrypting TSKs

2023-05-11 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19617 ) Change subject: KUDU-3448 Add support for encrypting TSKs .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-3448 Move password retrieval to master init

2023-05-11 Thread Attila Bukor (Code Review)
Hello Marton Greber, Zoltan Chovan, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19873 to look at the new patch set (#2). Change subject: KUDU-3448 Move password retrieval to master init

[kudu-CR] KUDU-3448 Add support for encrypting TSKs

2023-05-11 Thread Attila Bukor (Code Review)
Hello Mahesh Reddy, Marton Greber, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Ádám Bakai, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19617 to look at the new patch set (#7). Change subject: KUDU-3448 Add support for

[kudu-CR] KUDU-3448 Move password retrieval to master init

2023-05-11 Thread Attila Bukor (Code Review)
Hello Marton Greber, Zoltan Chovan, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/19873 to review the following change. Change subject: KUDU-3448 Move password retrieval to master init

[kudu-CR] Change order of operations during InitCatalogManagerTask

2023-05-11 Thread Code Review
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19639 to look at the new patch set (#3). Change subject: Change order of operations during InitCatalogManagerTask ..

[kudu-CR] [tests] fix flakiness in TestLogCleanupOnStartup

2023-05-11 Thread KeDeng (Code Review)
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19871 Change subject: [tests] fix flakiness in TestLogCleanupOnStartup .. [tests] fix flakiness in TestLogCleanupOnStartup I noticed the

[kudu-CR] KUDU-3452 Allow creating tablets under replicated tables

2023-05-11 Thread Wang Xixu (Code Review)
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19571 to look at the new patch set (#22). Change subject: KUDU-3452 Allow creating tablets under replicated tables

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-11 Thread Wang Xixu (Code Review)
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19594 to look at the new patch set (#20). Change subject: [KUDU-3452] Make validate tablet creating task not affected