[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3532: Follow up to replica placement bug .. Patch Set 2: Verified+1 unrelated test failures -- To view, visit

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3532: Follow up to replica placement bug .. KUDU-3532: Follow up to replica placement bug This patch

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3532: Follow up to replica placement bug .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20861 To unsubscribe,

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 62: (16 comments) Thank you for revving the patch!

[kudu-CR](branch-1.17.x) [java] fix NPE in Connection::exceptionCaught()

2024-01-05 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20865 ) Change subject: [java] fix NPE in Connection::exceptionCaught() .. [java] fix NPE in Connection::exceptionCaught() Before

[kudu-CR](branch-1.17.x) [java] fix NPE in Connection::exceptionCaught()

2024-01-05 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20865 ) Change subject: [java] fix NPE in Connection::exceptionCaught() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.17.x) [java] fix NPE in Connection::exceptionCaught()

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [java] fix NPE in Connection::exceptionCaught() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20865 To

[kudu-CR](branch-1.17.x) [java] fix NPE in Connection::exceptionCaught()

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20865 ) Change subject: [java] fix NPE in Connection::exceptionCaught() .. Patch Set 1: Verified+1 unrelated failures in C++ tests (ASAN)

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3532: Follow up to replica placement bug .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3532: Follow up to replica placement bug .. Patch Set 2: (1 comment)

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Mahesh Reddy (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20861 to look at the new patch set (#2). Change subject: KUDU-3532: Follow up to replica placement bug

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: (1 comment)

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: (1 comment) > > Patch Set 7:

[kudu-CR] [compaction/test] Add tests to generate heavy rowset compaction

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20816 ) Change subject: [compaction/test] Add tests to generate heavy rowset compaction .. Patch Set 6: (12 comments)

[kudu-CR] [compaction] Add memory estimation unit test

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 23: (2 comments)

[kudu-CR](branch-1.17.x) [java] fix NPE in Connection::exceptionCaught()

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20865 Change subject: [java] fix NPE in Connection::exceptionCaught() .. [java] fix NPE in Connection::exceptionCaught() Before this patch,

[kudu-CR](branch-1.17.x) KUDU-3252: Follow up to replica placement bug

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3252: Follow up to replica placement bug .. Patch Set 1: (1 comment)

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: > Patch Set 7: Code-Review+1 > > LGTM,

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [compaction/test] Add tests to generate heavy rowset compaction

2024-01-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20816 ) Change subject: [compaction/test] Add tests to generate heavy rowset compaction .. Patch Set 6: (4 comments)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-05 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#66). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-05 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#65). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-05 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#64). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata