[kudu-CR] [compaction] Add memory estimation unit test

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: > Patch Set 73: > > Thank you very much for the

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: (2 comments)

[kudu-CR] [compaction] Add tests to generate high memory rowset compaction

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20816 ) Change subject: [compaction] Add tests to generate high memory rowset compaction .. [compaction] Add tests to generate high

[kudu-CR] [compaction] Add tests to generate high memory rowset compaction

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20816 ) Change subject: [compaction] Add tests to generate high memory rowset compaction .. Patch Set 9: Code-Review+2 (1 comment)

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. KUDU-3527 Fix block manager test

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 15: Verified+1 unrelated test

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: Thank you very much for the contribution! -- To

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/18569 To

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: Verified+1 unrelated test failures: *

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Yuqi Du, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#73). Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 72: Code-Review+2 (4 comments) Please address one nit

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 15: Code-Review+2 (1 comment)

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 15: Code-Review+1 -- To

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 14: (9 comments)

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#15). Change subject: KUDU-3527 Fix block manager test when using 64k

[kudu-CR] [log block manager] Write lock for deletion

2024-01-29 Thread Code Review
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20901 to look at the new patch set (#6). Change subject: [log_block_manager] Write lock for deletion

[kudu-CR] KUDU-3535 Clear log cache while tombstoning a tablet replica.

2024-01-29 Thread Song Jiacheng (Code Review)
Hello Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20822 to look at the new patch set (#10). Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica.

[kudu-CR] KUDU-3535 Clear log cache while tombstoning a replica.

2024-01-29 Thread Song Jiacheng (Code Review)
Hello Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20822 to look at the new patch set (#9). Change subject: KUDU-3535 Clear log cache while tombstoning a replica.

[kudu-CR] [rpc] validate security-related parameters earlier

2024-01-29 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20961 ) Change subject: [rpc] validate security-related parameters earlier .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3535 Clear log cache while tombstoning a replica.

2024-01-29 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20822 ) Change subject: KUDU-3535 Clear log cache while tombstoning a replica. .. Patch Set 8: (2 comments)