[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 10: (1 comment) Thank you for the review, Mike!

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#10). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2804/ -- To view, visit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3868/9/src/kudu/common/partial_row-test.cc

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#9). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#6). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data ..

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2778/ -- To view, visit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2770/ -- To view, visit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3868/3/src/kudu/common/partial_row-test.cc

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2768/ -- To view, visit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 2: (3 comments) Can we add basic test coverage for SetString() and SetBinary()?