[kudu-CR] Expose RPC method info map and various metrics

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9269 ) Change subject: Expose RPC method info map and various metrics .. Expose RPC method info map and various metrics These changes

[kudu-CR] Expose RPC method info map and various metrics

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9269 ) Change subject: Expose RPC method info map and various metrics .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] dist test: shard some long-running tests

2018-02-12 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9285 to review the following change. Change subject: dist_test: shard some long-running tests .. dist_test: shard some

[kudu-CR] [Java] Upgrade Dependencies

2018-02-12 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9284 Change subject: [Java] Upgrade Dependencies .. [Java] Upgrade Dependencies Upgrades the Java dependencies and Gradle versions.

[kudu-CR] Expose RPC method info map and various metrics

2018-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9269 ) Change subject: Expose RPC method info map and various metrics .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] dist test: shard some long-running tests

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9285 ) Change subject: dist_test: shard some long-running tests .. dist_test: shard some long-running tests Change-Id:

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. Patch Set 2: Apparently sanitizer builds

[kudu-CR] dist test: shard some long-running tests

2018-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9285 ) Change subject: dist_test: shard some long-running tests .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tablet] fix nullptr dereference while capturing iterators

2018-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9189 ) Change subject: [tablet] fix nullptr dereference while capturing iterators .. Patch Set 1: > > What test did you see this in? Can we

[kudu-CR] [Java] Upgrade Dependencies

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9284 ) Change subject: [Java] Upgrade Dependencies .. [Java] Upgrade Dependencies Upgrades the Java dependencies and Gradle versions.

[kudu-CR] [Java] Upgrade Dependencies

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9284 ) Change subject: [Java] Upgrade Dependencies .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9284 To

[kudu-CR] KUDU-2291 (part 2): Add a /stacks page

2018-02-12 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9253 to look at the new patch set (#3). Change subject: KUDU-2291 (part 2): Add a /stacks page

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

2018-02-12 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9262 to look at the new patch set (#2). Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-12 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8692 to look at the new patch set (#11). Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 10: (2 comments)

[kudu-CR] docs: Update release management documentation

2018-02-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. Patch Set 3: (2 comments)

[kudu-CR] Add back KuduColumnSchema DataTypeToString

2018-02-12 Thread Grant Henke (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9240 to look at the new patch set (#5). Change subject: Add back KuduColumnSchema DataTypeToString

[kudu-CR] Add back KuduColumnSchema DataTypeToString

2018-02-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9240 ) Change subject: Add back KuduColumnSchema DataTypeToString .. Patch Set 4: (1 comment)

[kudu-CR] [tablet] fix nullptr dereference while capturing iterators

2018-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9189 ) Change subject: [tablet] fix nullptr dereference while capturing iterators .. Patch Set 2: > This looks good to me, if we can show

[kudu-CR] [tablet] fix nullptr dereference while capturing iterators

2018-02-12 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9189 to look at the new patch set (#2). Change subject: [tablet] fix nullptr dereference while capturing iterators

[kudu-CR] [tablet] fix nullptr dereference while capturing iterators

2018-02-12 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9189 to look at the new patch set (#3). Change subject: [tablet] fix nullptr dereference while capturing iterators

[kudu-CR] KUDU-2274. Shut down tombstoned replica when replacing it

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9246 ) Change subject: KUDU-2274. Shut down tombstoned replica when replacing it .. KUDU-2274. Shut down tombstoned replica when

[kudu-CR] cmeta: Use more efficient form of GetConsensusRole()

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9261 ) Change subject: cmeta: Use more efficient form of GetConsensusRole() .. cmeta: Use more efficient form of GetConsensusRole() Now

[kudu-CR] docs: Update release management documentation

2018-02-12 Thread Mike Percy (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8744 to look at the new patch set (#4). Change subject: docs: Update release management documentation ..

[kudu-CR] logging: fix UBSAN unsigned int overflow in LogThrottler

2018-02-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9289 ) Change subject: logging: fix UBSAN unsigned int overflow in LogThrottler .. Patch Set 1: Code-Review+2 looks like a flake -- To view,

[kudu-CR] [tablet] fix nullptr dereference while capturing iterators

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9189 ) Change subject: [tablet] fix nullptr dereference while capturing iterators .. Patch Set 1: Code-Review+1 This looks good to me, if we can

[kudu-CR] [docs] Add scaling guide

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has removed a vote on this change. Change subject: [docs] Add scaling guide .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8842 To unsubscribe, visit

[kudu-CR] [docs] Add scaling guide

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8842 ) Change subject: [docs] Add scaling guide .. Patch Set 4: Verified+1 Code-Review+2 (1 comment) Nice work!

[kudu-CR] logging: fix UBSAN unsigned int overflow in LogThrottler

2018-02-12 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9289 to review the following change. Change subject: logging: fix UBSAN unsigned int overflow in LogThrottler .. logging:

[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9266 ) Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown .. KUDU-2274. RaftConsensus should not access cmeta

[kudu-CR] logging: fix UBSAN unsigned int overflow in LogThrottler

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9289 ) Change subject: logging: fix UBSAN unsigned int overflow in LogThrottler .. Patch Set 1: Verified+1 Indeed, I pinged Mike about it --

[kudu-CR] logging: fix UBSAN unsigned int overflow in LogThrottler

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9289 ) Change subject: logging: fix UBSAN unsigned int overflow in LogThrottler .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] logging: fix UBSAN unsigned int overflow in LogThrottler

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9289 ) Change subject: logging: fix UBSAN unsigned int overflow in LogThrottler .. logging: fix UBSAN unsigned int overflow in

[kudu-CR] docs: improvements to NTP troubleshooting

2018-02-12 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Alex Rodoni, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9234 to look at the new patch set (#2). Change subject: docs: improvements to NTP troubleshooting

[kudu-CR] docs: improvements to NTP troubleshooting

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9234 ) Change subject: docs: improvements to NTP troubleshooting .. Patch Set 2: (3 comments) darn laptop keyboard and its double-letters

[kudu-CR] Add back KuduColumnSchema DataTypeToString

2018-02-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9240 ) Change subject: Add back KuduColumnSchema DataTypeToString .. Patch Set 4: (1 comment)

[kudu-CR] docs: Update release management documentation

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. Patch Set 3: (2 comments)

[kudu-CR] docs: improvements to NTP troubleshooting

2018-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9234 ) Change subject: docs: improvements to NTP troubleshooting .. docs: improvements to NTP troubleshooting Change-Id:

[kudu-CR] docs: Update release management documentation

2018-02-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. Patch Set 3: (1 comment)

[kudu-CR] docs: Update release management documentation

2018-02-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. Patch Set 4: Verified+1 Code-Review+2 looks like a flake -- To view,

[kudu-CR] docs: Update release management documentation

2018-02-12 Thread Dan Burkert (Code Review)
Dan Burkert has removed a vote on this change. Change subject: docs: Update release management documentation .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8744 To unsubscribe,

[kudu-CR] docs: Update release management documentation

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. Patch Set 4: Thanks for reviewing! -- To view, visit

[kudu-CR] internal mini cluster: support Cluster/LogVerifier

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9137 ) Change subject: internal_mini_cluster: support Cluster/LogVerifier .. Patch Set 11: Code-Review+1 (5 comments) Looks good! Thanks for

[kudu-CR] docs: Update release management documentation

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. docs: Update release management documentation Change-Id:

[kudu-CR] [docs] Document how to recover from a majority failed tablet

2018-02-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8402 ) Change subject: [docs] Document how to recover from a majority failed tablet .. Patch Set 8: Code-Review+1 (1 comment) lgtm, only a nit