[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15947 ) Change subject: [client] Remove allocator param for direct Bloom filter predicate .. Patch Set 3: (1 comment)

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15947 ) Change subject: [client] Remove allocator param for direct Bloom filter predicate .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Revert "KUDU-2817: Upgrade glog to 0.4.0"

2020-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has created a revert of this change. ( http://gerrit.cloudera.org:8080/15975 ) Change subject: Revert "KUDU-2817: Upgrade glog to 0.4.0" .. Uploaded patch set 1. -- To view, visit

[kudu-CR] Revert "KUDU-2817: Upgrade glog to 0.4.0"

2020-05-21 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15975 to review the following change. Change subject: Revert "KUDU-2817: Upgrade glog to 0.4.0"

[kudu-CR] docs: add a blurb about RF=1 tables when doing a rolling restart

2020-05-21 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15976 to review the following change. Change subject: docs: add a blurb about RF=1 tables when doing a rolling restart ..

[kudu-CR] docs: add a blurb about RF=1 tables when doing a rolling restart

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15976 ) Change subject: docs: add a blurb about RF=1 tables when doing a rolling restart .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Revert "KUDU-2817: Upgrade glog to 0.4.0"

2020-05-21 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15975 to look at the new patch set (#2). Change subject: Revert "KUDU-2817: Upgrade glog to 0.4.0"

[kudu-CR] Revert "KUDU-2817: Upgrade glog to 0.4.0"

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15975 ) Change subject: Revert "KUDU-2817: Upgrade glog to 0.4.0" .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [catalog] remove CatalogManager::CheckOnline()

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15977 Change subject: [catalog] remove CatalogManager::CheckOnline() .. [catalog] remove CatalogManager::CheckOnline() The implementation of

[kudu-CR] release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15968 ) Change subject: release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1 .. release notes: add prior notes for 1.10.1,

[kudu-CR] [docs] item about updating prior release notes.adoc

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/15974 ) Change subject: [docs] item about updating prior_release_notes.adoc .. Abandoned whoops; this is already addressed in

[kudu-CR] release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15968 ) Change subject: release notes: add prior notes for 1.10.1, 1.11.0 and 1.11.1 .. Patch Set 1: Code-Review+2 Thank you for adding

[kudu-CR] [docs] add a release step to update the previous release notes

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15969 ) Change subject: [docs] add a release step to update the previous release notes .. [docs] add a release step to update the

[kudu-CR] [docs] add a release step to update the previous release notes

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15969 ) Change subject: [docs] add a release step to update the previous release notes .. Patch Set 1: Code-Review+2 It's a useful reminder,

[kudu-CR] [docs] item about updating prior release notes.adoc

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15974 Change subject: [docs] item about updating prior_release_notes.adoc .. [docs] item about updating prior_release_notes.adoc Added an

[kudu-CR] WIP [master] cache for table locations

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15971 ) Change subject: WIP [master] cache for table locations .. Patch Set 1: (1 comment)

[kudu-CR] [fs] limit memory could consume compacting low live ratio blocks during startup

2020-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15830 ) Change subject: [fs] limit memory could consume compacting low live ratio blocks during startup .. Patch Set 6: (2 comments)

[kudu-CR] Revert "KUDU-2817: Upgrade glog to 0.4.0"

2020-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: Revert "KUDU-2817: Upgrade glog to 0.4.0" .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15975 To unsubscribe, visit

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15947 ) Change subject: [client] Remove allocator param for direct Bloom filter predicate .. [client] Remove allocator param for

[kudu-CR] Revert "KUDU-2817: Upgrade glog to 0.4.0"

2020-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15975 ) Change subject: Revert "KUDU-2817: Upgrade glog to 0.4.0" .. Revert "KUDU-2817: Upgrade glog to 0.4.0" This reverts commit

[kudu-CR] Revert "KUDU-2817: Upgrade glog to 0.4.0"

2020-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15975 ) Change subject: Revert "KUDU-2817: Upgrade glog to 0.4.0" .. Patch Set 2: Verified+1 ToolTest.TestHmsList timed out. Filed KUDU-3129

[kudu-CR] docs: add a blurb about RF=1 tables when doing a rolling restart

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15976 ) Change subject: docs: add a blurb about RF=1 tables when doing a rolling restart .. docs: add a blurb about RF=1 tables when

[kudu-CR] [catalog] remove CatalogManager::CheckOnline()

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15977 ) Change subject: [catalog] remove CatalogManager::CheckOnline() .. Patch Set 1: Verified+1 Test failure due to known issue:

[kudu-CR] [catalog] remove CatalogManager::CheckOnline()

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15977 ) Change subject: [catalog] remove CatalogManager::CheckOnline() .. [catalog] remove CatalogManager::CheckOnline() The

[kudu-CR] [catalog] remove CatalogManager::CheckOnline()

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [catalog] remove CatalogManager::CheckOnline() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15977 To unsubscribe,

[kudu-CR] [catalog] remove CatalogManager::CheckOnline()

2020-05-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15977 ) Change subject: [catalog] remove CatalogManager::CheckOnline() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-05-21 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15939 to look at the new patch set (#2). Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4 .. KUDU-2817:

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-21 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15947 ) Change subject: [client] Remove allocator param for direct Bloom filter predicate .. Patch Set 2: (1 comment)

[kudu-CR] [client] Remove allocator param for direct Bloom filter predicate

2020-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15947 ) Change subject: [client] Remove allocator param for direct Bloom filter predicate .. Patch Set 2: (1 comment) overall looks good, I

[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-05-21 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15939 to look at the new patch set (#4). Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4 .. KUDU-2817:

[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-05-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15939 ) Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4 .. Patch Set 2: (8 comments)

[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-05-21 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15939 to look at the new patch set (#3). Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4 .. KUDU-2817: