[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2023-12-19 Thread Ashwani Raina (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20720 to look at the new patch set (#7). Change subject: [compaction/flush] Cleanup of compaction and flush code paths

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-19 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 5: (1 comment)

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-19 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 1: (2 comments) Overall looks good to me. Just one small

[kudu-CR] [logging] simplify and improve LogThrottler

2023-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20820 Change subject: [logging] simplify and improve LogThrottler .. [logging] simplify and improve LogThrottler I've noticed that among all

[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20821 ) Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics .. Patch Set 1: Verified+1 unrelated test failure in

[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20821 To

[kudu-CR] [Tool] Find file path where the block is located

2023-12-19 Thread Wang Xixu (Code Review)
Hello Ashwani Raina, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20594 to look at the new patch set (#5). Change subject: [Tool] Find file path where the block is located

[kudu-CR] [logging] simplify and improve LogThrottler

2023-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20820 ) Change subject: [logging] simplify and improve LogThrottler .. Patch Set 1: Verified+1 unrelated test failures: *

[kudu-CR] [logging] simplify and improve LogThrottler

2023-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [logging] simplify and improve LogThrottler .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20820 To unsubscribe,

[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20821 Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics .. [tests] fix flakiness in TestSpaceAvailableMetrics I saw

[kudu-CR] [Tool] Find file path where the block is located

2023-12-19 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20594 ) Change subject: [Tool] Find file path where the block is located .. Patch Set 5: (22 comments)

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2023-12-19 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#13). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-19 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Alexey Serbin, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20716 to look at the new patch set (#14). Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description.

[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20821 ) Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20821 ) Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics .. [tests] fix flakiness in TestSpaceAvailableMetrics

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2023-12-19 Thread Song Jiacheng (Code Review)
Hello Marton Greber, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20715 to look at the new patch set (#14). Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client.

[kudu-CR] KUDU-3535 Should clear log cache while tombstoning a replica.

2023-12-19 Thread Song Jiacheng (Code Review)
Song Jiacheng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20822 Change subject: KUDU-3535 Should clear log cache while tombstoning a replica. .. KUDU-3535 Should clear log cache while tombstoning a

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-19 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 1: (3 comments)

[kudu-CR] [WIP] [compaction/test] Add tests to generate heavy rowset compaction

2023-12-19 Thread Ashwani Raina (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20816 to look at the new patch set (#2). Change subject: [WIP] [compaction/test] Add tests to generate heavy rowset compaction

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2023-12-19 Thread Code Review
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-3486 Periodically send tombstoned replica report to delete it.

2023-12-19 Thread Yifan Zhang (Code Review)
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20600 ) Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. .. KUDU-3486 Periodically send tombstoned

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2023-12-19 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: Code-Review+1 (1 comment)

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-19 Thread Ashwani Raina (Code Review)
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 5: Btw, I have a patch going out for review, shortly, that

[kudu-CR] [WIP] [compaction/test] Add tests to generate heavy rowset compaction

2023-12-19 Thread Ashwani Raina (Code Review)
Ashwani Raina has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20816 Change subject: [WIP] [compaction/test] Add tests to generate heavy rowset compaction .. [WIP] [compaction/test] Add tests to generate

[kudu-CR] [compaction] Add memory estimation unit test

2023-12-19 Thread Code Review
Hello Alexey Serbin, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20787 to look at the new patch set (#6). Change subject: [compaction] Add memory estimation unit test