[kudu-CR] [java-client] repackage to org.apache.kudu (Part 2)

2016-07-24 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3737

to review the following change.

Change subject: [java-client] repackage to org.apache.kudu (Part 2)
..

[java-client] repackage to org.apache.kudu (Part 2)

Find/replace org.kududb with org.apache.kudu.

Change-Id: If806b89fb35b56ecce3fc1034c5304f39e2c0867
---
M java/interface-annotations/pom.xml
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M java/kudu-client-tools/pom.xml
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/pom.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeadlineTracker.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/HasFailedRpcException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Insert.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneResponse.java
M 

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 1)

2016-07-24 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3736

to review the following change.

Change subject: [java-client] repackage to org.apache.kudu (Part 1)
..

[java-client] repackage to org.apache.kudu (Part 1)

Move all org.kududb directories to org.apache.kudu

Change-Id: I0b2956974a5869c597b9620d9ee403afa7fed8aa
---
R 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
R 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
R 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
R 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
R 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
R 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
R 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
R 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
R 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
R 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
R 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
R 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
R 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
R 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
R 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
R 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
R java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
R java/kudu-client/src/main/java/org/apache/kudu/Schema.java
R java/kudu-client/src/main/java/org/apache/kudu/Type.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
R java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
R java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
R java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java
R java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
R java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
R java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
R java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
R java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
R java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
R java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
R java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
R java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
R java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
R java/kudu-client/src/main/java/org/apache/kudu/client/DeadlineTracker.java
R java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
R java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
R java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableResponse.java
R java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationRequest.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationResponse.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/HasFailedRpcException.java
R java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java
R java/kudu-client/src/main/java/org/apache/kudu/client/Insert.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneResponse.java
R 
java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java
R java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
R 

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)

2016-07-24 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3738

to review the following change.

Change subject: [java-client] repackage to org.apache.kudu (Part 3)
..

[java-client] repackage to org.apache.kudu (Part 3)

Reorganize imports. I tried to fix up the places where the repackage changed
sorting by hand, but it got to be really tedious.  Instead, I used IntelliJ's
Optimize Imports feature along with an import style which seems to cause the
least churn.  The style is:

import com.*

import org.*

import java.*
import javax.*

import all other imports

import static all other imports

Additionally, wildcard imports were disabled except for org.junit.Assert.*.

Change-Id: I4b6d19946e712e1e424ff28bd7b56d5419fd0982
---
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
M 
java/interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsvMapper.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/BatchResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Delete.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeleteTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTablesRequest.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ListTabletServersRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTabletsRequest.java
M 

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 1)

2016-07-24 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: [java-client] repackage to org.apache.kudu (Part 1)
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2654/

-- 
To view, visit http://gerrit.cloudera.org:8080/3736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b2956974a5869c597b9620d9ee403afa7fed8aa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)

2016-07-24 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: [java-client] repackage to org.apache.kudu (Part 3)
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2655/

-- 
To view, visit http://gerrit.cloudera.org:8080/3738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6d19946e712e1e424ff28bd7b56d5419fd0982
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] WIP [java client] Support add/remove partition

2016-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change.

Change subject: WIP [java client] Support add/remove partition
..


Patch Set 2:

Just put up https://gerrit.cloudera.org/#/c/3735/.  It's meant to be rebased 
into this one.  Definitely still needs more tests, but the existing tests are 
passing.

-- 
To view, visit http://gerrit.cloudera.org:8080/3731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR] WIP: add to JD's WIP add/drop range partition work for java client

2016-07-24 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: WIP: add to JD's WIP add/drop range partition work for java 
client
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2653/

-- 
To view, visit http://gerrit.cloudera.org:8080/3735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0e7763c03a13e4fb80417dc897f0e28c1d40e70
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR] WIP [java client] Support add/remove partition

2016-07-24 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: WIP [java client] Support add/remove partition
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2651/

-- 
To view, visit http://gerrit.cloudera.org:8080/3731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3733

to look at the new patch set (#3).

Change subject: Fix block_manager-test running in some builds
..

Fix block_manager-test running in some builds

Even though the patch for KUDU-1538 passed pre-commit, it failed in the RELEASE
builds post-commit.

The issue appears to be that my trickery with weak symbols only worked in
some cases, depending on the link order, for dynamically linked builds,
since weak symbols are actually only relevant for statically linked ones.
Apparently in the precommit build, the link order was such that the gtest
detection did not work on block_manager-test, and thus things were fine.
But, in the release static build post-commit, the gtest detection worked,
and it broke the test in question.

This patch changes the gtest detection to use dlsym() instead of a weak symbol.
It appears to work more reliably in all types of builds. This also fixes the
test to properly manipulate the block ID sequence in the test that was failing.

Change-Id: I1a4025a3d859b139b74be997706bd27d0ba7b292
---
M CMakeLists.txt
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/test_util.cc
A src/kudu/util/test_util_prod.cc
A src/kudu/util/test_util_prod.h
7 files changed, 83 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/3733/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a4025a3d859b139b74be997706bd27d0ba7b292
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: Fix block_manager-test running in some builds
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2649/

-- 
To view, visit http://gerrit.cloudera.org:8080/3733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4025a3d859b139b74be997706bd27d0ba7b292
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR] ksck-test: fix failure on OSX

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3734

to review the following change.

Change subject: ksck-test: fix failure on OSX
..

ksck-test: fix failure on OSX

We previously relied on deleting the 'first' element of an unordered_map to set
up a test case. This is platform-dependent and gave a different output on OSX.
Fixed it to delete an explicit entry.

Change-Id: I4361ff48faf0ffcea86f320433514763f3b77266
---
M src/kudu/tools/ksck-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/3734/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4361ff48faf0ffcea86f320433514763f3b77266
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 


[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3733

to look at the new patch set (#2).

Change subject: Fix block_manager-test running in some builds
..

Fix block_manager-test running in some builds

Even though the patch for KUDU-1538 passed pre-commit, it failed in the RELEASE
builds post-commit.

The issue appears to be that my trickery with weak symbols only worked in
some cases, depending on the link order, for dynamically linked builds,
since weak symbols are actually only relevant for statically linked ones.
Apparently in the precommit build, the link order was such that the gtest
detection did not work on block_manager-test, and thus things were fine.
But, in the release static build post-commit, the gtest detection worked,
and it broke the test in question.

This patch changes the gtest detection to use dlsym() instead of a weak symbol.
It appears to work more reliably in all types of builds. This also fixes the
test to properly manipulate the block ID sequence in the test that was failing.

Change-Id: I1a4025a3d859b139b74be997706bd27d0ba7b292
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/test_util.cc
A src/kudu/util/test_util_prod.cc
A src/kudu/util/test_util_prod.h
6 files changed, 76 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/3733/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a4025a3d859b139b74be997706bd27d0ba7b292
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3733

to review the following change.

Change subject: Fix block_manager-test running in some builds
..

Fix block_manager-test running in some builds

Even though the patch for KUDU-1538 passed pre-commit, it failed in the RELEASE
builds post-commit.

The issue appears to be that my trickery with weak symbols only worked in
some cases, depending on the link order, for dynamically linked builds,
since weak symbols are actually only relevant for statically linked ones.
Apparently in the precommit build, the link order was such that the gtest
detection did not work on block_manager-test, and thus things were fine.
But, in the release static build post-commit, the gtest detection worked,
and it broke the test in question.

This patch changes the gtest detection to use dlsym() instead of a weak symbol.
It appears to work more reliably in all types of builds. This also fixes the
test to properly manipulate the block ID sequence in the test that was failing.

Change-Id: I1a4025a3d859b139b74be997706bd27d0ba7b292
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/test_util.cc
A src/kudu/util/test_util_prod.cc
A src/kudu/util/test_util_prod.h
6 files changed, 75 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/3733/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a4025a3d859b139b74be997706bd27d0ba7b292
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 


[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: Fix block_manager-test running in some builds
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2646/

-- 
To view, visit http://gerrit.cloudera.org:8080/3733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4025a3d859b139b74be997706bd27d0ba7b292
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No