[kudu-CR] Fix ksck-test reliance on unordered map iteration order
Kudu Jenkins has posted comments on this change. Change subject: Fix ksck-test reliance on unordered map iteration order .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2700/ -- To view, visit http://gerrit.cloudera.org:8080/3831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9fea40bd8f6c82d1a9147d95c18c8001713a21c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Fix ksck-test reliance on unordered map iteration order
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3831 Change subject: Fix ksck-test reliance on unordered map iteration order .. Fix ksck-test reliance on unordered map iteration order TestMismatchedAssignments was relying on a specific key to come first in an unordered map iterator. This caused the test to fail on OS X. This alters the test so it doesn't matter which key comes back first. Change-Id: If9fea40bd8f6c82d1a9147d95c18c8001713a21c --- M src/kudu/tools/ksck-test.cc 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3831/1 -- To view, visit http://gerrit.cloudera.org:8080/3831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If9fea40bd8f6c82d1a9147d95c18c8001713a21c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley
[kudu-CR] Make UTF-8 characters display correctly in the web ui
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3830 Change subject: Make UTF-8 characters display correctly in the web ui .. Make UTF-8 characters display correctly in the web ui Some valid UTF-8 characters don't display correctly on the web ui, like F09F8CAE (taco emoji). This adds the proper meta element to the so they display correctly. Change-Id: I872c84a93d22f1cabce4534eccc917df99079414 --- M src/kudu/server/webserver.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/3830/1 -- To view, visit http://gerrit.cloudera.org:8080/3830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I872c84a93d22f1cabce4534eccc917df99079414 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley
[kudu-CR] Make UTF-8 characters display correctly in the web ui
Kudu Jenkins has posted comments on this change. Change subject: Make UTF-8 characters display correctly in the web ui .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2699/ -- To view, visit http://gerrit.cloudera.org:8080/3830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I872c84a93d22f1cabce4534eccc917df99079414 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] alter table-randomized-test: increase write timeout
Adar Dembo has submitted this change and it was merged. Change subject: alter_table-randomized-test: increase write timeout .. alter_table-randomized-test: increase write timeout The timeout was being hit when election cycles were repeated due to overlapping timeouts. Change-Id: I610bf4b0167f37b8b5d364c8d8fe2331615ebebf Reviewed-on: http://gerrit.cloudera.org:8080/3829 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/integration-tests/alter_table-randomized-test.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I610bf4b0167f37b8b5d364c8d8fe2331615ebebf Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] alter table-randomized-test: increase write timeout
Adar Dembo has posted comments on this change. Change subject: alter_table-randomized-test: increase write timeout .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I610bf4b0167f37b8b5d364c8d8fe2331615ebebf Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1416 Upsert support for Flume sink
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1416 Upsert support for Flume sink .. KUDU-1416 Upsert support for Flume sink This patch adds a new SimpleKeyedKuduEventProducer class that can upsert. The original KuduEventProducer class, SimpleKuduEventProducer, assumed it was inserting a binary payload to a key column, and thus was not compatible with upserts. SimpleKeyedKuduEventProducer supports inserting or upserting a binary payload with string key column. Change-Id: Ibe5b5df70687103ed6916d58148336882aa66d85 Reviewed-on: http://gerrit.cloudera.org:8080/3157 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java A java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduEventProducer.java M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKuduEventProducer.java A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduEventProducerTest.java 4 files changed, 315 insertions(+), 3 deletions(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe5b5df70687103ed6916d58148336882aa66d85 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Ara Ebrahimi Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-1416 Upsert support for Flume sink
Mike Percy has posted comments on this change. Change subject: KUDU-1416 Upsert support for Flume sink .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5b5df70687103ed6916d58148336882aa66d85 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Ara Ebrahimi Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] KUDU-1416 Upsert support for Flume sink
Will Berkeley has posted comments on this change. Change subject: KUDU-1416 Upsert support for Flume sink .. Patch Set 3: > (1 comment) > > Looks good to me. I'm going to just rebase this myself and push it > unless I run into any unexpected issues. I agree: a lot more good stuff can be done. Hopefully this is a good start. Thanks for finishing it. -- To view, visit http://gerrit.cloudera.org:8080/3157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5b5df70687103ed6916d58148336882aa66d85 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Ara Ebrahimi Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] alter table-randomized-test: increase write timeout
Kudu Jenkins has posted comments on this change. Change subject: alter_table-randomized-test: increase write timeout .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2698/ -- To view, visit http://gerrit.cloudera.org:8080/3829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I610bf4b0167f37b8b5d364c8d8fe2331615ebebf Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] alter table-randomized-test: increase write timeout
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3829 to review the following change. Change subject: alter_table-randomized-test: increase write timeout .. alter_table-randomized-test: increase write timeout The timeout was being hit when election cycles were repeated due to overlapping timeouts. Change-Id: I610bf4b0167f37b8b5d364c8d8fe2331615ebebf --- M src/kudu/integration-tests/alter_table-randomized-test.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/3829/1 -- To view, visit http://gerrit.cloudera.org:8080/3829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I610bf4b0167f37b8b5d364c8d8fe2331615ebebf Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Todd Lipcon
[kudu-CR] make election timeout jitter more aggressive
Kudu Jenkins has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2697/ -- To view, visit http://gerrit.cloudera.org:8080/3828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c9dad820c2b7d4bc4b9e791b78222559cdf63c8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] make election timeout jitter more aggressive
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3828 to review the following change. Change subject: make election timeout jitter more aggressive .. make election timeout jitter more aggressive Existing election timeouts have very low variance, and is capped at a maximum value. Having a variance cap is problematic because it could cause Raft to not make progress when the RTT between nodes is greater than the cap. Counter-intuitively, having a low variance in timeouts causes elections to take longer since it leads to more frequent election retries. This commit removes the cap and increases the variance. Change-Id: I2c9dad820c2b7d4bc4b9e791b78222559cdf63c8 --- M src/kudu/consensus/raft_consensus.cc 1 file changed, 2 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/3828/1 -- To view, visit http://gerrit.cloudera.org:8080/3828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2c9dad820c2b7d4bc4b9e791b78222559cdf63c8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1416 Upsert support for Flume sink
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1416 Upsert support for Flume sink .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2696/ -- To view, visit http://gerrit.cloudera.org:8080/3157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5b5df70687103ed6916d58148336882aa66d85 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Ara Ebrahimi Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] KUDU-1416 Upsert support for Flume sink
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3157 to look at the new patch set (#3). Change subject: KUDU-1416 Upsert support for Flume sink .. KUDU-1416 Upsert support for Flume sink This patch adds a new SimpleKeyedKuduEventProducer class that can upsert. The original KuduEventProducer class, SimpleKuduEventProducer, assumed it was inserting a binary payload to a key column, and thus was not compatible with upserts. SimpleKeyedKuduEventProducer supports inserting or upserting a binary payload with string key column. Change-Id: Ibe5b5df70687103ed6916d58148336882aa66d85 --- M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java A java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduEventProducer.java M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKuduEventProducer.java A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduEventProducerTest.java 4 files changed, 315 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/3157/3 -- To view, visit http://gerrit.cloudera.org:8080/3157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibe5b5df70687103ed6916d58148336882aa66d85 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Ara Ebrahimi Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-1416 Upsert support for Flume sink
Mike Percy has posted comments on this change. Change subject: KUDU-1416 Upsert support for Flume sink .. Patch Set 2: Code-Review+2 (1 comment) Looks good to me. I'm going to just rebase this myself and push it unless I run into any unexpected issues. http://gerrit.cloudera.org:8080/#/c/3157/1//COMMIT_MSG Commit Message: Line 15: Change-Id: Ibe5b5df70687103ed6916d58148336882aa66d85 There is a lot that we could do to make this even better, but I think having this example is a good start. One thing we could do in a future patch is to make a very generic event producer that would read avro encoded events and automatically map those to a configured table, i.e. a "zero coding" path. -- To view, visit http://gerrit.cloudera.org:8080/3157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5b5df70687103ed6916d58148336882aa66d85 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Ara Ebrahimi Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: Yes
[kudu-CR] push to asf.py: update repo URL
Adar Dembo has submitted this change and it was merged. Change subject: push_to_asf.py: update repo URL .. push_to_asf.py: update repo URL Change-Id: Ibabca8039d4c749c05ab789959e04aab69d15223 Reviewed-on: http://gerrit.cloudera.org:8080/3826 Reviewed-by: Todd Lipcon Tested-by: Adar Dembo --- M build-support/push_to_asf.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adar Dembo: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibabca8039d4c749c05ab789959e04aab69d15223 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] push to asf.py: update repo URL
Adar Dembo has posted comments on this change. Change subject: push_to_asf.py: update repo URL .. Patch Set 1: Verified+1 Failure in AlterTableRandomizedTest, definitely unrelated to this patch. -- To view, visit http://gerrit.cloudera.org:8080/3826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibabca8039d4c749c05ab789959e04aab69d15223 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) site tool: update repository URLs
Mike Percy has posted comments on this change. Change subject: site_tool: update repository URLs .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5535e922ecf4f71b712b6d0dc1ce2d40d109870f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) site tool: update repository URLs
Mike Percy has submitted this change and it was merged. Change subject: site_tool: update repository URLs .. site_tool: update repository URLs Change-Id: I5535e922ecf4f71b712b6d0dc1ce2d40d109870f Reviewed-on: http://gerrit.cloudera.org:8080/3827 Reviewed-by: Mike Percy Tested-by: Mike Percy --- M site_tool 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Mike Percy: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/3827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5535e922ecf4f71b712b6d0dc1ce2d40d109870f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Adar Dembo has submitted this change and it was merged. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. [doxygen] made DESTDIR applicable for ninja builds Moved the DESTDIR parameter into the environment to make the 'doxygen' target buildable under ninja as well. Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Reviewed-on: http://gerrit.cloudera.org:8080/3825 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] push to asf.py: update repo URL
Adar Dembo has posted comments on this change. Change subject: push_to_asf.py: update repo URL .. Patch Set 1: > Guess we should send an email to dev@ so everyone can change their > own apache remotes, too? Sounds like a job befitting the Vice President! > Do we need to change the site_tool thing in the gh-pages branch > too? Sure, I put together a separate patch for site_tool. -- To view, visit http://gerrit.cloudera.org:8080/3826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibabca8039d4c749c05ab789959e04aab69d15223 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) site tool: update repository URLs
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3827 to review the following change. Change subject: site_tool: update repository URLs .. site_tool: update repository URLs Change-Id: I5535e922ecf4f71b712b6d0dc1ce2d40d109870f --- M site_tool 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/3827/1 -- To view, visit http://gerrit.cloudera.org:8080/3827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5535e922ecf4f71b712b6d0dc1ce2d40d109870f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Alexey Serbin has posted comments on this change. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. Patch Set 1: > Looks good provided you've tested it with both make and ninja. Yes, I tested it with GNU make 3.81 and ninja 1.6.0 under MacOS X and it worked for me. -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] push to asf.py: update repo URL
Todd Lipcon has posted comments on this change. Change subject: push_to_asf.py: update repo URL .. Patch Set 1: Code-Review+2 Guess we should send an email to dev@ so everyone can change their own apache remotes, too? Do we need to change the site_tool thing in the gh-pages branch too? -- To view, visit http://gerrit.cloudera.org:8080/3826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibabca8039d4c749c05ab789959e04aab69d15223 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] push to asf.py: update repo URL
Kudu Jenkins has posted comments on this change. Change subject: push_to_asf.py: update repo URL .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2695/ -- To view, visit http://gerrit.cloudera.org:8080/3826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibabca8039d4c749c05ab789959e04aab69d15223 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] push to asf.py: update repo URL
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3826 to review the following change. Change subject: push_to_asf.py: update repo URL .. push_to_asf.py: update repo URL Change-Id: Ibabca8039d4c749c05ab789959e04aab69d15223 --- M build-support/push_to_asf.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/3826/1 -- To view, visit http://gerrit.cloudera.org:8080/3826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibabca8039d4c749c05ab789959e04aab69d15223 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] build-and-test: also clean up old failsafe reports
Adar Dembo has submitted this change and it was merged. Change subject: build-and-test: also clean up old failsafe reports .. build-and-test: also clean up old failsafe reports With failsafe is running some Java tests, test output is showing up in java/*/target/failsafe-reports. We weren't explicitly deleting this directory so failures may sneak into subsequent LINT runs. Change-Id: Ib3a5e0f55bab3bfb10bcc9cfdd19dbf330936027 Reviewed-on: http://gerrit.cloudera.org:8080/3812 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans --- M build-support/jenkins/build-and-test.sh 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3a5e0f55bab3bfb10bcc9cfdd19dbf330936027 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Adar Dembo has posted comments on this change. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. Patch Set 1: Code-Review+2 Looks good provided you've tested it with both make and ninja. -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Kudu Jenkins has posted comments on this change. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2694/ -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3825 Change subject: [doxygen] made DESTDIR applicable for ninja builds .. [doxygen] made DESTDIR applicable for ninja builds Moved the DESTDIR parameter into the environment to make the 'doxygen' target buildable under ninja as well. Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba --- M CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/3825/1 -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin
[kudu-CR] master: do not delete unknown tablets
Todd Lipcon has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. KUDU-1374: send full tablet report when new leader master is detected This should help prevent missed tablet reports in very specific edge cases, detailed in the bug report. The new integration test fails 100% of the time without the change, and passes 100% of the time with it. Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Reviewed-on: http://gerrit.cloudera.org:8080/3643 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/tserver/heartbeater.cc 3 files changed, 97 insertions(+), 7 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected
Todd Lipcon has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: do not delete unknown tablets
Todd Lipcon has submitted this change and it was merged. Change subject: master: do not delete unknown tablets .. master: do not delete unknown tablets Quoting from docs/design-docs/multi-master-1.0.md: "The master and/or tserver must enforce that all actions take effect iff they were sent by the master that is currently the leader. After an exhaustive audit of all master state changes (see appendix A), it was determined that the current protection mechanisms built into each RPC are sufficient to provide fencing. The one exception is orphaned replica deletion done in response to a heartbeat. To protect against that, true orphans (i.e. tablets for which no persistent record exists) will not be deleted at all. As the master retains deleted table/tablet metadata in perpetuity, this should ensure that true orphans appear only under drastic circumstances, such as a tserver that heartbeats to the wrong cluster." The new test isn't ideal in that it must wait some time to allow the tserver to receive an RPC from the master, but on my laptop it does fail without the fix, and it should fail fairly often in other machines/environments too. Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Reviewed-on: http://gerrit.cloudera.org:8080/3645 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/delete_table-test.cc M src/kudu/master/catalog_manager.cc 3 files changed, 78 insertions(+), 17 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1358 (part 3): new multi-master stress test
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1358 (part 3): new multi-master stress test .. KUDU-1358 (part 3): new multi-master stress test This commit adds a stress test for multiple masters. The idea is simple: issue DDL operations at a high rate while periodically restarting a master. There's a balance to be struck both in the throughput of the operations and in the periodicity of the restarts; we need to ensure that the masters can make enough forward progress (in spite of the failures) to process all of the requests without timing out. To assist, the client uses abnormally long timeouts on all operations. Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Reviewed-on: http://gerrit.cloudera.org:8080/3611 Tested-by: Adar Dembo Reviewed-by: Todd Lipcon Reviewed-by: Dan Burkert --- M src/kudu/integration-tests/CMakeLists.txt A src/kudu/integration-tests/master-stress-test.cc 2 files changed, 421 insertions(+), 15 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Adar Dembo: Verified Todd Lipcon: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] repackage to org.apache.kudu (Part 3) .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2693/ -- To view, visit http://gerrit.cloudera.org:8080/3738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b6d19946e712e1e424ff28bd7b56d5419fd0982 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 3): new multi-master stress test
Dan Burkert has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] repackage to org.apache.kudu (Part 3) .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2692/ -- To view, visit http://gerrit.cloudera.org:8080/3738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b6d19946e712e1e424ff28bd7b56d5419fd0982 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. KUDU-1311 [master] support adding and dropping range partitions Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Reviewed-on: http://gerrit.cloudera.org:8080/3648 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/table_alterer-internal.cc M src/kudu/client/table_alterer-internal.h M src/kudu/common/partition.cc M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc 20 files changed, 1,213 insertions(+), 211 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
