[kudu-CR] [client] performance optimizations

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 2: (1 comment) Thank you for the review! Will address the rest of the comments after addressing the tests

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4395 To unsubscribe, visit

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4395 to look at the new patch set (#3). Change subject: [client] avoid circular deps in time-based flusher .. [client]

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3402/ -- To view, visit

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4395/2/src/kudu/client/session-internal.cc

[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. Patch Set 2: (2 comments) Thank you for the review! I posted the updated version.

[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3401/ -- To view, visit

[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4308 to look at the new patch set (#3). Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. [c++

[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1301 - [python] Tests leak tmp directory .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4372 To unsubscribe, visit

[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1301 - [python] Tests leak tmp directory .. KUDU-1301 - [python] Tests leak tmp directory In the past the python tests have been leaking tmp

[kudu-CR](branch-1.0.x) Change version to non-SNAPSHOT in branch

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Change version to non-SNAPSHOT in branch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4399 To unsubscribe, visit

[kudu-CR] Bump version to 1.1.0-SNAPSHOT

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Bump version to 1.1.0-SNAPSHOT .. Bump version to 1.1.0-SNAPSHOT Change-Id: Ifd9db10a73fecbb73cebe66c16d16e9d11a98750 Reviewed-on:

[kudu-CR](branch-1.0.x) Revert "java: fix leak of TabletClient objects in client2tablets map"

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Revert "java: fix leak of TabletClient objects in client2tablets map" .. Revert "java: fix leak of TabletClient objects in client2tablets map" This

[kudu-CR](branch-1.0.x) Change version to non-SNAPSHOT in branch

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Change version to non-SNAPSHOT in branch .. Change version to non-SNAPSHOT in branch Change-Id: Ibc73006692673591a78c1bf3a101058ad62fc014 Reviewed-on:

[kudu-CR](branch-1.0.x) Revert "java: fix leak of TabletClient objects in client2tablets map"

2016-09-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Revert "java: fix leak of TabletClient objects in client2tablets map" .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] debug-util-test: address flakiness

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: debug-util-test: address flakiness .. debug-util-test: address flakiness In TSAN builds, this test seems to fail sometimes due to not starting the

[kudu-CR] debug-util-test: address flakiness

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: debug-util-test: address flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4346 To unsubscribe, visit

[kudu-CR] Bump version to 1.1.0-SNAPSHOT

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Bump version to 1.1.0-SNAPSHOT .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3399/ -- To view, visit http://gerrit.cloudera.org:8080/4400

[kudu-CR](branch-1.0.x) Revert "java: fix leak of TabletClient objects in client2tablets map"

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Revert "java: fix leak of TabletClient objects in client2tablets map" .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3397/ -- To view,

[kudu-CR](branch-1.0.x) Change version to non-SNAPSHOT in branch

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4399 Change subject: Change version to non-SNAPSHOT in branch .. Change version to non-SNAPSHOT in branch Change-Id:

[kudu-CR](branch-1.0.x) Change version to non-SNAPSHOT in branch

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Change version to non-SNAPSHOT in branch .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3398/ -- To view, visit

[kudu-CR] Bump version to 1.1.0-SNAPSHOT

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4400 Change subject: Bump version to 1.1.0-SNAPSHOT .. Bump version to 1.1.0-SNAPSHOT Change-Id: Ifd9db10a73fecbb73cebe66c16d16e9d11a98750 ---

[kudu-CR](branch-1.0.x) Revert "java: fix leak of TabletClient objects in client2tablets map"

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4398 Change subject: Revert "java: fix leak of TabletClient objects in client2tablets map" .. Revert "java: fix leak of TabletClient objects

[kudu-CR] Add two RAT excludes

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add two RAT excludes .. Add two RAT excludes - .avsc files can't have a comment header - The HTML template used for the doxygen footer seems small enough

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy This fixes a

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [docs/doxygen] removed auto-generated comments .. [docs/doxygen] removed auto-generated comments The template auto-generated comments for doxygen

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 3: Verified+1 Known-flaky java test -- To view, visit

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4395/1/src/kudu/client/session-internal.h File

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4395/1/src/kudu/client/session-internal.cc

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 2: > How sure are we that this won't negatively affect the > non-auto-flush code path? i.e is

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 2: (1 comment) I left you some comments just as you revved PS2. Not sure if you saw them.

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3396/ -- To view, visit

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4395 to look at the new patch set (#2). Change subject: [client] avoid circular deps in time-based flusher .. [client]

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4395/1/src/kudu/client/session-internal.cc

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4395/1/src/kudu/client/session-internal.cc

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [docs/doxygen] removed auto-generated comments .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4397 To unsubscribe, visit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool This change ports fs_dump actions under

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: port ts-cli .. tool: port ts-cli I chose to expose common server functionality in new 'master' and 'tserver' modes rather than consolidating them

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4305 To unsubscribe, visit

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4373 To unsubscribe, visit

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [docs/doxygen] removed auto-generated comments .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4397 To unsubscribe, visit

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [docs/doxygen] removed auto-generated comments .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3395/ -- To view, visit

[kudu-CR] [docs/doxygen] removed auto-generated comments

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4397 Change subject: [docs/doxygen] removed auto-generated comments .. [docs/doxygen] removed auto-generated comments The template

[kudu-CR] Add two RAT excludes

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add two RAT excludes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4396 To unsubscribe, visit

[kudu-CR] Add two RAT excludes

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add two RAT excludes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3394/ -- To view, visit http://gerrit.cloudera.org:8080/4396 To

[kudu-CR] Add two RAT excludes

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4396 to review the following change. Change subject: Add two RAT excludes .. Add two RAT excludes - .avsc

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4392 To

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 3: took care of all the nits -- To view, visit

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4392 to look at the new patch set (#3). Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3393/ -- To view,

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3392/ -- To view,

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4392 to look at the new patch set (#2). Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 5: Just rebased -- To view, visit http://gerrit.cloudera.org:8080/4373 To unsubscribe, visit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 8: Just rebased and put this in a series with Dinesh's patch. Will commit if it passes -- To

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#14). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/3391/ -- To view, visit

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4373 to look at the new patch set (#5). Change subject: tool: port ts-cli .. tool: port ts-cli I chose to

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3389/ -- To view, visit

[kudu-CR] KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting

2016-09-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4333

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4373 To unsubscribe, visit

[kudu-CR] Remove a spurious warning left in raft consensus state.cc

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove a spurious warning left in raft_consensus_state.cc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4391 To unsubscribe,

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-12 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4394 to look at the new patch set (#2). Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. KUDU-1090:

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3388/ -- To view, visit

[kudu-CR] WIP: KUDU-1090 test

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. Change subject: WIP: KUDU-1090 test .. Abandoned Oops, meant to squash this in with the other patch. -- To view, visit http://gerrit.cloudera.org:8080/4393 To unsubscribe, visit

[kudu-CR] WIP: KUDU-1090 test

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: KUDU-1090 test .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3386/ -- To view, visit http://gerrit.cloudera.org:8080/4393 To

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3387/ -- To view, visit

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-12 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4394 to review the following change. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. KUDU-1090: relax

[kudu-CR] WIP: KUDU-1090 test

2016-09-12 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4393 to review the following change. Change subject: WIP: KUDU-1090 test .. WIP: KUDU-1090 test Change-Id:

[kudu-CR] Remove a spurious warning left in raft consensus state.cc

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Remove a spurious warning left in raft_consensus_state.cc .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3384/ -- To view, visit

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4392 to review the following change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy ..

[kudu-CR] Remove a spurious warning left in raft consensus state.cc

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4391 to review the following change. Change subject: Remove a spurious warning left in raft_consensus_state.cc .. Remove a

[kudu-CR] KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1605. Blocks can be incorrectly deleted if TS crashes mid-copy .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3385/ -- To view,

[kudu-CR] Take 2: fix flakiness in tablet history gc-itest

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Take 2: fix flakiness in tablet_history_gc-itest .. Take 2: fix flakiness in tablet_history_gc-itest 3a9ea63b9f210b64124b2d9d2b5f14ed1214f272 attempted to

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4384/2/_posts/predicate-pushdown.md

[kudu-CR] Take 2: fix flakiness in tablet history gc-itest

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Take 2: fix flakiness in tablet_history_gc-itest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4388 To unsubscribe, visit

[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4308/2//COMMIT_MSG Commit Message:

[kudu-CR] Add more release notes for new features in 1.0

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add more release notes for new features in 1.0 .. Add more release notes for new features in 1.0 Change-Id: Ideac208aa377b52cc9910c05a9fa4d25a333d49a

[kudu-CR] Take 2: fix flakiness in tablet history gc-itest

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Take 2: fix flakiness in tablet_history_gc-itest .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3383/ -- To view, visit

[kudu-CR] Take 2: fix flakiness in tablet history gc-itest

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4388 to review the following change. Change subject: Take 2: fix flakiness in tablet_history_gc-itest .. Take 2: fix

[kudu-CR] [client] performance optimizations

2016-09-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4385/2//COMMIT_MSG Commit Message: Line 10: which

[kudu-CR] release notes: improve explanation of repartitioning limitation

2016-09-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: release_notes: improve explanation of repartitioning limitation .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4387 To

[kudu-CR] release notes: improve explanation of repartitioning limitation

2016-09-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: release_notes: improve explanation of repartitioning limitation .. release_notes: improve explanation of repartitioning limitation Change-Id:

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 10: Filed a cpplint issue @ https://github.com/google/styleguide/issues/176 -- To view,

[kudu-CR] release notes: improve explanation of repartitioning limitation

2016-09-12 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4387 to review the following change. Change subject: release_notes: improve explanation of repartitioning limitation ..

[kudu-CR] Add more release notes for new features in 1.0

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add more release notes for new features in 1.0 .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3381/ -- To view, visit

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4373 To unsubscribe, visit

[kudu-CR] release notes: improve explanation of repartitioning limitation

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: release_notes: improve explanation of repartitioning limitation .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3382/ -- To view, visit

[kudu-CR] release notes: improve explanation of repartitioning limitation

2016-09-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: release_notes: improve explanation of repartitioning limitation .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4387 To

[kudu-CR] Reorganize and fill out release notes for 1.0

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Reorganize and fill out release notes for 1.0 .. Patch Set 1: Will gave me a verbal +1 to move forward with this commit -- To view, visit

[kudu-CR] Reorganize and fill out release notes for 1.0

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Reorganize and fill out release notes for 1.0 .. Reorganize and fill out release notes for 1.0 - moved old version release notes to a separate page -

[kudu-CR] [client] performance optimizations

2016-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4385/2//COMMIT_MSG Commit Message: Line 11: a client pushes

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: Line

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4373 to look at the new patch set (#4). Change subject: tool: port ts-cli .. tool: port ts-cli I chose to expose

[kudu-CR] [client] performance optimizations

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 2: Oh, somehow I didn't see the whole patch when I made the previous comment. Please disregrad. -- To view,

[kudu-CR] [client] performance optimizations

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4385/2//COMMIT_MSG Commit Message: Line 11: a client pushes

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4305 To unsubscribe, visit

[kudu-CR] [client] performance optimizations

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3379/ -- To view, visit

[kudu-CR] [client] performance optimizations

2016-09-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4385 to look at the new patch set (#2). Change subject: [client] performance optimizations .. [client] performance

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 13: (2 comments)

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/3378/ -- To view, visit

  1   2   >