Dinesh Bhat has posted comments on this change.
Change subject: Avoid extra fsyncs of tombstoned tablets during startup
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4915/3/src/kudu/tablet/tablet_metadata.cc
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4937
to look at the new patch set (#3).
Change subject: [OpenSSL] require at least 1.0.0 version
..
Alexey Serbin has posted comments on this change.
Change subject: Improve debuggability of the delta/compaction path
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4930/2/src/kudu/tablet/delta_store.cc
File
Alexey Serbin has posted comments on this change.
Change subject: Add a macro to LOG and return on a non-OK status
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4927/2//COMMIT_MSG
Commit Message:
Nit: if
Alexey Serbin has posted comments on this change.
Change subject: [ssl] disable SSL/TLS compression
..
Patch Set 1:
(1 comment)
> (1 comment)
>
> Good catch. I wasn't aware of this. Also just FYI, it looks like
> it's
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4962
Change subject: [ssl] disable SSL/TLS compression
..
[ssl] disable SSL/TLS compression
As for the best recommended practices for
Todd Lipcon has submitted this change and it was merged.
Change subject: ssl: switch to older APIs for initializing SSL
..
ssl: switch to older APIs for initializing SSL
This enables support for OpenSSL 1.0.0 as found on RHEL
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [java client] Implement RPC tracing, part 2
..
[java client] Implement RPC tracing, part 2
This patch adds pretty printing for the traces, and
Dan Burkert has posted comments on this change.
Change subject: ssl: switch to older APIs for initializing SSL
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4957
To unsubscribe, visit
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix broken GFlags documentation link
..
Fix broken GFlags documentation link
Change-Id: Ib67847245608bfe2b8bd827c34aa27ae051d97a3
Reviewed-on:
Hello Dan Burkert, Sailesh Mukil, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4959
to review the following change.
Change subject: rpc: move connection header send/receive into negotiation.cc
Hello Dan Burkert, Sailesh Mukil, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4957
to look at the new patch set (#2).
Change subject: ssl: switch to older APIs for initializing SSL
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
..
Patch Set 3:
> I'll defer the +2 to Alexey; he's most familiar with the equivalent
>
Adar Dembo has posted comments on this change.
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
..
Patch Set 3: Code-Review+1
I'll defer the +2 to Alexey; he's most familiar with the equivalent
Adar Dembo has posted comments on this change.
Change subject: [java client] Implement RPC tracing, part 2
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4950
To unsubscribe, visit
Alexey Serbin has posted comments on this change.
Change subject: ssl: switch to older APIs for initializing SSL
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4957/1/src/kudu/util/net/ssl_factory.cc
File
Dan Burkert has submitted this change and it was merged.
Change subject: cmake: search for all required Kerberos binaries
..
cmake: search for all required Kerberos binaries
If one or more binaries are not found, CMake will
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [java client] Implement RPC tracing, part 1
..
[java client] Implement RPC tracing, part 1
First part of this work is adding the tracing objects
Hello Mike Percy, Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4958
to review the following change.
Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown
Sailesh Mukil has posted comments on this change.
Change subject: ssl: switch to older APIs for initializing SSL
..
Patch Set 1:
(1 comment)
After reading the attached discussion, LGTM.
Hello Dan Burkert, Sailesh Mukil, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4957
to review the following change.
Change subject: ssl: switch to older APIs for initializing SSL
Todd Lipcon has posted comments on this change.
Change subject: Fix broken GFlags documentation link
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4955
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: cmake: search for all required Kerberos binaries
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4954
To unsubscribe, visit
Dan Burkert has posted comments on this change.
Change subject: [java client] Implement RPC tracing, part 1
..
Patch Set 9: Code-Review+2
thanks!
--
To view, visit http://gerrit.cloudera.org:8080/4781
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: Avoid extra fsyncs of tombstoned tablets during startup
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4915/3/src/kudu/tablet/tablet_metadata.cc
Hello Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4954
to look at the new patch set (#2).
Change subject: cmake: search for all required Kerberos binaries
..
cmake: search
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4781
to look at the new patch set (#9).
Change subject: [java client] Implement RPC tracing, part 1
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4955
Change subject: Fix broken GFlags documentation link
..
Fix broken GFlags documentation link
Change-Id:
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4949
to look at the new patch set (#3).
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
Adar Dembo has posted comments on this change.
Change subject: [java client] Implement RPC tracing, part 2
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4950
To unsubscribe, visit
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4954
to review the following change.
Change subject: cmake: search for all required Kerberos binaries
..
cmake: search for
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4781
to look at the new patch set (#8).
Change subject: [java client] Implement RPC tracing, part 1
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4950
to look at the new patch set (#3).
Change subject: [java client] Implement RPC tracing, part 2
Dan Burkert has posted comments on this change.
Change subject: [java client] Implement RPC tracing, part 1
..
Patch Set 5:
(1 comment)
sorz
Jean-Daniel Cryans has posted comments on this change.
Change subject: Add KuduTable.getFormattedRangePartitions method
..
Patch Set 2:
(8 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4916
to look at the new patch set (#3).
Change subject: KUDU-1735. Fix crash when aborting a skipped config change round
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4950
to look at the new patch set (#2).
Change subject: [java client] Implement RPC tracing, part 2
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4949
to look at the new patch set (#2).
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4949/1//COMMIT_MSG
Dinesh Bhat has posted comments on this change.
Change subject: [tools] Manual recovery tools (part 1)
..
Patch Set 10:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/tools/kudu-tool-test.cc
File
Adar Dembo has posted comments on this change.
Change subject: [java client] Implement RPC tracing, part 2
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4950/1//COMMIT_MSG
Commit Message:
PS1, Line 10: We
Adar Dembo has posted comments on this change.
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4949/1//COMMIT_MSG
Commit
Adar Dembo has posted comments on this change.
Change subject: [java client] Implement RPC tracing, part 1
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4781
To unsubscribe, visit
Dan Burkert has posted comments on this change.
Change subject: installation.adoc: add openssl requirement for macOS
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4952/1/docs/installation.adoc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4952
to look at the new patch set (#2).
Change subject: installation.adoc: add openssl requirement for macOS
..
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: block_manager: better preallocation in log block manager
..
block_manager: better preallocation in log block manager
As has been discussed to
Jean-Daniel Cryans has posted comments on this change.
Change subject: block_manager: better preallocation in log block manager
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4848
To
Adar Dembo has submitted this change and it was merged.
Change subject: [java client] Cleanup "Connection reset" message in TabletClient
..
[java client] Cleanup "Connection reset" message in TabletClient
It was adding a
Adar Dembo has posted comments on this change.
Change subject: [java client] Cleanup "Connection reset" message in TabletClient
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4947
To
Adar Dembo has posted comments on this change.
Change subject: installation.adoc: add openssl requirement for macOS
..
Patch Set 1:
(3 comments)
We also need to doc the openssl requirement on Linux. Do you want to do that
Hello Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4952
to review the following change.
Change subject: installation.adoc: add openssl requirement for macOS
..
Mike Percy has posted comments on this change.
Change subject: [tools] Manual recovery tools (part 1)
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/tool_action_local_replica.cc
File
Mike Percy has posted comments on this change.
Change subject: [tools] Manual recovery tools (part 1)
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/tools/kudu-tool-test.cc
File
Mike Percy has posted comments on this change.
Change subject: [tools] Manual recovery tools (part 1)
..
Patch Set 10:
(2 comments)
> Would you mind also adding a test that makes sure that attempting
> to copy over an
Dinesh Bhat has posted comments on this change.
Change subject: [tools] Manual recovery tools (part 1)
..
Patch Set 10:
(2 comments)
> (2 comments)
>
> Would you mind also adding a test that makes sure that attempting
>
Hao Hao has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
..
Patch Set 2:
Working on the fix..
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe,
Hello Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4950
to review the following change.
Change subject: [java client] Implement RPC tracing, part 2
..
[java
Hello Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4949
to review the following change.
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
Hello Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4947
to review the following change.
Change subject: [java client] Cleanup "Connection reset" message in TabletClient
Mike Percy has posted comments on this change.
Change subject: [tools] Manual recovery tools (part 1)
..
Patch Set 10:
> maybe we should always force
Actually, what I think we should do is attempt to send the actual
Jean-Daniel Cryans has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
..
Patch Set 2:
> Build Failed
>
> http://104.196.14.100/job/kudu-gerrit/4280/ : FAILURE
Looks
Mike Percy has posted comments on this change.
Change subject: block_manager: disk space checking everywhere
..
Patch Set 5:
Apparently needs a rebase, please feel free to carry my +2 through
--
To view, visit
Mike Percy has submitted this change and it was merged.
Change subject: block_manager: various changes to disk space reservation
checking
..
block_manager: various changes to disk space reservation checking
I was trying to
Mike Percy has posted comments on this change.
Change subject: block_manager: cosmetic changes to the LBM
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4847
To unsubscribe, visit
Mike Percy has posted comments on this change.
Change subject: block_manager: various changes to disk space reservation
checking
..
Patch Set 4:
(3 comments)
Haijie Hong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4946
Change subject: KUDU-100 enable the ability to use RLE for the int64 type
..
KUDU-100 enable the ability to use RLE for the int64 type
As
Hao Hao has uploaded a new patch set (#2).
Change subject: Reject CREATE TABLE ops with even replication factor
..
Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and
Hao Hao has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4945
Change subject: Reject CREATE TABLE ops with even replication factor
..
Reject CREATE TABLE ops with even replication factor
Reject table
68 matches
Mail list logo
