[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6585 to look at the new patch set (#3). Change subject: log block manager: use extent maps to decide whether to truncate containers

[kudu-CR] fs: generate report during Open

2017-04-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6581 to look at the new patch set (#3). Change subject: fs: generate report during Open .. fs: generate report during

[kudu-CR] log block manager: corruptor test utility

2017-04-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6582 to look at the new patch set (#3). Change subject: log block manager: corruptor test utility .. log block manager:

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6585 to look at the new patch set (#2). Change subject: log block manager: use extent maps to decide whether to truncate containers

[kudu-CR] log block manager: corruptor test utility

2017-04-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6582 to look at the new patch set (#2). Change subject: log block manager: corruptor test utility .. log block manager:

[kudu-CR] fs: generate report during Open

2017-04-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6581 to look at the new patch set (#2). Change subject: fs: generate report during Open .. fs: generate report during

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

2017-04-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6583 to look at the new patch set (#2). Change subject: env: add RWFile::GetExtentMap for analyzing file extents ..

[kudu-CR] fs: ensure FS IOC FIEMAP can be used on LBM systems

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. Change subject: fs: ensure FS_IOC_FIEMAP can be used on LBM systems .. Abandoned It turns out that aufs does not support FS_IOC_FIEMAP. That's why all of the precommit tests failed: aufs

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: env: add RWFile::GetExtentMap for analyzing file extents .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6583/1/src/kudu/util/env-test.cc File

[kudu-CR] fs: generate report during Open

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fs: generate report during Open .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/6581/1//COMMIT_MSG Commit Message: Line 7: fs: generate report

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: env: add RWFile::GetExtentMap for analyzing file extents .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6583/1/src/kudu/util/env-test.cc File

[kudu-CR] Add ksck section to admin guide common workflows

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add ksck section to admin guide common workflows .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6598/1/docs/administration.adoc File

[kudu-CR] Add ksck section to admin guide common workflows

2017-04-07 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Ambreen Kazi, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6598 to review the following change. Change subject: Add ksck section to admin guide common workflows

[kudu-CR] WIP: reduce contention on MemTracker::Release and Consume in block cache

2017-04-07 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6597 to review the following change. Change subject: WIP: reduce contention on MemTracker::Release and Consume in block cache

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-07 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6566 to look at the new patch set (#4). Change subject: KUDU-579 [java_client] Scanner fault tolerance .. KUDU-579

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. KUDU-1965: Allow user provided TLS certificates to work with KRPC This patch adds a bool in

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6589 To unsubscribe, visit

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/6574/6/src/kudu/client/client-test.cc

[kudu-CR] fs: ensure FS IOC FIEMAP can be used on LBM systems

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fs: ensure FS_IOC_FIEMAP can be used on LBM systems .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6584/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6574 to look at the new patch set (#7). Change subject: Allow to get the raw data from a KuduScanBatch .. Allow to get

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6589/3/src/kudu/fs/block_manager_util.cc

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6589 to look at the new patch set (#4). Change subject: KUDU-1966: Data directories can be removed erroneously ..

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-07 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6594 to look at the new patch set (#2). Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6574/6/src/kudu/client/client-test.cc File

[kudu-CR] KUDU-1964. security: avoid calling ERR clear error() defensively

2017-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1964. security: avoid calling ERR_clear_error() defensively .. KUDU-1964. security: avoid calling ERR_clear_error() defensively This changes our

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously .. Patch Set 3: (1 comment) Much better.

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6574 to look at the new patch set (#6). Change subject: Allow to get the raw data from a KuduScanBatch .. Allow to get

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 5: (2 comments) Sorry for the confusion

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/4/src/kudu/client/scan_batch.h File

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6574 to look at the new patch set (#5). Change subject: Allow to get the raw data from a KuduScanBatch .. Allow to get

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: env: add RWFile::GetExtentMap for analyzing file extents .. Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/6583/1/src/kudu/util/env-test.cc File

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6589 to look at the new patch set (#3). Change subject: KUDU-1966: Data directories can be removed erroneously ..

[kudu-CR] fs: generate report during Open

2017-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: fs: generate report during Open .. Patch Set 1: (8 comments) only skimmed through so far since I see David took a look

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/4/src/kudu/client/scan_batch.h File

[kudu-CR] log block manager: corruptor test utility

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: corruptor test utility .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6582/1/src/kudu/fs/log_block_manager-test-util.cc File

[kudu-CR] fs: generate report during Open

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fs: generate report during Open .. Patch Set 1: (22 comments) http://gerrit.cloudera.org:8080/#/c/6581/1/src/kudu/fs/block_manager.h File

[kudu-CR] KUDU-1964. security: avoid calling ERR clear error() defensively

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1964. security: avoid calling ERR_clear_error() defensively .. Patch Set 4: Code-Review+2 (2 comments)

[kudu-CR] Allow to release an rpc transfer's data

2017-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow to release an rpc transfer's data .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/6592/5//COMMIT_MSG Commit Message: PS5, Line 10: obtain

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/3/src/kudu/client/scan_batch.h File

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6574 to look at the new patch set (#4). Change subject: Allow to get the raw data from a KuduScanBatch .. Allow to get

[kudu-CR] [security] fixed shortened TSK validity interval

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [security] fixed shortened TSK validity interval .. [security] fixed shortened TSK validity interval The TSK validity interval should be

[kudu-CR] KUDU-1964. security: avoid calling ERR clear error() defensively

2017-04-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6552 to look at the new patch set (#4). Change subject: KUDU-1964. security: avoid calling ERR_clear_error() defensively

[kudu-CR] Allow to release an rpc transfer's data

2017-04-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6592 to look at the new patch set (#5). Change subject: Allow to release an rpc transfer's data .. Allow to release an

[kudu-CR] KUDU-1964. security: avoid calling ERR clear error() defensively

2017-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1964. security: avoid calling ERR_clear_error() defensively .. Patch Set 3: (2 comments)

[kudu-CR] fs: ensure FS IOC FIEMAP can be used on LBM systems

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: fs: ensure FS_IOC_FIEMAP can be used on LBM systems .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6584/1/src/kudu/fs/data_dirs.cc File

[kudu-CR] fs: ensure FS IOC FIEMAP can be used on LBM systems

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: fs: ensure FS_IOC_FIEMAP can be used on LBM systems .. Patch Set 1: Code-Review+2 (1 comment) feel free to ignore the nit or address it

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-04-07 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#5). Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: env: add RWFile::GetExtentMap for analyzing file extents .. Patch Set 1: (10 comments)

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-04-07 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#4). Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-04-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .. Patch Set 4: (5 comments)

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 3: (1 comment) Just a tiny nit to improve doxygen-related documentation for the new methods.

[kudu-CR] [python] Fix flaky test test connect timeouts

2017-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [python] Fix flaky test test_connect_timeouts .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6573 To unsubscribe, visit

[kudu-CR] [python] Fix flaky test test connect timeouts

2017-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [python] Fix flaky test test_connect_timeouts .. [python] Fix flaky test test_connect_timeouts It only tests passing the timeout, but it's low enough

[kudu-CR] [security] fixed shortened TSK validity interval

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] fixed shortened TSK validity interval .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6536 To unsubscribe, visit

[kudu-CR] fs: generate report during Open

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: fs: generate report during Open .. Patch Set 1: (11 comments) first round of reviews. this patch is pretty heftly so I'll review it in 2-3 rounds or

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6589/2/src/kudu/fs/block_manager_util.cc

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 3: (10 comments) I think overall the error handling needs some work; it looks like right now it's

[kudu-CR] [consensus] fixed typos in consensus flags tagging

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [consensus] fixed typos in consensus flags tagging .. [consensus] fixed typos in consensus flags tagging Change-Id:

[kudu-CR] [consensus] fixed typos in consensus flags tagging

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [consensus] fixed typos in consensus flags tagging .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc

[kudu-CR] [consensus] fixed typos in consensus flags tagging

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] fixed typos in consensus flags tagging .. Patch Set 1: (1 comment)

[kudu-CR] WIP: Allow to release an rpc transfer's data

2017-04-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6592 to look at the new patch set (#4). Change subject: WIP: Allow to release an rpc transfer's data .. WIP: Allow to

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6589/2/src/kudu/fs/block_manager_util.cc

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add --redact=none flag option for specifying no redaction .. Add --redact=none flag option for specifying no redaction It's still possible to specify no

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6594 Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. KUDU-1965: Allow user provided TLS certificates to

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6589/1/src/kudu/fs/block_manager_util.cc

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Add --redact=none flag option for specifying no redaction .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6590 To unsubscribe, visit

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6589 to look at the new patch set (#2). Change subject: KUDU-1966: Data directories can be removed erroneously ..

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add --redact=none flag option for specifying no redaction .. Patch Set 4: The differences is that the flags are now getting reset back to the default value every

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add --redact=none flag option for specifying no redaction .. Patch Set 4: Code-Review+2 I'm curious as to how the diff between PS4 and PS3 fixed the test failures.

[kudu-CR] [docs] Add security guide

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/6479/4/docs/security.adoc File docs/security.adoc: PS4, Line 31: will

[kudu-CR] [docs] Add security guide

2017-04-07 Thread Dan Burkert (Code Review)
Hello Hao Hao, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6479 to look at the new patch set (#5). Change subject: [docs] Add security guide .. [docs] Add

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6590 to look at the new patch set (#4). Change subject: Add --redact=none flag option for specifying no redaction

[kudu-CR] KUDU-1965: Allow user provided TLS certificates to work with KRPC

2017-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: KUDU-1965: Allow user provided TLS certificates to work with KRPC .. Abandoned Patch is incorrect. Will post another one shortly. -- To view, visit

[kudu-CR] WIP: Allow to release an rpc transfer's data

2017-04-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6592 to look at the new patch set (#3). Change subject: WIP: Allow to release an rpc transfer's data .. WIP: Allow to

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Add --redact=none flag option for specifying no redaction .. Patch Set 3: The change looks good to me, but can you check why the tests are failing? It looks like

[kudu-CR] [security-faults-itest] fix test flakiness

2017-04-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [security-faults-itest] fix test flakiness .. [security-faults-itest] fix test flakiness When running the security-faults-itest on a slow VM with other

[kudu-CR] WIP: Allow to release an rpc transfer's data

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: Allow to release an rpc transfer's data .. WIP: Allow to release an rpc transfer's data This adds a way to release a transfer's data to a caller. This

[kudu-CR] whole batch release, but wrong

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: whole batch release, but wrong .. Abandoned oops forgot to squash -- To view, visit http://gerrit.cloudera.org:8080/6591 To unsubscribe, visit

[kudu-CR] whole batch release, but wrong

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6591 Change subject: whole batch release, but wrong .. whole batch release, but wrong Change-Id:

[kudu-CR] WIP: Allow to release an rpc transfer's data

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6592 Change subject: WIP: Allow to release an rpc transfer's data .. WIP: Allow to release an rpc transfer's data This adds a way to

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6589/1/src/kudu/fs/block_manager_util.cc

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/1/src/kudu/client/scan_batch.h File

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#3). Change subject: Allow to get the raw data from a KuduScanBatch .. Allow to get the raw data from a KuduScanBatch This allows to fetch both the direct and the indirect raw

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6589/1/src/kudu/fs/block_manager_util.cc

[kudu-CR] [security-faults-itest] fix test flakiness

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [security-faults-itest] fix test flakiness .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6586 To unsubscribe, visit

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/1/src/kudu/client/scan_batch.h File

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .. Patch Set 1: (2 comments)

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Allow to get the raw data from a KuduScanBatch .. Allow to get the raw data from a KuduScanBatch This allows to fetch both the direct and the indirect raw

[kudu-CR] Allow to get the raw data from a KuduScanBatch

2017-04-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch .. Patch Set 1: ok, makes sense. will do that in a follow up patch. -- To view, visit

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1966: Data directories can be removed erroneously .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6589/1/src/kudu/fs/block_manager_util.cc

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add --redact=none flag option for specifying no redaction .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6590 To unsubscribe,

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6590 to look at the new patch set (#3). Change subject: Add --redact=none flag option for specifying no redaction ..

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add --redact=none flag option for specifying no redaction .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6590/1/src/kudu/util/flags.cc File

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: Add --redact=none flag option for specifying no redaction .. Add --redact=none flag option for specifying no redaction It's still possible to specify no redaction

[kudu-CR] Add --redact=none flag option for specifying no redaction

2017-04-07 Thread Dan Burkert (Code Review)
Hello Hao Hao, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6590 to review the following change. Change subject: Add --redact=none flag option for specifying no redaction ..

[kudu-CR] KUDU-1966: Data directories can be removed erroneously

2017-04-07 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6589 to review the following change. Change subject: KUDU-1966: Data directories can be removed erroneously .. KUDU-1966:

[kudu-CR] KUDU-1424. Add getters to PartialRow

2017-04-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: KUDU-1424. Add getters to PartialRow .. Patch Set 1: (2 comments)

  1   2   >