[kudu-CR] [docs] Refresh and augment the known issues

2017-04-20 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6699 to look at the new patch set (#3). Change subject: [docs] Refresh and augment the known issues ..

[kudu-CR] [docs] Refresh and augment the known issues

2017-04-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Refresh and augment the known issues .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6699/2/docs/known_issues.adoc File

[kudu-CR](gh-pages) FAQ refresh

2017-04-20 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6697 to look at the new patch set (#2). Change subject: FAQ refresh .. FAQ refresh Change-Id:

[kudu-CR](gh-pages) FAQ refresh

2017-04-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: FAQ refresh .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6697/1/faq.md File faq.md: PS1, Line 250: Kudu hasn't been officially tested

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-20 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/6630/6/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] Simplify MemTracker and move process throttling elsewhere

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Simplify MemTracker and move process throttling elsewhere .. Patch Set 3: (11 comments)

[kudu-CR] tpch: allow hash partitioning

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tpch: allow hash partitioning .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6709/1/src/kudu/benchmarks/tpch/rpc_line_item_dao.h File

[kudu-CR] Silence clang -Waddress-of-packed-member warning in concurrent btree.h

2017-04-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Silence clang -Waddress-of-packed-member warning in concurrent_btree.h .. Patch Set 2: (1 comment)

[kudu-CR] Silence clang -Waddress-of-packed-member warning in concurrent btree.h

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Silence clang -Waddress-of-packed-member warning in concurrent_btree.h .. Patch Set 2: (1 comment)

[kudu-CR] Silence clang -Waddress-of-packed-member warning in concurrent btree.h

2017-04-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Silence clang -Waddress-of-packed-member warning in concurrent_btree.h .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6693 To

[kudu-CR] Simplify MemTracker and move process throttling elsewhere

2017-04-20 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6620 to look at the new patch set (#3). Change subject: Simplify MemTracker and move process throttling elsewhere

[kudu-CR] tpch: allow hash partitioning

2017-04-20 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6709 to review the following change. Change subject: tpch: allow hash partitioning .. tpch: allow hash partitioning This

[kudu-CR] Silence clang -Waddress-of-packed-member warning in concurrent btree.h

2017-04-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6693 to look at the new patch set (#2). Change subject: Silence clang -Waddress-of-packed-member warning in concurrent_btree.h

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6630/6/src/kudu/util/env.h File src/kudu/util/env.h:

[kudu-CR] Tweak ListMasters RPC error handling

2017-04-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Tweak ListMasters RPC error handling .. Patch Set 2: We discussed testing offline and decided to punt. A follow-up patch will be testing the success case. --

[kudu-CR](gh-pages) FAQ refresh

2017-04-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: FAQ refresh .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6697/1/faq.md File faq.md: PS1, Line 250: Kudu hasn't been officially tested

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6623 to look at the new patch set (#10). Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Allow to

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#6). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Patch Set 9: (2 comments)

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Patch Set 9: (2 comments) lgtm aside from a couple nits

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 6: (2 comments) Just did a quick look at the approach using readv, it seems like a good direction to me. I

[kudu-CR] WIP: Expose "raw" mode in KuduScanner and allow to pass flags

2017-04-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: Expose "raw" mode in KuduScanner and allow to pass flags .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/6624/5/src/kudu/client/client.h

[kudu-CR] KUDU-1952 Don't use round-robin for block placement

2017-04-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#5). Change subject: KUDU-1952 Don't use round-robin for block placement ..

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-20 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6630 to look at the new patch set (#6). Change subject: WIP: KUDU-463. Add checksumming to cfile .. WIP: KUDU-463. Add

[kudu-CR] [docs] Refresh and augment the known issues

2017-04-20 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: [docs] Refresh and augment the known issues .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6699/2/docs/known_issues.adoc File

[kudu-CR] Tweak ListMasters RPC error handling

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Tweak ListMasters RPC error handling .. Patch Set 2: Maybe add a small unit test in master-test? -- To view, visit http://gerrit.cloudera.org:8080/6704 To

[kudu-CR] Tweak ListMasters RPC error handling

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Tweak ListMasters RPC error handling .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6704/1/src/kudu/master/master_service.cc File

[kudu-CR] Add 'kudu master list' tool

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add 'kudu master list' tool .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6705 To unsubscribe, visit

[kudu-CR] Add 'kudu tserver list' tool

2017-04-20 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add 'kudu tserver list' tool .. Add 'kudu tserver list' tool This adds a new tool action to list tablet servers, and associated information. There are a

[kudu-CR] Add 'kudu tserver list' tool

2017-04-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add 'kudu tserver list' tool .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6654 To unsubscribe, visit

[kudu-CR] WIP KUDU-579 [java client] Scanner fault tolerance

2017-04-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: WIP KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 5: (4 comments)

[kudu-CR] [docs] Refresh and augment the known issues

2017-04-20 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6699 to look at the new patch set (#2). Change subject: [docs] Refresh and augment the known issues ..

[kudu-CR] KUDU-1952 Don't use round-robin for block placement

2017-04-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#4). Change subject: KUDU-1952 Don't use round-robin for block placement ..

[kudu-CR] KUDU-1952 Don't use round-robin for block placement

2017-04-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#3). Change subject: KUDU-1952 Don't use round-robin for block placement ..

[kudu-CR] KUDU-1952 Don't use round-robin for block placement

2017-04-20 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. Change subject: KUDU-1952 Don't use round-robin for block placement .. Abandoned Duplicate of 6636. -- To view, visit http://gerrit.cloudera.org:8080/6706 To unsubscribe, visit

[kudu-CR] KUDU-1952 Don't use round-robin for block placement

2017-04-20 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#2). Change subject: KUDU-1952 Don't use round-robin for block placement ..

[kudu-CR] KUDU-1952 Improve block placement

2017-04-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Improve block placement .. Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/6636/1//COMMIT_MSG Commit Message: Line 10: single-disk

[kudu-CR] KUDU-1952 Don't use round-robin for block placement

2017-04-20 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6706 Change subject: KUDU-1952 Don't use round-robin for block placement .. KUDU-1952 Don't use round-robin for block placement This is the

[kudu-CR] Add 'kudu tserver list' tool

2017-04-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6654 to look at the new patch set (#7). Change subject: Add 'kudu tserver list' tool .. Add 'kudu tserver

[kudu-CR] Tweak ListMasters RPC error handling

2017-04-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6704 to review the following change. Change subject: Tweak ListMasters RPC error handling .. Tweak ListMasters RPC error

[kudu-CR] Add 'kudu master list' tool

2017-04-20 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6705 to review the following change. Change subject: Add 'kudu master list' tool .. Add 'kudu master list' tool Change-Id:

[kudu-CR] Add 'kudu tserver list' tool

2017-04-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add 'kudu tserver list' tool .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6654/4/src/kudu/tools/tool_action_tserver.cc File

[kudu-CR] make site: only build necessary binaries

2017-04-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: make_site: only build necessary binaries .. make_site: only build necessary binaries make_site relies on these binaries to build docs for them,

[kudu-CR] WIP KUDU-579 [java client] Scanner fault tolerance

2017-04-20 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. Change subject: WIP KUDU-579 [java_client] Scanner fault tolerance .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6701 To unsubscribe, visit

[kudu-CR] WIP KUDU-579 [java client] Scanner fault tolerance

2017-04-20 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6566 to look at the new patch set (#5). Change subject: WIP KUDU-579 [java_client] Scanner fault tolerance .. WIP

[kudu-CR] WIP KUDU-579 [java client] Scanner fault tolerance

2017-04-20 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6701 Change subject: WIP KUDU-579 [java_client] Scanner fault tolerance .. WIP KUDU-579 [java_client] Scanner fault tolerance This patch adds java