[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor result handling .. Patch Set 12: Code-Review+2 (1 comment) LGTM, maybe you

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor result handling .. Patch Set 12: Verified+1 -- To view, visit

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-27 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor result handling .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor result handling .. Patch Set 9: (5 comments)

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-27 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10151 to look at the new patch set (#12). Change subject: [tools] ksck improvements [6/n]: Refactor result handling

[kudu-CR] Fast path scanning blocks of deleted rows

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10213 ) Change subject: Fast path scanning blocks of deleted rows .. Patch Set 2: Verified+1 Some unrelated flake... trying to udnerstand it

[kudu-CR] Fast path scanning blocks of deleted rows

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fast path scanning blocks of deleted rows .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10213 To unsubscribe, visit

[kudu-CR] [Java] Use spotbugs in place of findbugs in gradle

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10187 ) Change subject: [Java] Use spotbugs in place of findbugs in gradle .. [Java] Use spotbugs in place of findbugs in gradle

[kudu-CR] [Java] Use spotbugs in place of findbugs in gradle

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10187 ) Change subject: [Java] Use spotbugs in place of findbugs in gradle .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python

2018-04-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10072 ) Change subject: KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] Fast path scanning blocks of deleted rows

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10213 ) Change subject: Fast path scanning blocks of deleted rows .. Patch Set 1: (1 comment)

[kudu-CR] Fast path scanning blocks of deleted rows

2018-04-27 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Kudu Jenkins, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10213 to look at the new patch set (#2). Change subject: Fast path scanning blocks of deleted rows

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/6597 ) Change subject: cache: reduce contention on MemTracker::Release and Consume .. cache: reduce contention on MemTracker::Release

[kudu-CR] cache: switch to std::atomic

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10209 ) Change subject: cache: switch to std::atomic .. cache: switch to std::atomic A previous commit added some use of std::atomic,

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: cache: reduce contention on MemTracker::Release and Consume .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/6597 To

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6597 ) Change subject: cache: reduce contention on MemTracker::Release and Consume .. Patch Set 5: Verified+1 Unrelated flake -- To view,

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/6597 ) Change subject: cache: reduce contention on MemTracker::Release and Consume .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] tool: improve format for dumping a rowset

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/3946 ) Change subject: tool: improve format for dumping a rowset .. Patch Set 4: Verified+1 Unrelated test failure -- To view, visit

[kudu-CR] tool: improve format for dumping a rowset

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: tool: improve format for dumping a rowset .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/3946 To unsubscribe, visit

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-27 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6597 to look at the new patch set (#5). Change subject: cache: reduce contention on MemTracker::Release and Consume

[kudu-CR] cache: reduce contention on MemTracker::Release and Consume

2018-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6597 ) Change subject: cache: reduce contention on MemTracker::Release and Consume .. Patch Set 4: (3 comments)

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor result handling .. Patch Set 11: (5 comments)

[kudu-CR](branch-1.7.x) pstack watcher: blacklist older versions of gdb

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10230 ) Change subject: pstack_watcher: blacklist older versions of gdb .. pstack_watcher: blacklist older versions of gdb Despite

[kudu-CR](branch-1.7.x) test util: include shard number in test scratch directory name

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: test_util: include shard number in test scratch directory name .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10231

[kudu-CR](branch-1.7.x) test util: include shard number in test scratch directory name

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10231 ) Change subject: test_util: include shard number in test scratch directory name .. test_util: include shard number in test

[kudu-CR](branch-1.7.x) test util: include shard number in test scratch directory name

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10231 ) Change subject: test_util: include shard number in test scratch directory name .. Patch Set 2: Verified+1 Code-Review+2 Carrying

[kudu-CR](branch-1.7.x) test util: reset flags before cleaning test directory

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10229 ) Change subject: test_util: reset flags before cleaning test directory .. test_util: reset flags before cleaning test directory

[kudu-CR](branch-1.7.x) test util: reset flags before cleaning test directory

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: test_util: reset flags before cleaning test directory .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10229 To

[kudu-CR](branch-1.7.x) test util: reset flags before cleaning test directory

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10229 ) Change subject: test_util: reset flags before cleaning test directory .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR](branch-1.7.x) build-and-test.sh: unbreak Python 2.6 based builds

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10228 ) Change subject: build-and-test.sh: unbreak Python 2.6 based builds .. build-and-test.sh: unbreak Python 2.6 based builds The

[kudu-CR] [Java] Check in the Gradle wrapper properties

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10215 ) Change subject: [Java] Check in the Gradle wrapper properties .. [Java] Check in the Gradle wrapper properties We were

[kudu-CR](branch-1.7.x) pstack watcher: blacklist older versions of gdb

2018-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10230 ) Change subject: pstack_watcher: blacklist older versions of gdb .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.7.x) test util: include shard number in test scratch directory name

2018-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10231 ) Change subject: test_util: include shard number in test scratch directory name .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.7.x) build-and-test.sh: unbreak Python 2.6 based builds

2018-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10228 ) Change subject: build-and-test.sh: unbreak Python 2.6 based builds .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.7.x) test util: reset flags before cleaning test directory

2018-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10229 ) Change subject: test_util: reset flags before cleaning test directory .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [Java] Check in the Gradle wrapper properties

2018-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10215 ) Change subject: [Java] Check in the Gradle wrapper properties .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python

2018-04-27 Thread Anonymous Coward (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10072 to look at the new patch set (#7). Change subject: KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python

[kudu-CR](branch-1.7.x) test util: include shard number in test scratch directory name

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10231 Change subject: test_util: include shard number in test scratch directory name .. test_util: include shard number in test scratch

[kudu-CR](branch-1.7.x) pstack watcher: blacklist older versions of gdb

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10230 Change subject: pstack_watcher: blacklist older versions of gdb .. pstack_watcher: blacklist older versions of gdb Despite commit

[kudu-CR](branch-1.7.x) test util: reset flags before cleaning test directory

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10229 Change subject: test_util: reset flags before cleaning test directory .. test_util: reset flags before cleaning test directory

[kudu-CR](branch-1.7.x) build-and-test.sh: unbreak Python 2.6 based builds

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10228 Change subject: build-and-test.sh: unbreak Python 2.6 based builds .. build-and-test.sh: unbreak Python 2.6 based builds The first beta

[kudu-CR] [Java] Use spotbugs in place of findbugs in gradle

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [Java] Use spotbugs in place of findbugs in gradle .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10187 To

[kudu-CR] [Java] Use spotbugs in place of findbugs in gradle

2018-04-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10187 ) Change subject: [Java] Use spotbugs in place of findbugs in gradle .. Patch Set 3: Verified+1 -- To view, visit

[kudu-CR] [Java] Check in the Gradle wrapper properties

2018-04-27 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10215 to look at the new patch set (#3). Change subject: [Java] Check in the Gradle wrapper properties

[kudu-CR] KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python

2018-04-27 Thread Anonymous Coward (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10072 to look at the new patch set (#6). Change subject: KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python