[kudu-CR] KUDU-702 Add block IDs to more log messages

2018-05-25 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10505 ) Change subject: KUDU-702 Add block IDs to more log messages .. Patch Set 4: (4 comments) Please review for submission.

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as metrics .. Patch Set 16: (1 comment)

[kudu-CR] KUDU-702 Add block IDs to more log messages

2018-05-25 Thread Anupama Gupta (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10505 to look at the new patch set (#4). Change subject: KUDU-702 Add block IDs to more log messages

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 8: (1 comment)

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 7: (1 comment)

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 8: (2 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Abandoned I'm sorry I never got anywhere with this but it looks like Impala is

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. KUDU-2444

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 7: (7 comments)

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10061 to look at the new patch set (#8). Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden

[kudu-CR] KUDU-702 Add block IDs to more log messages

2018-05-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10505 ) Change subject: KUDU-702 Add block IDs to more log messages .. Patch Set 3: Code-Review+1 Will defer to Mike. -- To view, visit

[kudu-CR] KUDU-702 Add block IDs to more log messages

2018-05-25 Thread Anupama Gupta (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10505 to look at the new patch set (#3). Change subject: KUDU-702 Add block IDs to more log messages

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. [tools] ksck imp. [8/n]: Easy-to-see

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 3: (3 comments)

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 7: (1 comment) Sorry for

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Patch Set 6: Verified+1 Looks like some Java

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 5: Code-Review+2 (3 comments)

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as metrics .. Patch Set 16: (1 comment)

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-25 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10076 to look at the new patch set (#16). Change subject: KUDU-2287 Expose election failures as metrics

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 7: (6 comments)

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 7: Code-Review+1 (2

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10061 to look at the new patch set (#7). Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10300 to look at the new patch set (#5). Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 4: (5 comments)

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10300 to look at the new patch set (#4). Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

[kudu-CR] [rebalancing] Add a rebalancing algorithm

2018-05-25 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10336 to look at the new patch set (#13). Change subject: [rebalancing] Add a rebalancing algorithm

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-25 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10443 to look at the new patch set (#6). Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 2: (1 comment)

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 3: (5 comments)

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 6: (8 comments)

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10061 to look at the new patch set (#6). Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden

[kudu-CR] KUDU-2287 Expose election failures as metrics

2018-05-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as metrics .. Patch Set 15: (1 comment)

[kudu-CR] KUDU-702 Add block IDs to more log messages

2018-05-25 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10505 ) Change subject: KUDU-702 Add block IDs to more log messages .. Patch Set 2: > I don't see how this patch addresses KUDU-702, because

[kudu-CR] KUDU-702 Add block IDs to more log messages

2018-05-25 Thread Anupama Gupta (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10505 to look at the new patch set (#2). Change subject: KUDU-702 Add block IDs to more log messages

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 ) Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky .. Patch Set 5: (2 comments)

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10300 to look at the new patch set (#3). Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-702 Add block IDs to more log messages

2018-05-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10505 ) Change subject: KUDU-702 Add block IDs to more log messages .. Patch Set 1: I don't see how this patch addresses KUDU-702, because all

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 2: Verified+1 Unrelated flake. --

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] WIP: Possible fix for the timeouts

2018-05-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10468 to look at the new patch set (#3). Change subject: WIP: Possible fix for the timeouts .. WIP: Possible fix for the

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 5: (5 comments)

[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

2018-05-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 ) Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. Patch Set 2: (2 comments)

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 5: (3 comments)

[kudu-CR] KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"

2018-05-25 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10514 to look at the new patch set (#2). Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"

[kudu-CR] KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"

2018-05-25 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10514 Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key" .. KUDU-2447 Fix TS crashed with "NONE predicate

[kudu-CR] KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

2018-05-25 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10443 to look at the new patch set (#5). Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10061 to look at the new patch set (#5). Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 4: (9 comments)