[kudu-CR] KUDU-2095 - Add scanner `keepAlive` RPC call to Java API

2018-07-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7749 ) Change subject: KUDU-2095 - Add scanner `keepAlive` RPC call to Java API .. Patch Set 9: (5 comments)

[kudu-CR] WIP: Atomicize OpId and Timestamp assignment

2018-07-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11070 to look at the new patch set (#6). Change subject: WIP: Atomicize OpId and Timestamp assignment .. WIP: Atomicize

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 ) Change subject: perf loadgen: add --auto_database flag and change auto table name generation .. Patch Set 4: (1 comment)

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11084 to look at the new patch set (#4). Change subject: perf loadgen: add --auto_database flag and change auto table name generation

[kudu-CR] hms-tool: lookup master addresses config from master

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 ) Change subject: hms-tool: lookup master addresses config from master .. Patch Set 4: (1 comment)

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 ) Change subject: perf loadgen: add --auto_database flag and change auto table name generation .. Patch Set 3: (1 comment)

[kudu-CR] hms-tool: lookup master addresses config from master

2018-07-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 ) Change subject: hms-tool: lookup master addresses config from master .. Patch Set 4: (1 comment)

[kudu-CR] hms precheck tool

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11040 ) Change subject: hms precheck tool .. Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/11040/7//COMMIT_MSG Commit Message:

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 ) Change subject: perf loadgen: add --auto_database flag and change auto table name generation .. Patch Set 3: (1 comment)

[kudu-CR] hms-tool: lookup master addresses config from master

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 ) Change subject: hms-tool: lookup master addresses config from master .. Patch Set 4: (2 comments)

[kudu-CR] hms-tool: lookup master addresses config from master

2018-07-30 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11083 to look at the new patch set (#4). Change subject: hms-tool: lookup master addresses config from master

[kudu-CR] hms precheck tool

2018-07-30 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11040 to look at the new patch set (#9). Change subject: hms precheck tool .. hms

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 ) Change subject: perf loadgen: add --auto_database flag and change auto table name generation .. Patch Set 2: (1 comment)

[kudu-CR] hms-tool: lookup master addresses config from master

2018-07-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 ) Change subject: hms-tool: lookup master addresses config from master .. Patch Set 3: (2 comments)

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 ) Change subject: perf loadgen: add --auto_database flag and change auto table name generation .. Patch Set 2: Code-Review+2 -- To

[kudu-CR] hms precheck tool

2018-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11040 ) Change subject: hms precheck tool .. Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/11040/7//COMMIT_MSG Commit

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 ) Change subject: perf loadgen: add --auto_database flag and change auto table name generation .. Patch Set 2: (2 comments)

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11084 to look at the new patch set (#2). Change subject: perf loadgen: add --auto_database flag and change auto table name generation

[kudu-CR] [docs] Add changing master hostnames workflow

2018-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 ) Change subject: [docs] Add changing master hostnames workflow .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 ) Change subject: perf loadgen: add --auto_database flag and change auto table name generation .. Patch Set 1: Code-Review+2 (1

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 ) Change subject: perf loadgen: add --auto_database flag and change auto table name generation .. Patch Set 1: (1 comment)

[kudu-CR] WIP: Atomicize OpId and Timestamp assignment

2018-07-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11070 to look at the new patch set (#5). Change subject: WIP: Atomicize OpId and Timestamp assignment .. WIP: Atomicize

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 ) Change subject: perf loadgen: add --auto_database flag and change auto table name generation .. Patch Set 1: (2 comments) lgtm,

[kudu-CR] WIP: Atomicize OpId and Timestamp assignment

2018-07-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11070 to look at the new patch set (#4). Change subject: WIP: Atomicize OpId and Timestamp assignment .. WIP: Atomicize

[kudu-CR] hms-tool: lookup master addresses config from master

2018-07-30 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11083 to look at the new patch set (#2). Change subject: hms-tool: lookup master addresses config from master ..

[kudu-CR] hms-tool: lookup master addresses config from master

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/11083 ) Change subject: hms-tool: lookup master addresses config from master .. Removed reviewer Alexey Serbin. -- To view, visit

[kudu-CR] hms-tool: lookup master addresses config from master

2018-07-30 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11083 to review the following change. Change subject: hms-tool: lookup master addresses config from master ..

[kudu-CR] perf loadgen: add --auto database flag and change auto table name generation

2018-07-30 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11084 to review the following change. Change subject: perf loadgen: add --auto_database flag and change auto table name generation

[kudu-CR] KUDU-2191: Correct error handling in Metadata upgrade tool

2018-07-30 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/10728 ) Change subject: KUDU-2191: Correct error handling in Metadata upgrade tool .. Abandoned No longer apply. -- To view, visit

[kudu-CR] KUDU-2507: use FBM for KuduMiniCluster

2018-07-30 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/10961 ) Change subject: KUDU-2507: use FBM for KuduMiniCluster .. Abandoned Issue fixed via other patch -- To view, visit

[kudu-CR] Scala code formatting with Scalafmt

2018-07-30 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11030 ) Change subject: Scala code formatting with Scalafmt .. Scala code formatting with Scalafmt Scalafmt

[kudu-CR] KUDU-2507: use FBM for KuduMiniCluster

2018-07-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10961 ) Change subject: KUDU-2507: use FBM for KuduMiniCluster .. Patch Set 1: I don't think we need this now that a TEST_TMPDIR fix is in

[kudu-CR] hms precheck tool

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11040 ) Change subject: hms precheck tool .. Patch Set 6: Verified+1 unrelated flake -- To view, visit http://gerrit.cloudera.org:8080/11040

[kudu-CR] hms precheck tool

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has removed a vote on this change. Change subject: hms precheck tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11040 To unsubscribe, visit

[kudu-CR] [java] Add extra info about using multiple clients

2018-07-30 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10962 ) Change subject: [java] Add extra info about using multiple clients .. [java] Add extra info about using multiple clients The

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-07-30 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components .. Patch Set 4: (41 comments) Thanks for the

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-07-30 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10983 to look at the new patch set (#4). Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components

[kudu-CR] WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

2018-07-30 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#10). Change subject: WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-07-30 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#9). Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11018 ) Change subject: hms-tool: refactor check tool and combine upgrade and fix .. hms-tool: refactor check tool and combine upgrade

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11018 ) Change subject: hms-tool: refactor check tool and combine upgrade and fix .. Patch Set 11: Code-Review+2 (2 comments)

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11018 ) Change subject: hms-tool: refactor check tool and combine upgrade and fix .. Patch Set 11: Verified+1 unrelated flake -- To view,

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has removed a vote on this change. Change subject: hms-tool: refactor check tool and combine upgrade and fix .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11018 To

[kudu-CR] WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

2018-07-30 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#8). Change subject: WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

[kudu-CR] WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

2018-07-30 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#7). Change subject: WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

[kudu-CR] WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

2018-07-30 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#6). Change subject: WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

[kudu-CR] WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

2018-07-30 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#5). Change subject: WIP 1. Added correctness test for skip scan 2. Extended the approach for equality query on any PK column

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11018 ) Change subject: hms-tool: refactor check tool and combine upgrade and fix .. Patch Set 11: (3 comments)

[kudu-CR] [java] Add extra info about using multiple clients

2018-07-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10962 ) Change subject: [java] Add extra info about using multiple clients .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] WIP tool to rewrite cfiles

2018-07-30 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11078 Change subject: WIP tool to rewrite cfiles .. WIP tool to rewrite cfiles Adds a tool to rewrite cfiles while skipping cblocks that have

[kudu-CR] [java] Add extra info about using multiple clients

2018-07-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10962 ) Change subject: [java] Add extra info about using multiple clients .. Patch Set 1: (5 comments)

[kudu-CR] hms-tool: refactor check tool and combine upgrade and fix

2018-07-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11018 to look at the new patch set (#11). Change subject: hms-tool: refactor check tool and combine upgrade and fix

[kudu-CR] [java] Add extra info about using multiple clients

2018-07-30 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10962 to look at the new patch set (#2). Change subject: [java] Add extra info about using multiple clients

[kudu-CR](branch-1.6.x) KUDU-2510 Fix symmetric difference logging

2018-07-30 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11034 ) Change subject: KUDU-2510 Fix symmetric difference logging .. KUDU-2510 Fix symmetric difference logging When the on-disk and

[kudu-CR](branch-1.7.x) KUDU-2510 Fix symmetric difference logging

2018-07-30 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11033 ) Change subject: KUDU-2510 Fix symmetric difference logging .. KUDU-2510 Fix symmetric difference logging When the on-disk and

[kudu-CR](branch-1.7.x) KUDU-2510 Fix symmetric difference logging

2018-07-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11033 ) Change subject: KUDU-2510 Fix symmetric difference logging .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.6.x) KUDU-2510 Fix symmetric difference logging

2018-07-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11034 ) Change subject: KUDU-2510 Fix symmetric difference logging .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-07-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11077 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 1: (4 comments)

[kudu-CR] [docs] Add changing master hostnames workflow

2018-07-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11058 ) Change subject: [docs] Add changing master hostnames workflow .. Patch Set 2: (3 comments)

[kudu-CR] [kudu-admin-test] improvements on error reporting

2018-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11046 ) Change subject: [kudu-admin-test] improvements on error reporting .. Patch Set 3: Verified+1 Unrelated flakes in:

[kudu-CR] [kudu-admin-test] improvements on error reporting

2018-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11046 ) Change subject: [kudu-admin-test] improvements on error reporting .. [kudu-admin-test] improvements on error reporting This

[kudu-CR] [kudu-admin-test] improvements on error reporting

2018-07-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11046 ) Change subject: [kudu-admin-test] improvements on error reporting .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-07-30 Thread Anonymous Coward (Code Review)
jinxing6...@126.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11077 Change subject: [KUDU-2521] Java Implementation for BloomFilter .. [KUDU-2521] Java Implementation for BloomFilter Change-Id:

[kudu-CR] test

2018-07-30 Thread Anonymous Coward (Code Review)
jinxing6...@126.com has abandoned this change. ( http://gerrit.cloudera.org:8080/11076 ) Change subject: test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11076 To unsubscribe, visit

[kudu-CR] test

2018-07-30 Thread Anonymous Coward (Code Review)
jinxing6...@126.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11076 Change subject: test .. test Change-Id: Ia2e23eebda31743032e38c2f5c7c2a88ccdd2611 --- A test 1 file changed, 1 insertion(+), 0