[kudu-CR] KUDU-2528: thirdparty downloads should be more robust
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11152 ) Change subject: KUDU-2528: thirdparty downloads should be more robust .. KUDU-2528: thirdparty downloads should be more robust Commit 37f3a95d8 added --retry to our curl invocations, but it turns out that this only retries failures that curl deems to be "transient". And if curl exits with a non-zero status, the entire script grinds to a halt because of set -e. This patch expands the class of retriable errors by parking the curl statement in a pipeline, which means it is excused from set -e. After that, the existing fetch_and_expand retry loop takes over. Change-Id: Ic970afdb7ec23d3e04b2d7a9bf77d32774ca4d57 Reviewed-on: http://gerrit.cloudera.org:8080/11152 Reviewed-by: Alexey Serbin Tested-by: Kudu Jenkins Reviewed-by: Grant Henke --- M thirdparty/download-thirdparty.sh 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic970afdb7ec23d3e04b2d7a9bf77d32774ca4d57 Gerrit-Change-Number: 11152 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](gh-pages) Blog: Two minor tweeks to 'Getting Started with Kudu - an O'Reilly Title'
Jordan Birdsell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11167 ) Change subject: Blog: Two minor tweeks to 'Getting Started with Kudu - an O'Reilly Title' .. Blog: Two minor tweeks to 'Getting Started with Kudu - an O'Reilly Title' Change-Id: Ia53f8743488cd6eedd27b48352cdfb1c323d840e Reviewed-on: http://gerrit.cloudera.org:8080/11167 Reviewed-by: Jordan Birdsell Tested-by: Jordan Birdsell --- M _posts/2018-08-06-getting-started-with-kudu-an-oreilly-title.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jordan Birdsell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: merged Gerrit-Change-Id: Ia53f8743488cd6eedd27b48352cdfb1c323d840e Gerrit-Change-Number: 11167 Gerrit-PatchSet: 2 Gerrit-Owner: Brock Noland Gerrit-Reviewer: Jordan Birdsell
[kudu-CR](gh-pages) Blog: Two minor tweeks to 'Getting Started with Kudu - an O'Reilly Title'
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11167 ) Change subject: Blog: Two minor tweeks to 'Getting Started with Kudu - an O'Reilly Title' .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Ia53f8743488cd6eedd27b48352cdfb1c323d840e Gerrit-Change-Number: 11167 Gerrit-PatchSet: 1 Gerrit-Owner: Brock Noland Gerrit-Reviewer: Jordan Birdsell Gerrit-Comment-Date: Wed, 08 Aug 2018 18:54:29 + Gerrit-HasComments: No
[kudu-CR](gh-pages) Blog: Two minor tweeks to 'Getting Started with Kudu - an O'Reilly Title'
Brock Noland has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11167 Change subject: Blog: Two minor tweeks to 'Getting Started with Kudu - an O'Reilly Title' .. Blog: Two minor tweeks to 'Getting Started with Kudu - an O'Reilly Title' Change-Id: Ia53f8743488cd6eedd27b48352cdfb1c323d840e --- M _posts/2018-08-06-getting-started-with-kudu-an-oreilly-title.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/11167/1 -- To view, visit http://gerrit.cloudera.org:8080/11167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newchange Gerrit-Change-Id: Ia53f8743488cd6eedd27b48352cdfb1c323d840e Gerrit-Change-Number: 11167 Gerrit-PatchSet: 1 Gerrit-Owner: Brock Noland
[kudu-CR] Add support for Java dist-tests on Jenkins
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 ) Change subject: Add support for Java dist-tests on Jenkins .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a Gerrit-Change-Number: 10954 Gerrit-PatchSet: 8 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 08 Aug 2018 18:28:43 + Gerrit-HasComments: No
[kudu-CR] Add support for Java dist-tests on Jenkins
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10954 to look at the new patch set (#8). Change subject: Add support for Java dist-tests on Jenkins .. Add support for Java dist-tests on Jenkins Enables running the Java dist-tests on Jenkins when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1. It requires BUILD_GRADLE=1 because the Maven build doesn’t support dist-tests. Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a --- M build-support/dist_test.py M build-support/jenkins/build-and-test.sh M build-support/run_dist_test.py 3 files changed, 72 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/8 -- To view, visit http://gerrit.cloudera.org:8080/10954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a Gerrit-Change-Number: 10954 Gerrit-PatchSet: 8 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add error handling to Backup and Restore
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10941 to look at the new patch set (#15). Change subject: Add error handling to Backup and Restore .. Add error handling to Backup and Restore A backup/restore will be attempted on every,regardless of any one table failure. If any one table fails the job will exit with a non-zero code. If a table is successfully backed up in the current job or the table metadata has a timestamp equaling the user-supplied timestamp, the table will be marked successful. If a table fails to back up any partial data will be removed. If a table fails to restore and a restore Kudu table has already been created the `-restore` table will not be removed. This should probably be done in a later commit. A list of failed/success full backups or restores will be printed at the end of each job. Spark SaveMode overwrite/append semantics are not handled as part of this commit. Change-Id: I104fd604e12b70fcff9beace71ed4ef96b54d691 --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala 5 files changed, 384 insertions(+), 113 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/10941/15 -- To view, visit http://gerrit.cloudera.org:8080/10941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I104fd604e12b70fcff9beace71ed4ef96b54d691 Gerrit-Change-Number: 10941 Gerrit-PatchSet: 15 Gerrit-Owner: Tony Foerster Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tony Foerster
[kudu-CR] Add const attribute to RpcContext::GetInboundSidecar()
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11150 ) Change subject: Add const attribute to RpcContext::GetInboundSidecar() .. Add const attribute to RpcContext::GetInboundSidecar() Testing done: rpc-test Change-Id: Ie1d959c40aa119389b09c9f6ac2afe7445066a38 Reviewed-on: http://gerrit.cloudera.org:8080/11150 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11150 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie1d959c40aa119389b09c9f6ac2afe7445066a38 Gerrit-Change-Number: 11150 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add support for Java dist-tests on Jenkins
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 ) Change subject: Add support for Java dist-tests on Jenkins .. Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10954/7/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/10954/7/build-support/dist_test.py@542 PS7, Line 542: # TODO(Grant): Add Java tests to the flaky dashboard Nit: ghenke -- To view, visit http://gerrit.cloudera.org:8080/10954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a Gerrit-Change-Number: 10954 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 08 Aug 2018 17:20:28 + Gerrit-HasComments: Yes
[kudu-CR] Add support for Java dist-tests on Jenkins
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 ) Change subject: Add support for Java dist-tests on Jenkins .. Patch Set 6: I updated this patch to retry all Java tests. I also rebased and included a few small fixes based on changes since the original patch. -- To view, visit http://gerrit.cloudera.org:8080/10954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a Gerrit-Change-Number: 10954 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 08 Aug 2018 17:00:29 + Gerrit-HasComments: No
[kudu-CR] Add support for Java dist-tests on Jenkins
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10954 to look at the new patch set (#7). Change subject: Add support for Java dist-tests on Jenkins .. Add support for Java dist-tests on Jenkins Enables running the Java dist-tests on Jenkins when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1. It requires BUILD_GRADLE=1 because the Maven build doesn’t support dist-tests. Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a --- M build-support/dist_test.py M build-support/jenkins/build-and-test.sh M build-support/run_dist_test.py 3 files changed, 72 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/7 -- To view, visit http://gerrit.cloudera.org:8080/10954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a Gerrit-Change-Number: 10954 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) [site] Add http to https redirect
Hello Mike Percy, Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11162 to review the following change. Change subject: [site] Add http to https redirect .. [site] Add http to https redirect In the latest Chrome version all pages without TLS get a "Not Secure" tag in the address bar, so even as there's no secure information (e.g. passwords) transmitted to kudu.apache.org, http should redirect to https. Change-Id: Ic5a060a419466ec4b16840347d387262ca8a4199 --- M .htaccess 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/11162/1 -- To view, visit http://gerrit.cloudera.org:8080/11162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newchange Gerrit-Change-Id: Ic5a060a419466ec4b16840347d387262ca8a4199 Gerrit-Change-Number: 11162 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add support for Java dist-tests on Jenkins
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10954 to look at the new patch set (#6). Change subject: Add support for Java dist-tests on Jenkins .. Add support for Java dist-tests on Jenkins Enables running the Java dist-tests on Jenkins when ENABLE_DIST_TEST=1 and BUILD_GRADLE=1. It requires BUILD_GRADLE=1 because the Maven build doesn’t support dist-tests. Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a --- M build-support/dist_test.py M build-support/jenkins/build-and-test.sh 2 files changed, 70 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/10954/6 -- To view, visit http://gerrit.cloudera.org:8080/10954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I20105d3f12fd8c3f95d9fe30fe1b63138614041a Gerrit-Change-Number: 10954 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) [blog] Fix "Getting Started with Kudu" post
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11161 ) Change subject: [blog] Fix "Getting Started with Kudu" post .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I21e36c551597e9abd99d34d77be3df32f45f3fda Gerrit-Change-Number: 11161 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Brock Noland Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 08 Aug 2018 15:36:14 + Gerrit-HasComments: No
[kudu-CR](gh-pages) [blog] Fix "Getting Started with Kudu" post
Jordan Birdsell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11161 ) Change subject: [blog] Fix "Getting Started with Kudu" post .. [blog] Fix "Getting Started with Kudu" post Formatting was broken: - title was weird - lead and the rest of the post not separated - link to book broken Change-Id: I21e36c551597e9abd99d34d77be3df32f45f3fda Reviewed-on: http://gerrit.cloudera.org:8080/11161 Reviewed-by: Jordan Birdsell Tested-by: Jordan Birdsell --- M _posts/2018-08-06-getting-started-with-kudu-an-oreilly-title.md 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Jordan Birdsell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: merged Gerrit-Change-Id: I21e36c551597e9abd99d34d77be3df32f45f3fda Gerrit-Change-Number: 11161 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Brock Noland Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) [blog] Fix "Getting Started with Kudu" post
Hello Jordan Birdsell, Todd Lipcon, Brock Noland, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11161 to review the following change. Change subject: [blog] Fix "Getting Started with Kudu" post .. [blog] Fix "Getting Started with Kudu" post Formatting was broken: - title was weird - lead and the rest of the post not separated - link to book broken Change-Id: I21e36c551597e9abd99d34d77be3df32f45f3fda --- M _posts/2018-08-06-getting-started-with-kudu-an-oreilly-title.md 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11161/1 -- To view, visit http://gerrit.cloudera.org:8080/11161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newchange Gerrit-Change-Id: I21e36c551597e9abd99d34d77be3df32f45f3fda Gerrit-Change-Number: 11161 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Brock Noland Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add error handling to Backup and Restore
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10941 to look at the new patch set (#14). Change subject: Add error handling to Backup and Restore .. Add error handling to Backup and Restore A backup/restore will be attempted on every,regardless of any one table failure. If any one table fails the job will exit with a non-zero code. If a table is successfully backed up in the current job or the table metadata has a timestamp equaling the user-supplied timestamp, the table will be marked successful. If a table fails to back up any partial data will be removed. If a table fails to restore and a restore Kudu table has already been created the `-restore` table will not be removed. This should probably be done in a later commit. A list of failed/success full backups or restores will be printed at the end of each job. Spark SaveMode overwrite/append semantics are not handled as part of this commit. Change-Id: I104fd604e12b70fcff9beace71ed4ef96b54d691 --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala 5 files changed, 384 insertions(+), 116 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/10941/14 -- To view, visit http://gerrit.cloudera.org:8080/10941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I104fd604e12b70fcff9beace71ed4ef96b54d691 Gerrit-Change-Number: 10941 Gerrit-PatchSet: 14 Gerrit-Owner: Tony Foerster Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tony Foerster
[kudu-CR] [docs] Add changing master hostnames workflow
Hello Will Berkeley, Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11058 to look at the new patch set (#3). Change subject: [docs] Add changing master hostnames workflow .. [docs] Add changing master hostnames workflow Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03 --- M docs/administration.adoc 1 file changed, 74 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/11058/3 -- To view, visit http://gerrit.cloudera.org:8080/11058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0df87d5e294d8b7bf5c7b8f94a63599ffd7ebe03 Gerrit-Change-Number: 11058 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2528: thirdparty downloads should be more robust
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11152 ) Change subject: KUDU-2528: thirdparty downloads should be more robust .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic970afdb7ec23d3e04b2d7a9bf77d32774ca4d57 Gerrit-Change-Number: 11152 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 08 Aug 2018 14:35:00 + Gerrit-HasComments: No
[kudu-CR](gh-pages) Blog: Getting Started with Kudu
Jordan Birdsell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11136 ) Change subject: Blog: Getting Started with Kudu .. Blog: Getting Started with Kudu Change-Id: I9503dca5e6e565be902c4090bf2996bd1960d763 Reviewed-on: http://gerrit.cloudera.org:8080/11136 Reviewed-by: Jordan Birdsell Tested-by: Jordan Birdsell --- A _posts/2018-08-06-getting-started-with-kudu-an-oreilly-title.md A img/2018-08-06-getting-started-with-kudu-an-oreilly-title.gif 2 files changed, 60 insertions(+), 0 deletions(-) Approvals: Jordan Birdsell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: merged Gerrit-Change-Id: I9503dca5e6e565be902c4090bf2996bd1960d763 Gerrit-Change-Number: 11136 Gerrit-PatchSet: 6 Gerrit-Owner: Brock Noland Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Blog: Getting Started with Kudu
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11136 ) Change subject: Blog: Getting Started with Kudu .. Patch Set 5: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I9503dca5e6e565be902c4090bf2996bd1960d763 Gerrit-Change-Number: 11136 Gerrit-PatchSet: 5 Gerrit-Owner: Brock Noland Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 08 Aug 2018 14:25:01 + Gerrit-HasComments: No
[kudu-CR](gh-pages) Blog: Getting Started with Kudu
Hello Jordan Birdsell, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11136 to look at the new patch set (#5). Change subject: Blog: Getting Started with Kudu .. Blog: Getting Started with Kudu Change-Id: I9503dca5e6e565be902c4090bf2996bd1960d763 --- A _posts/2018-08-06-getting-started-with-kudu-an-oreilly-title.md A img/2018-08-06-getting-started-with-kudu-an-oreilly-title.gif 2 files changed, 60 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/11136/5 -- To view, visit http://gerrit.cloudera.org:8080/11136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9503dca5e6e565be902c4090bf2996bd1960d763 Gerrit-Change-Number: 11136 Gerrit-PatchSet: 5 Gerrit-Owner: Brock Noland Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Blog: Getting Started with Kudu
Hello Jordan Birdsell, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11136 to look at the new patch set (#4). Change subject: Blog: Getting Started with Kudu .. Blog: Getting Started with Kudu Change-Id: I9503dca5e6e565be902c4090bf2996bd1960d763 --- A _posts/2018-08-06-getting-started-with-kudu-an-oreilly-title.md A img/2018-08-06-getting-started-with-kudu-an-oreilly-title.gif 2 files changed, 60 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/11136/4 -- To view, visit http://gerrit.cloudera.org:8080/11136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9503dca5e6e565be902c4090bf2996bd1960d763 Gerrit-Change-Number: 11136 Gerrit-PatchSet: 4 Gerrit-Owner: Brock Noland Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11067 ) Change subject: KUDU-1291. Efficiently support predicates on non-prefix key components .. Patch Set 26: This should be abandoned in favor of https://gerrit.cloudera.org/c/10983/ since that is the change request that has all the review comment history. In order to post to the other one, you must put the following in the commit message: Change-Id: I230cd5a288e28ace796b352a603e0d1bcc1e4e0f Then click the "Abandon" button on this CR. -- To view, visit http://gerrit.cloudera.org:8080/11067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffbc240233e5ad52f6a1c7912d4e44baf32a5f2d Gerrit-Change-Number: 11067 Gerrit-PatchSet: 26 Gerrit-Owner: Anupama Gupta Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 08 Aug 2018 11:44:31 + Gerrit-HasComments: No
[kudu-CR] consensus: atomicize timestamp/opid assignment
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11144 to look at the new patch set (#3). Change subject: consensus: atomicize timestamp/opid assignment .. consensus: atomicize timestamp/opid assignment This patch atomicizes timestamp assignment with respect to OpIds by moving the assignment of timestamps into the RaftConsensus module, right before operations are appended to the consensus queue to be sent to the peers. This patch adds test cases for timestamp serialization: 1. a test that writes data while triggering many change configs 2. a test that writes data while barraging the PingConsensus endpoint to replicate a no-op, circumventing any kind of serialization Change-Id: Id347847d117509b0eadedcb4117b4e781f6e3654 --- M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/raft_consensus.cc M src/kudu/integration-tests/timestamp_serialization-itest.cc M src/kudu/tablet/transactions/transaction_driver.cc 4 files changed, 168 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/11144/3 -- To view, visit http://gerrit.cloudera.org:8080/11144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id347847d117509b0eadedcb4117b4e781f6e3654 Gerrit-Change-Number: 11144 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] wip consensus: add RPC to replicate a NO OP
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11143 to look at the new patch set (#2). Change subject: wip consensus: add RPC to replicate a NO_OP .. wip consensus: add RPC to replicate a NO_OP This patch adds an RPC to replicate a NO_OP message. Unlike NO_OPs that get sent following leader elections, these NO_OPs do not have any guarantees regarding the monotonicity of their timestamps with respect to other operations. In addition to being a nice tool to check that consensus is running on a given server for a given tablet, this endpoint is useful in stressing the assignment of timestamps for non-txn operations. Pinging consensus on a leader will replicate It's important to be able to determine whether or not a NO_OP message was created using this endpoint directly, vs through the normal flow of Raft's election algorithm, as timestamps assigned in the former are serialized with respect to writes in the term the NO_OP was sent. As such, a field has been added to the NoOpRequestPB indicating whether the NO_OP was sent via this RPC or not. WIP: would like to add more targetted testing Change-Id: If98292503dc81cdd1290f1d96d8b4229ae56224f --- M src/kudu/consensus/consensus.proto M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h 5 files changed, 95 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/11143/2 -- To view, visit http://gerrit.cloudera.org:8080/11143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If98292503dc81cdd1290f1d96d8b4229ae56224f Gerrit-Change-Number: 11143 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1291. Efficiently support predicates on non-prefix key components
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10983 )
Change subject: KUDU-1291. Efficiently support predicates on non-prefix key
components
..
Patch Set 13:
(13 comments)
Went through a few more files; leaving what I have so far.
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/cfile/cfile_reader.h
File src/kudu/cfile/cfile_reader.h:
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/cfile/cfile_reader.h@345
PS12, Line 345: bool set_current_value
nit: Even though this is calling StoreCurrentValue(), I think calling this
`cache_seeked_value` makes it this a bit clearer.
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/cfile/cfile_reader.h@472
PS12, Line 472: // Value currently pointed to by validx_iter_.
: // Currently, it is assumed that
CFileSet::Iterator::SkipToNextScan(size_t *remaining)
: // has exclusive access to use this variable.
> Any chance to make update this to keep better level of encapsulation?
+1
I might be missing something, but would we be able to only have a single public
function GetCurrentValue() that does what StoreCurrentValue() does, but has a
string as an outparameter? Not sure if this would yield the different results
than if we were to continue storing via 'set_current_value'.
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.h
File src/kudu/tablet/cfile_set.h:
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.h@213
PS12, Line 213: // 'cache_seeked_value' controls whether we will remember the
next key seeked to in
: // this function.
nit: Reword as "If `cache_seeked_value` is true, the predicate column iterator
will store the value seeked to.
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.h@220
PS12, Line 220: // Builds a key containing the current prefix key, predicate
column value
: // and the minimum value for rest of the key columns.
nit: reword as "Build the key with the same prefix as `cur_enc_key`, that has
`skip_scan_predicate_value_` in its predicate column, and the minimum possible
value for all other columns.
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.cc
File src/kudu/tablet/cfile_set.cc:
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.cc@436
PS12, Line 436:
nit: this can just be `spec.predicates()`, then there would be no need for a
`predicates` var
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.cc@440
PS12, Line 440: const string& col_name = col_and_pred.first;
nit: move this out of the loop, maybe up by L413 and then use it in defining
num_key_cols.
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.cc@462
PS12, Line 462: }
:
: if (nonfirst_key_pred_exists) {
: use_skip_scan_ = true;
:
: // Store the predicate column id.
: skip_scan_predicate_column_id_ = min_col_id;
:
:
> nit: why not to move this under the same scope where the nonfirst_key_pred_
It was originally written as described, but I asked her to make the change,
reason being it seems a bit off to update these variables if we end up
disabling the skip scan. Not sure my concern is important, since these
variables (I think) are unused if we're not skip-scanning. I'd be ok reverting
if you prefer, but I agree the semantics should be updated.
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.cc@551
PS12, Line 551:
: Status CFileSet::Iterator::SeekToNextPrefixKey(size_t
num_prefix_cols, bool cache_seeked_value) {
: gscoped_ptr enc_key;
Hmm.. This is doing a lot of heap-allocating and gets called _very often_. I
wonder if we could keep a single Arena or unique_ptr as a member of the
iterator, though I'm not sure our Arena implementation is reusable in that
way. Might be worth looking into if you notice high memory usage in your
cluster testing
http://gerrit.cloudera.org:8080/#/c/10983/12/src/kudu/tablet/cfile_set.cc@561
PS12, Line 561: _key, , num_prefix_cols));
:
: if (!cache_seeked_value) {
: return key_iter_->SeekAtOrAfter(*enc_key,
: /* set_current_value= */ cache_seeked_value,
: /* exact_match= */ nullptr);
: }
:
: // Set the predicate column to the predicate value in case we
can find a
: // predicate match in one search. As a side effect,
GetKeyWithPredicateVal()
: // sets minimum values on the columns after the predicate
value, which is
: // required for correctness here.
: KuduPartialRow partial_row(&(base_data_->tablet_schema()));
