[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size

2018-09-17 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/10406 ) Change subject: KUDU-2437 Split a tablet into primary key ranges by size .. Patch Set 23: (2 comments) Hi, Adar Dembo Thanks for review. I

[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size

2018-09-17 Thread Yao Xu (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10406 to look at the new patch set (#23). Change subject: KUDU-2437 Split a tablet into primary key ranges by size

[kudu-CR] clang tidy gerrit.py: fix output when no changes found in first path

2018-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11457 ) Change subject: clang_tidy_gerrit.py: fix output when no changes found in first path .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [hms] relax the notification format restriction

2018-09-17 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11460 Change subject: [hms] relax the notification format restriction .. [hms] relax the notification format restriction 'messageFormat' is an

[kudu-CR] [docs] minor cleanup on multi-master migration doc

2018-09-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11458 ) Change subject: [docs] minor cleanup on multi-master migration doc .. [docs] minor cleanup on multi-master migration doc

[kudu-CR] clang tidy gerrit.py: fix output when no changes found in first path

2018-09-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11457 ) Change subject: clang_tidy_gerrit.py: fix output when no changes found in first path .. Patch Set 1: Code-Review+2 Good catch! --

[kudu-CR] [docs] minor cleanup on multi-master migration doc

2018-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11458 ) Change subject: [docs] minor cleanup on multi-master migration doc .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] clang tidy gerrit.py: fix output when no changes found in first path

2018-09-17 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11457 to review the following change. Change subject: clang_tidy_gerrit.py: fix output when no changes found in first path

[kudu-CR] [docs] minor cleanup on multi-master migration doc

2018-09-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11458 Change subject: [docs] minor cleanup on multi-master migration doc .. [docs] minor cleanup on multi-master migration doc

[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size

2018-09-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10406 ) Change subject: KUDU-2437 Split a tablet into primary key ranges by size .. Patch Set 22: (2 comments) Looks good, just two more nits.

[kudu-CR] KUDU-2580 [c++ client] authn token reacquisition fix

2018-09-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11449 ) Change subject: KUDU-2580 [c++ client] authn token reacquisition fix .. Patch Set 1: (1 comment)

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 8: Code-Review+2 Looks good! Thank you for the post!

[kudu-CR] [docs] Add basic advice on setting block cache size

2018-09-17 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11420 ) Change subject: [docs] Add basic advice on setting block cache size .. [docs] Add basic advice on setting block cache size

[kudu-CR] [docs] Add basic advice on setting block cache size

2018-09-17 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11420 ) Change subject: [docs] Add basic advice on setting block cache size .. Patch Set 3: (1 comment)

[kudu-CR] [docs] Add basic advice on setting block cache size

2018-09-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11420 ) Change subject: [docs] Add basic advice on setting block cache size .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-09-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Patch Set 4: (5 comments) I think we should

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-09-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11394 ) Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer .. Patch Set 4: (6 comments)