[kudu-CR] ][DOCS] Added a version notice for changing managed Kudu table names in Impala
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11515 to look at the new patch set (#2). Change subject: ][DOCS] Added a version notice for changing managed Kudu table names in Impala .. ][DOCS] Added a version notice for changing managed Kudu table names in Impala With IMPALA-5654, users cannot change kudu.table_name in IMPALA for managed Kudu tables created in Impala. Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928 --- M docs/kudu_impala_integration.adoc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/11515/2 -- To view, visit http://gerrit.cloudera.org:8080/11515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928 Gerrit-Change-Number: 11515 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] ][DOCS] Added a version notice for changing managed Kudu table names in Impala
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 ) Change subject: ][DOCS] Added a version notice for changing managed Kudu table names in Impala .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG@9 PS1, Line 9: With IMPALA-5654, users cannot change kudu.table_name in IMPALA. > I think this is too generic and incorrect: for external tables, they still Done http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@687 PS1, Line 687: if the table is an internal table > The enclosed section is named Done http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@697 PS1, Line 697: In Impala 2.11 and lower, if another application has renamed a Kudu table under : Impala, it is possible to re-map an external table to point to a different Kudu : table name. > I meant: ... That it's impossible to re-map an external table to a differe Version note removed http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@697 PS1, Line 697: In Impala 2.11 and lower, if another application has renamed a Kudu table under : Impala, it is possible to re-map an external table to point to a different Kudu : table name. > I think this became confusing. What's the extra 'In Impala 2.11 and lower Done -- To view, visit http://gerrit.cloudera.org:8080/11515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928 Gerrit-Change-Number: 11515 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 26 Sep 2018 00:59:00 + Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Added a version notice for changing kudu table names in Impala
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 ) Change subject: [DOCS] Added a version notice for changing kudu table names in Impala .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@697 PS1, Line 697: In Impala 2.11 and lower, if another application has renamed a Kudu table under : Impala, it is possible to re-map an external table to point to a different Kudu : table name. > I think this became confusing. What's the extra 'In Impala 2.11 and lower I meant: ... That it's impossible to re-map an external table to a different Kudu table or that another application is not able to rename a Kudu table under Impala starting with Impala version 2.12? -- To view, visit http://gerrit.cloudera.org:8080/11515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928 Gerrit-Change-Number: 11515 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 26 Sep 2018 00:43:05 + Gerrit-HasComments: Yes
[kudu-CR] Supporting Spark streaming DataFrame in KuduContext.
Attila Piros has posted comments on this change. (
http://gerrit.cloudera.org:8080/11199 )
Change subject: Supporting Spark streaming DataFrame in KuduContext.
..
Patch Set 5:
> Patch Set 5:
>
> (1 comment)
In case of structured streaming foreachPartition on a streaming DataFrame is an
unsupported operation. You can see this error running the new test without my
KuduContext changes:
> Task :kudu-spark:test
org.apache.kudu.spark.kudu.StreamingTest > testKuduContextWithSparkStreaming
FAILED
org.apache.spark.sql.streaming.StreamingQueryException: Queries with
streaming sources must be executed with writeStream.start();;
LocalRelation [value#16]
=== Streaming Query ===
Identifier: [id = f00274e4-469e-43fd-8d9a-3e42f81125a3, runId =
35f66191-e282-4112-b226-26cd2b0c6fae]
Current Committed Offsets: {}
Current Available Offsets: {MemoryStream[value#1]: 0}
Current State: ACTIVE
Thread State: RUNNABLE
Logical Plan:
Project [_1#7 AS key#10, _2#8 AS val#11]
+- SerializeFromObject [assertnotnull(assertnotnull(input[0, scala.Tuple2,
true]))._1 AS _1#7, staticinvoke(class
org.apache.spark.unsafe.types.UTF8String, StringType, fromString,
assertnotnull(assertnotnull(input[0, scala.Tuple2, true]))._2, true, false) AS
_2#8]
+- MapElements , int, [StructField(value,IntegerType,false)],
obj#6: scala.Tuple2
+- DeserializeToObject assertnotnull(cast(value#1 as int)), obj#5: int
+- StreamingExecutionRelation MemoryStream[value#1], [value#1]
Caused by:
org.apache.spark.sql.AnalysisException: Queries with streaming sources
must be executed with writeStream.start();;
LocalRelation [value#16]
1 test completed, 1 failed
> Task :kudu-spark:test FAILED
~~~
So this solution uses the same method as was used for KafkaSink: using
foreachPartition on RDD-level. Basically it is a workaround.
--
To view, visit http://gerrit.cloudera.org:8080/11199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iead04539d3514920a5d6803c34715e5686124572
Gerrit-Change-Number: 11199
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Piros
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Attila Piros
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 26 Sep 2018 00:42:12 +
Gerrit-HasComments: No
[kudu-CR] [DOCS] Added a version notice for changing kudu table names in Impala
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 ) Change subject: [DOCS] Added a version notice for changing kudu table names in Impala .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG@9 PS1, Line 9: With IMPALA-5654, users cannot change kudu.table_name in IMPALA. I think this is too generic and incorrect: for external tables, they still can do that even with IMPALA-5654. IMPALA-5654 affects only internal (a.k.a. managed) tables. http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@687 PS1, Line 687: if the table is an internal table The enclosed section is named 'Rename the underlying Kudu table for an internal table' So, I don't think this extra is needed here. http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@697 PS1, Line 697: In Impala 2.11 and lower, if another application has renamed a Kudu table under : Impala, it is possible to re-map an external table to point to a different Kudu : table name. I think this became confusing. What's the extra 'In Impala 2.11 and lower ...' is supposed to mean? That it's impossible to re-map an external table to a different Kudu table or that another application is not able to rename a Kudu table under Impala? As I understand, even in Impala 2.12 and newer it's still possible to re-map an external table to point to a different Kudu table name, i.e. IMPALA-5654 is about internal or managed tables only. -- To view, visit http://gerrit.cloudera.org:8080/11515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928 Gerrit-Change-Number: 11515 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 26 Sep 2018 00:41:25 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11395 to look at the new patch set (#7). Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator This patch rewrites much of DeltaFileIterator to leverage DeltaPreparer. Besides sharing code, the motivation is to take advantage of the performance improvement inherent to DeltaPreparer: decoding a batch of deltas just once in PrepareBatch() as opposed to on each call to ApplyUpdates(). Seeing as DeltaPreparer was originally built for DMSIterator, here are the various augmentations that were necessary to support DeltaFileIterator: - REINSERT support, which meant more complicated deletion state tracking. - FilterColumnIdsAndCollectDeltas support, cribbed from DeltaFileIterator. - A templatized traits system to control which features were enabled. This also meant templatizing both DeltaPreparer and DeltaFileIterator. - Early out from the "apply all deltas for a row" loop when the timestamp is no longer relevant. There's an opportunity to seek here and skip any remaining deltas belonging to the row, but testing with a new DMS iterator microbenchmark showed that this is only an improvement when the number of deltas skipped is sufficiently high. The improvement should be most noticeable on tables with wide schemas where multiple columns are projected. In these situations, the column-by-column ApplyUpdates() approach incurred a lot of unnecessary delta decoding. To prove it, I included a new deltafile iterator microbenchmark that scans a subset of a wide schema's columns as a DeltaApplier would. Before: Performance counter stats for 'bin/deltafile-test --gtest_filter=*Benchmark*' (5 runs): 11358.256100 task-clock (msec) #0.998 CPUs utilized ( +- 3.39% ) 140 context-switches #0.012 K/sec ( +- 27.37% ) 6 cpu-migrations#0.001 K/sec ( +- 52.36% ) 34,231 page-faults #0.003 M/sec ( +- 0.42% ) 42,288,292,153 cycles#3.723 GHz ( +- 4.12% ) 100,853,942,114 instructions #2.38 insn per cycle ( +- 5.35% ) 19,689,789,259 branches # 1733.522 M/sec ( +- 5.49% ) 69,419,478 branch-misses #0.35% of all branches ( +- 5.14% ) 11.378958537 seconds time elapsed ( +- 3.38% ) After: Performance counter stats for 'bin/deltafile-test --gtest_filter=*Benchmark*' (5 runs): 4089.419224 task-clock (msec) #0.995 CPUs utilized ( +- 1.25% ) 43 context-switches #0.011 K/sec ( +- 4.10% ) 2 cpu-migrations#0.000 K/sec ( +- 32.39% ) 34,948 page-faults #0.009 M/sec ( +- 0.22% ) 15,269,907,971 cycles#3.734 GHz ( +- 1.30% ) 32,409,048,370 instructions #2.12 insn per cycle ( +- 1.85% ) 5,848,268,795 branches # 1430.098 M/sec ( +- 1.85% ) 32,900,262 branch-misses #0.56% of all branches ( +- 2.80% ) 4.111096224 seconds time elapsed ( +- 1.18% ) It's interesting to see the number of page faults increase while everything else has gone down, but that makes sense: the new implementation allocates memory in PrepareBatch() in order to optimize the structure of the deltas. Change-Id: I87de52092262c4b42c1bd5107f9139edfc3888b5 --- M src/kudu/tablet/delta_key.h M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltafile.cc M src/kudu/tablet/deltafile.h M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/deltamemstore.cc M src/kudu/tablet/deltamemstore.h M src/kudu/tablet/mvcc.cc M src/kudu/tablet/mvcc.h M src/kudu/tablet/tablet-test-util.h 12 files changed, 604 insertions(+), 402 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/11395/7 -- To view, visit http://gerrit.cloudera.org:8080/11395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I87de52092262c4b42c1bd5107f9139edfc3888b5 Gerrit-Change-Number: 11395 Gerrit-PatchSet: 7 Gerrit-Owner: Adar Dembo
[kudu-CR] deltas: fuzz tests for delta file and dms
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11140 to look at the new patch set (#11). Change subject: deltas: fuzz tests for delta file and dms .. deltas: fuzz tests for delta file and dms Here are new fuzz tests for deltafile-test and deltamemstore-test that generate random deltas and iterate over them using random snapshots, testing the various delta iterator functions. I found this to be a simpler environment in which to debug delta-related issues, vs. more heavy-weight tests (i.e. fuzz-itest). The test introduces MirroredDeltas, a utility that's useful for tracking deltas that are written into a delta file or DMS. Change-Id: I539ff0f2055cf398a42efb824238188230e25516 --- M src/kudu/tablet/CMakeLists.txt M src/kudu/tablet/delta_key.h M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/deltamemstore.cc A src/kudu/tablet/tablet-test-util.cc M src/kudu/tablet/tablet-test-util.h 8 files changed, 768 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11140/11 -- To view, visit http://gerrit.cloudera.org:8080/11140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I539ff0f2055cf398a42efb824238188230e25516 Gerrit-Change-Number: 11140 Gerrit-PatchSet: 11 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] tserver: log a message when a scanner is not found
Mike Percy has uploaded this change for review. (
http://gerrit.cloudera.org:8080/11516
Change subject: tserver: log a message when a scanner is not found
..
tserver: log a message when a scanner is not found
Right now there is a class of issues where an "upstream" service or
query engine such as Impala or Spark may not be able to find a Kudu
scanner, resulting in a failed query. Often, this is because the scanner
timed out. The query engine will receive and typically log a message
indicating that the scanner could not be found, however it's difficult
to trace this back to the original query because the client wouldn't
know the scanner id and the server would not log the event.
With this change, it will be much easier to match up query engine
failures with expiring scanners by looking at the logs on both sides
because when a request comes in for a scanner that cannot be found, the
client will get a bad status like so:
Not found: Scanner f87cc39d55d24c52bcf547f211e46b8b not found (it may have
expired)
And the server will log a slightly more verbose message like:
I0925 15:29:38.875579 22293 tablet_service.cc:2017] Not found: Scanner
f87cc39d55d24c52bcf547f211e46b8b not found (it may have expired): call
sequence id=1, remote={username='mpercy'} at 127.0.0.1:57118
Change-Id: If4e9c69160605d4a839ac2d28def67f4d3402b90
---
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
3 files changed, 22 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/11516/1
--
To view, visit http://gerrit.cloudera.org:8080/11516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4e9c69160605d4a839ac2d28def67f4d3402b90
Gerrit-Change-Number: 11516
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy
[kudu-CR] [DOCS] Added a version notice for changing kudu table names in Impala
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11515 Change subject: [DOCS] Added a version notice for changing kudu table names in Impala .. [DOCS] Added a version notice for changing kudu table names in Impala With IMPALA-5654, users cannot change kudu.table_name in IMPALA. Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928 --- M docs/kudu_impala_integration.adoc 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/11515/1 -- To view, visit http://gerrit.cloudera.org:8080/11515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928 Gerrit-Change-Number: 11515 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11510 ) Change subject: java: improve assertion failure message in TestAsyncKuduSession.test .. Patch Set 1: Verified+1 overriding unrelated flaky test failure -- To view, visit http://gerrit.cloudera.org:8080/11510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04 Gerrit-Change-Number: 11510 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 25 Sep 2018 21:42:08 + Gerrit-HasComments: No
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11510 ) Change subject: java: improve assertion failure message in TestAsyncKuduSession.test .. java: improve assertion failure message in TestAsyncKuduSession.test This test is fairly flaky (tracked in KUDU-1521) and while I don't have time to fix the underlying issue I want to make it easier to track this in the future. Instead of just throwing a base AssertionError, it will now throw an error indicating that it failed because it was expecting a PleaseThrottleException that never appeared. Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04 Reviewed-on: http://gerrit.cloudera.org:8080/11510 Reviewed-by: Adar Dembo Tested-by: Mike Percy --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Mike Percy: Verified -- To view, visit http://gerrit.cloudera.org:8080/11510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04 Gerrit-Change-Number: 11510 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Mike Percy has removed a vote on this change. Change subject: java: improve assertion failure message in TestAsyncKuduSession.test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04 Gerrit-Change-Number: 11510 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11391 ) Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f Gerrit-Change-Number: 11391 Gerrit-PatchSet: 5 Gerrit-Owner: Ferenc Szabo Gerrit-Reviewer: Ferenc Szabo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 25 Sep 2018 21:35:03 + Gerrit-HasComments: No
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11391 ) Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer. .. KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer. Adding new properties for the different parsing error policies. Deprecating the old ones. Default value constants are not removed as they are public variables on a public class and it would be an API change. Adding new test class to test the configuration and behaviour. Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f Reviewed-on: http://gerrit.cloudera.org:8080/11391 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java 2 files changed, 393 insertions(+), 21 deletions(-) Approvals: Kudu Jenkins: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f Gerrit-Change-Number: 11391 Gerrit-PatchSet: 6 Gerrit-Owner: Ferenc Szabo Gerrit-Reviewer: Ferenc Szabo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [tools] Fix bug in CheckCompleteMove
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11508 ) Change subject: [tools] Fix bug in CheckCompleteMove .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11508/1/src/kudu/tools/tool_replica_util.cc File src/kudu/tools/tool_replica_util.cc: http://gerrit.cloudera.org:8080/#/c/11508/1/src/kudu/tools/tool_replica_util.cc@287 PS1, Line 287: nd the : // replica-to-be-removed has stepped down as leader That's not the only case we need to handle here right? The replica-to-be-removed might be a follower replica at this point, no? http://gerrit.cloudera.org:8080/#/c/11508/1/src/kudu/tools/tool_replica_util.cc@291 PS1, Line 291: to_ts_uuid_is_a_voter I think additional !from_ts_uuid_in_config condition is missing here. If from the procedural perspective there is nothing to do in case of the 3-4-3 replica management scheme, this function should still report on successful completion only when the the source replica is gone from the tablet configuration. -- To view, visit http://gerrit.cloudera.org:8080/11508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I227b8f833e8904dd1ac18fbe17345bea13c96c16 Gerrit-Change-Number: 11508 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 25 Sep 2018 21:29:45 + Gerrit-HasComments: Yes
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11510 ) Change subject: java: improve assertion failure message in TestAsyncKuduSession.test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04 Gerrit-Change-Number: 11510 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 25 Sep 2018 20:24:24 + Gerrit-HasComments: No
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11510 Change subject: java: improve assertion failure message in TestAsyncKuduSession.test .. java: improve assertion failure message in TestAsyncKuduSession.test This test is fairly flaky (tracked in KUDU-1521) and while I don't have time to fix the underlying issue I want to make it easier to track this in the future. Instead of just throwing a base AssertionError, it will now throw an error indicating that it failed because it was expecting a PleaseThrottleException that never appeared. Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04 --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11510/1 -- To view, visit http://gerrit.cloudera.org:8080/11510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04 Gerrit-Change-Number: 11510 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy
[kudu-CR] Supporting Spark streaming DataFrame in KuduContext.
Grant Henke has posted comments on this change. (
http://gerrit.cloudera.org:8080/11199 )
Change subject: Supporting Spark streaming DataFrame in KuduContext.
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11199/5/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:
http://gerrit.cloudera.org:8080/#/c/11199/5/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@305
PS5, Line 305: data.queryExecution.toRdd.foreachPartition(iterator => {
I don't fully understand why this is needed. Especially given that we convert
back from and InternalRow to a Row below in writePartitionRows.
My Spark internal background isn't the strongest. Could you explain what this
conversion fixes?
--
To view, visit http://gerrit.cloudera.org:8080/11199
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iead04539d3514920a5d6803c34715e5686124572
Gerrit-Change-Number: 11199
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Piros
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Attila Piros
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 25 Sep 2018 18:42:12 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2245 Graceful leadership transfer
Hello Fengling Wang, Tidy Bot, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11251 to look at the new patch set (#12). Change subject: KUDU-2245 Graceful leadership transfer .. KUDU-2245 Graceful leadership transfer This patch implements graceful leadership transfer, as described in the original Raft thesis. It has the following steps: 1. An admin client sends a request to the tablet leader for it to transfer leadership. The client can indicate a specific voter that it wants to become the leader, or it can allow the current leader to choose its successor. 2. The leader receives the request and beings a leader transfer period. During a leader transfer period, the leader does not accept writes or config change requests. This allows followers to catch up to the leader. A background timer expires the transfer period after one election timeout, since clients should be able to ride over interruptions in service lasting at least that long. 3. During the transfer period, the leader continues to update peers. When it receives a response from a peer, it checks if that peer is a voter and fully caught up to the leader's log. If it is, and if it is the designated successor if one was provided, the leader signals the peer to start an election, which it should win. If no eligible successor appears, the transfer period expires and the leader resumes normal operation. This is an improvement over the current leader step down method, which causes the leader to simply relinquish leadership and snooze its election timer for an extra long period, so another voter will likely become leader. Leadership transfer should usually be much faster and it allows the client to select the new leader among current voters. However, note that it does not provide strictly better guarantees- it is still possible that leadership will not be transferred. I ran TestRepeatLeaderStepDown and TestGracefulLeaderStepDown 1000 times and 200 times each, in debug and TSAN modes, with 4 stress threads, and saw no failures. Change-Id: Ic97343af9eb349556424c999799ed5e2941f0083 --- M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_peers.cc M src/kudu/consensus/consensus_peers.h M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/peer_manager.cc M src/kudu/consensus/peer_manager.h M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_tablet.cc M src/kudu/tools/tool_replica_util.cc M src/kudu/tools/tool_replica_util.h M src/kudu/tserver/tablet_service.cc 17 files changed, 817 insertions(+), 57 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/11251/12 -- To view, visit http://gerrit.cloudera.org:8080/11251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic97343af9eb349556424c999799ed5e2941f0083 Gerrit-Change-Number: 11251 Gerrit-PatchSet: 12 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Fengling Wang Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] [tools] Fix bug in CheckCompleteMove
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11508 Change subject: [tools] Fix bug in CheckCompleteMove .. [tools] Fix bug in CheckCompleteMove It was possible for the following sequence to happen: 0. We are moving a replica from TS X to TS Y for tablet A. TS X is presently the leader. 1. We find the tablet leader (X) and build a proxy to it. 2. To remove X from A, we ask it to step down. 3. Leadership changes quickly and Z != X becomes the leader. 4. Since leadership has changed, we move to remove X from A. To prepare we gather consensus state using proxy, thinking we are talking to Z, but the proxy is pointed at X, causing a bad status like Invalid argument: GetConsensusState: Wrong destination UUID requested. Local UUID: X. Requested UUID: Z This bug has always been present but was exposed by the follow-up graceful leadership transfer patch, since #3 was unlikely with abrupt stepdown, and if CheckCompleteMove was retried after leadership changed it would not hit the same problem. This also reorganizes and re-comments CheckCompleteMove a bit, to try and make it easier to understand. Change-Id: I227b8f833e8904dd1ac18fbe17345bea13c96c16 --- M src/kudu/tools/tool_replica_util.cc 1 file changed, 69 insertions(+), 37 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/11508/1 -- To view, visit http://gerrit.cloudera.org:8080/11508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I227b8f833e8904dd1ac18fbe17345bea13c96c16 Gerrit-Change-Number: 11508 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley
[kudu-CR] [tablet server-test] cleaner exit-on-failure in TestStatus
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11506 ) Change subject: [tablet_server-test] cleaner exit-on-failure in TestStatus .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11506/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11506/1//COMMIT_MSG@15 PS1, Line 15: : As for the reason behind the failure on restart, the mini tablet : server might fail to restart if one the ports it tries to bind to : is used by another process. > Yes, this unfortunate bit is tracked in https://issues.apache.org/jira/brow Thank you for the reference. Indeed, that's exactly how the failure manifested itself when I looked at it. I think this fix will save some time and allow the test to fail faster in such cases. -- To view, visit http://gerrit.cloudera.org:8080/11506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c5efef9e579f6fd357357517c32a26440896967 Gerrit-Change-Number: 11506 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Comment-Date: Tue, 25 Sep 2018 18:14:02 + Gerrit-HasComments: Yes
[kudu-CR] [tablet server-test] cleaner exit-on-failure in TestStatus
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11506 ) Change subject: [tablet_server-test] cleaner exit-on-failure in TestStatus .. [tablet_server-test] cleaner exit-on-failure in TestStatus Updated the TestStatus scenario of the TabletServerTest to terminate cleaner and faster in case of a failure when restarting tablet server. Prior to this fix, when the mini tablet server fails to restart, the test scenario would run indefinitely or until some higher-level test framework terminates the tablet_server-test process. As for the reason behind the failure on restart, the mini tablet server might fail to restart if one the ports it tries to bind to is used by another process. Change-Id: I7c5efef9e579f6fd357357517c32a26440896967 Reviewed-on: http://gerrit.cloudera.org:8080/11506 Tested-by: Alexey Serbin Reviewed-by: Adar Dembo --- M src/kudu/tserver/tablet_server-test.cc 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Alexey Serbin: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7c5efef9e579f6fd357357517c32a26440896967 Gerrit-Change-Number: 11506 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin
[kudu-CR] Add Hive Metastore service principal configuration
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11503 ) Change subject: Add Hive Metastore service principal configuration .. Add Hive Metastore service principal configuration This commit adds a new flag, --hive_metastore_kerberos_principal flag which corresponds to the HMS 'hive.metastore.kerberos.principal' configuration. This configuration is rarely overridden, but in cases where it is, having a way to match it in Kudu is critical. Change-Id: I6c5c56423a62cba0b696f97d866077b35845ce26 Reviewed-on: http://gerrit.cloudera.org:8080/11503 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/hms/hms_client-test.cc M src/kudu/integration-tests/master_hms-itest.cc M src/kudu/mini-cluster/external_mini_cluster-test.cc M src/kudu/thrift/client.cc M src/kudu/thrift/client.h M src/kudu/thrift/sasl_client_transport.cc M src/kudu/thrift/sasl_client_transport.h M src/kudu/tools/kudu-tool-test.cc 10 files changed, 36 insertions(+), 7 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6c5c56423a62cba0b696f97d866077b35845ce26 Gerrit-Change-Number: 11503 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add Hive Metastore service principal configuration
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11503 ) Change subject: Add Hive Metastore service principal configuration .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c5c56423a62cba0b696f97d866077b35845ce26 Gerrit-Change-Number: 11503 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 25 Sep 2018 17:12:02 + Gerrit-HasComments: No
[kudu-CR] [tablet server-test] cleaner exit-on-failure in TestStatus
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11506 ) Change subject: [tablet_server-test] cleaner exit-on-failure in TestStatus .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11506/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11506/1//COMMIT_MSG@15 PS1, Line 15: : As for the reason behind the failure on restart, the mini tablet : server might fail to restart if one the ports it tries to bind to : is used by another process. Yes, this unfortunate bit is tracked in https://issues.apache.org/jira/browse/KUDU-2431. -- To view, visit http://gerrit.cloudera.org:8080/11506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c5efef9e579f6fd357357517c32a26440896967 Gerrit-Change-Number: 11506 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Comment-Date: Tue, 25 Sep 2018 17:10:24 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11391 to look at the new patch set (#5). Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer. .. KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer. Adding new properties for the different parsing error policies. Deprecating the old ones. Default value constants are not removed as they are public variables on a public class and it would be an API change. Adding new test class to test the configuration and behaviour. Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f --- M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java A java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java 2 files changed, 393 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/11391/5 -- To view, visit http://gerrit.cloudera.org:8080/11391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f Gerrit-Change-Number: 11391 Gerrit-PatchSet: 5 Gerrit-Owner: Ferenc Szabo Gerrit-Reviewer: Ferenc Szabo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.
Ferenc Szabo has posted comments on this change. (
http://gerrit.cloudera.org:8080/11391 )
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp
operations producer.
..
Patch Set 4:
(2 comments)
Thanks for the reviews!
See my comments below.
http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
File
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java:
http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java@364
PS3, Line 364: default:
> Should a runtime exception be thrown if no policy is defined?
only a valid ParseErrorPolicy can come out from
getParseErrorPolicyCheckingDeprecatedProperty() so this default case is only
for checkstyle
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
File
java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java:
http://gerrit.cloudera.org:8080/#/c/11391/4/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java@66
PS4, Line 66: public void testMissingColumnThrowsExceptionDeprecated() throws
Exception {
: Context additionalContext = new Context();
: additionalContext.put(PATTERN_PROP,
TEST_REGEXP_MISSING_COLUMN);
: additionalContext.put(SKIP_MISSING_COLUMN_PROP,
String.valueOf(false));
: testThrowsException(additionalContext,
ERROR_MSG_MISSING_COLUMN, ROW_MISSING_COLUMN);
: }
:
: @Test
: public void testMissingColumnThrowsException() throws Exception
{
: Context additionalContext = new Context();
: additionalContext.put(PATTERN_PROP,
TEST_REGEXP_MISSING_COLUMN);
: additionalContext.put(MISSING_COLUMN_POLICY_PROP,
POLICY_REJECT);
: testThrowsException(additionalContext,
ERROR_MSG_MISSING_COLUMN, ROW_MISSING_COLUMN);
: }
> nit: did you consider combining these deprecated tests to cut down on dupli
Doing multiple assertions in one test case would be a bad practice, as you
would have to investigate test failures to see which assertion failed. The
other reason why I had the ...Deprecated tests is that they can be deleted with
the deprecated parameters.
As this test class has 4 type of tests, the parametrized version would require
a test method that is more complex than what we have now and the parameter
array would be long and hard to read.
I was considering to make this test parametrized and at the end the way it is
now seemed to be the most readable. It is long and has some code repetition in
it but the methods are short, simple and have descriptive names. And have only
one reason to fail.
--
To view, visit http://gerrit.cloudera.org:8080/11391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 4
Gerrit-Owner: Ferenc Szabo
Gerrit-Reviewer: Ferenc Szabo
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Tue, 25 Sep 2018 09:27:10 +
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 10: Verified+1 awesome, thanks Anupama -- To view, visit http://gerrit.cloudera.org:8080/11263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I2250652dcba3d1b0a06f1ffb7f23c11bf533d35e Gerrit-Change-Number: 11263 Gerrit-PatchSet: 10 Gerrit-Owner: Anupama Gupta Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Anupama Gupta Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 25 Sep 2018 08:01:02 + Gerrit-HasComments: No
