Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3766
Change subject: [make_site.sh] an option for the script: doxygen
..
[make_site.sh] an option for the script: doxygen
By default, do not
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 14:
(4 comments)
Looked only at the doxygen comments in client.h file.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3729
to look at the new patch set (#2).
Change subject: [make_site.h] added C++ client API documentaion
..
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3834
Change subject: [KuduScanBatch::const_iterator] a minor clean-up
..
[KuduScanBatch::const_iterator] a minor clean-up
More
Alexey Serbin has posted comments on this change.
Change subject: c++ client: remove unnecessary code
..
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3809/3/src/kudu/client/client-internal.cc
Alexey Serbin has posted comments on this change.
Change subject: [KuduScanBatch::const_iterator] a minor clean-up
..
Patch Set 1:
(3 comments)
Thank you for review. Will post an updated version soon.
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3825
Change subject: [doxygen] made DESTDIR applicable for ninja builds
..
[doxygen] made DESTDIR applicable for ninja builds
Moved the
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3952
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
Implemented
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3868
to look at the new patch set (#9).
Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data
..
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3723
to look at the new patch set (#9).
Change subject: C++ client: deprecating KuduPartialRow::SetString()
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3868
to look at the new patch set (#6).
Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data
..
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3723
to look at the new patch set (#11).
Change subject: C++ client: deprecating KuduPartialRow::SetString()
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3868
to look at the new patch set (#10).
Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data
..
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3836
to look at the new patch set (#2).
Change subject: [util] fixed build on MacOS X
..
[util] fixed
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3840
Change subject: [C++ client] doxygenized all C++ client API
..
[C++ client] doxygenized all C++ client API
Doxygenized the rest of
Alexey Serbin has abandoned this change.
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
Abandoned
Abandoned in favor of https://gerrit.cloudera.org/#/c/3952/
The new approach uses RPC messenger thread
Alexey Serbin has abandoned this change.
Change subject: C++ client: deprecating KuduPartialRow::SetString()
..
Abandoned
Abandoning this in favor of http://gerrit.cloudera.org:8080/3868 which has been
merged already.
--
To
Alexey Serbin has posted comments on this change.
Change subject: [util/env_posix.cc] fixed build on MacOS X
..
Patch Set 1:
> oops, my bad!
np, and thank you for the instant review!
--
To view, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3952
to look at the new patch set (#5).
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
KUDU-456
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3960
Change subject: [util/stopwatch.h] fixed integer overflow
..
[util/stopwatch.h] fixed integer overflow
Fixed integer overflow reported
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3952
to look at the new patch set (#4).
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
KUDU-456
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3668
to look at the new patch set (#8).
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
KUDU-456
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3952
to look at the new patch set (#2).
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
KUDU-456
Alexey Serbin has posted comments on this change.
Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes
..
Patch Set 1: Code-Review+1
A tiny nit: is it possible to re-format the commit message to preserve
Alexey Serbin has posted comments on this change.
Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data
..
Patch Set 10:
(1 comment)
Thank you for the review, Mike!
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3840
to look at the new patch set (#2).
Change subject: [C++ client] doxygenized all C++ client API
..
[C++ client]
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3668
to look at the new patch set (#5).
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
KUDU-456
Alexey Serbin has posted comments on this change.
Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
..
Patch Set 2: Code-Review+1
> Build Started http://104.196.14.100/job/kudu-gerrit/2720/
The renaming of files
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3855
Change subject: [CMakeLists.txt] dot is mandatory for doxygen
..
[CMakeLists.txt] dot is mandatory for doxygen
Require dot (graphviz)
Alexey Serbin has posted comments on this change.
Change subject: C++ client: deprecating KuduPartialRow::SetString()
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/3723/3//COMMIT_MSG
Commit Message:
Line
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3685
to look at the new patch set (#3).
Change subject: client/sample.cc: fixed a couple of crashes
..
Alexey Serbin has posted comments on this change.
Change subject: [doxygen] made DESTDIR applicable for ninja builds
..
Patch Set 1:
> Looks good provided you've tested it with both make and ninja.
Yes, I tested it with GNU
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3723
to look at the new patch set (#5).
Change subject: C++ client: deprecating KuduPartialRow::SetString()
Alexey Serbin has posted comments on this change.
Change subject: [util/monotime] added handy operators for MonoTime
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3999/1/src/kudu/util/monotime.cc
File
Alexey Serbin has posted comments on this change.
Change subject: [util/monotime] added handy operators for MonoTime
..
Patch Set 1:
> I was going to say that the style guide frowns upon overloading,
> but apparently it was
Alexey Serbin has posted comments on this change.
Change subject: [util/monotime] added handy operators for MonoTime
..
Patch Set 1:
> (1 comment)
Great! That's simplifies everything. Then I'll remove those obsolete checks.
Alexey Serbin has posted comments on this change.
Change subject: [util/monotime] added handy operators for MonoTime
..
Patch Set 1:
> I was going to say that the style guide frowns upon overloading,
> but apparently it was
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3952
to look at the new patch set (#8).
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
KUDU-456
Alexey Serbin has posted comments on this change.
Change subject: Add weekly update for 8/16
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4008/1/_posts/2016-08-16-weekly-update.md
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3999
to look at the new patch set (#3).
Change subject: [util/monotime] added handy operators for MonoTime
..
Alexey Serbin has posted comments on this change.
Change subject: tool: better handling for positional arguments
..
Patch Set 1:
> (5 comments)
>
> There is a Go library which allows to implement rich CLI tools. If
>
Alexey Serbin has posted comments on this change.
Change subject: [util/monotime] added handy operators for MonoTime
..
Patch Set 5:
(1 comment)
Thank you for the review!
Alexey Serbin has posted comments on this change.
Change subject: Add weekly update for 8/16
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit
Alexey Serbin has posted comments on this change.
Change subject: tls_socket: support zero-length writes
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5861
To unsubscribe, visit
Alexey Serbin has posted comments on this change.
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
Patch Set 3: Verified+1
Unrelated failure in DEBUG configuration:
kudu/tests/test_scantoken.py
Alexey Serbin has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 4:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5845/4/src/kudu/security/tls_context.cc
File
Alexey Serbin has posted comments on this change.
Change subject: [security] adjust TLS certificate verification
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5865/3/src/kudu/rpc/sasl_common.h
Alexey Serbin has posted comments on this change.
Change subject: security: simplify CertSigner interface
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5846
To unsubscribe, visit
Alexey Serbin has posted comments on this change.
Change subject: Fix some clang-tidy errors for std::move
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5867
To unsubscribe, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#6).
Change subject: [master] store CA information in the system table
..
[master]
Alexey Serbin has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 1: Code-Review+2
(1 comment)
LGTM, consider fixing a tiny typo before
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5870
to look at the new patch set (#3).
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
[mini_cluster] fix crash in GetLeaderMasterIndex()
If at least one of the mini-masters is shutdown by
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#8).
Change subject: [master] store CA information in the system table
..
[master]
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5870
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
[mini_cluster] fix crash in GetLeaderMasterIndex()
If at least
Alexey Serbin has posted comments on this change.
Change subject: WIP: issue authentication tokens and CA certs to clients
..
Patch Set 1:
(4 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#9).
Change subject: [master] store CA information in the system table
..
[master]
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 10:
(11 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#11).
Change subject: [master] store CA information in the system table
..
[master]
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#10).
Change subject: [master] store CA information in the system table
..
[master]
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 11:
(16 comments)
Thank you for review. I spot some extra things myself and decided to update
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5901
Change subject: [sys_catalog] make visitor's code more generic
..
[sys_catalog] make visitor's code more generic
Minor refactoring on
Alexey Serbin has posted comments on this change.
Change subject: [sys_catalog] make visitor's code more generic
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5901/1/src/kudu/master/sys_catalog.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5901
to look at the new patch set (#3).
Change subject: [sys_catalog] make visitor's code more generic
..
[sys_catalog]
Alexey Serbin has posted comments on this change.
Change subject: [sys_catalog] make visitor's code more generic
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5901/1/src/kudu/master/sys_catalog.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5901
to look at the new patch set (#2).
Change subject: [sys_catalog] make visitor's code more generic
..
[sys_catalog]
Alexey Serbin has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 6: Code-Review+2
(1 comment)
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5793/11/src/kudu/master/catalog_manager.cc
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 11:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5793/11/src/kudu/master/master.proto
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#13).
Change subject: [master] store CA information in the system table
..
[master]
Alexey Serbin has posted comments on this change.
Change subject: master: issue authentication tokens and CA certs to clients
..
Patch Set 4:
(4 comments)
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 16: Verified+1
I think the test failure in
Alexey Serbin has submitted this change and it was merged.
Change subject: [master] store CA information in the system table
..
[master] store CA information in the system table
The certificate authority information (private
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#12).
Change subject: [master] store CA information in the system table
..
[master]
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#15).
Change subject: [master] store CA information in the system table
..
[master]
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5793/14/src/kudu/master/catalog_manager.cc
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 11:
(1 comment)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#14).
Change subject: [master] store CA information in the system table
..
[master]
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#16).
Change subject: [master] store CA information in the system table
Alexey Serbin has posted comments on this change.
Change subject: [master] store CA information in the system table
..
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5793/15/src/kudu/master/catalog_manager.cc
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5907
Change subject: KUDU-1864 Thirdparty squeasel build fails on macOS 10.12
..
KUDU-1864 Thirdparty squeasel build fails on macOS 10.12
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5805
to look at the new patch set (#14).
Change subject: [security] sign/verify data using RSA key pair
..
Alexey Serbin has posted comments on this change.
Change subject: [security] sign/verify data using RSA key pair
..
Patch Set 13:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5805/13//COMMIT_MSG
Commit Message:
PS13,
Alexey Serbin has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 11: Verified+1
Unrelated breakage:
19:15:06 CMake Error at CMakeLists.txt:917 (find_package):
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5812
to look at the new patch set (#11).
Change subject: [security] do actual token signing/verification
..
[security]
Alexey Serbin has posted comments on this change.
Change subject: tls: hook up internal PKI system to TlsContext
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5808/2/src/kudu/security/tls_context.cc
File
Alexey Serbin has posted comments on this change.
Change subject: tls: move setting of verification modes into TlsHandshake
..
Patch Set 1:
(1 comment)
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5783
to look at the new patch set (#14).
Change subject: [security] method to extract public part of an RSA key
Alexey Serbin has posted comments on this change.
Change subject: [security] method to extract public part of an RSA key
..
Patch Set 13:
(2 comments)
Alexey Serbin has posted comments on this change.
Change subject: [security] avoid crashing when importing invalid TSKs
..
Patch Set 1: Code-Review+2
(1 comment)
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] sign/verify data using RSA key pair
..
[security] sign/verify data using RSA key pair
Added functionality to make a signature of a data
Alexey Serbin has posted comments on this change.
Change subject: [security] avoid crashing when importing invalid TSKs
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5843/1/src/kudu/security/token-test.cc
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] introduced crypto-test
..
[security] introduced crypto-test
The new crypto-test module is for test scenarios involving common
non-CA crypto
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] avoid crashing when importing invalid TSKs
..
[security] avoid crashing when importing invalid TSKs
Kudu typically tries to avoid crashing
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5812
to look at the new patch set (#10).
Change subject: [security] do actual token signing/verification
..
[security]
Alexey Serbin has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc
Alexey Serbin has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 11:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5812/11/src/kudu/security/token_signing_key.h
Hello Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5812
to look at the new patch set (#12).
Change subject: [security] do actual token signing/verification
..
[security]
Alexey Serbin has posted comments on this change.
Change subject: [security] do actual token signing/verification
..
Patch Set 12: Code-Review+2
Propagating +2 from Todd's review to this version (comment updates).
--
To
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] do actual token signing/verification
..
[security] do actual token signing/verification
Replaced temporary stub sign/verify calls with calls
1 - 100 of 14513 matches
Mail list logo