[kudu-CR](gh-pages) Add weekly update for 07/25

2016-07-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add weekly update for 07/25 .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/3763/1/_posts/2016-07-26-weekly-update.md File

[kudu-CR] Fix mailing list archive links to not reference incubator

2016-07-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix mailing list archive links to not reference incubator .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3725 To unsubscribe,

[kudu-CR](gh-pages) Update the overview page

2016-07-22 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Update the overview page .. Update the overview page Long-overdue updates to the overview page, including our new ASF status, official Python support,

[kudu-CR](gh-pages) Update the overview page

2016-07-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Update the overview page .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3726 To unsubscribe, visit

[kudu-CR](gh-pages) Blog post for the graduation

2016-07-25 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Blog post for the graduation .. Blog post for the graduation This is just a reblog with the appropriate markdown syntax. Change-Id:

[kudu-CR] [make site.h] added C++ client API documentaion

2016-07-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [make_site.h] added C++ client API documentaion .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3729/1/docs/support/scripts/make_site.sh File

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-07-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc File docs/index.adoc: PS1,

[kudu-CR] KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation

2016-07-30 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3819 to look at the new patch set (#3). Change subject: KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation

[kudu-CR] KUDU-1416 Upsert support for Flume sink

2016-08-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1416 Upsert support for Flume sink .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3157 To unsubscribe, visit

[kudu-CR] Clarify that delta compaction is for REDOs

2016-08-11 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3944 to look at the new patch set (#2). Change subject: Clarify that delta compaction is for REDOs .. Clarify that

[kudu-CR] Clarify that minor delta compaction is for REDOs

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Clarify that minor delta compaction is for REDOs .. Patch Set 1: (1 comment) actually i have a couple more changes i want to make

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3943/1/src/kudu/common/timestamp.h File

[kudu-CR] Clarify that delta compaction is for REDOs

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Clarify that delta compaction is for REDOs .. Clarify that delta compaction is for REDOs This just clarifies docs and comments around delta compaction, as

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Timestamp::FromUint64 should return void .. Timestamp::FromUint64 should return void It does no validation, can't fail, and has the same signature as one

[kudu-CR] KUDU-1555. PBC Flush() method should be async

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1555. PBC Flush() method should be async .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3951 To unsubscribe, visit

[kudu-CR](gh-pages) www: Add Kudu talks to Community page

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: www: Add Kudu talks to Community page .. Patch Set 1: Code-Review+2 Verified+1 Verified this looks good, pushing -- To view, visit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3868/3/src/kudu/common/partial_row-test.cc

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3868/9/src/kudu/common/partial_row-test.cc

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#6). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement

[kudu-CR] Add regex string match assert helper macros

2016-08-13 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Add regex string match assert helper macros .. Add regex string match assert helper macros These delegate to gmock but are easier to remember than:

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/6/src/kudu/tablet/compaction.cc File

[kudu-CR] Create tablet history GC randomized itest

2016-08-14 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#2). Change subject: Create tablet history GC randomized itest .. Create tablet

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#11). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement

[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3972 to review the following change. Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file .. Pull

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3974 to review the following change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Create

[kudu-CR] Create tablet history GC randomized itest

2016-08-14 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#3). Change subject: Create tablet history GC randomized itest .. Create tablet

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/11/src/kudu/tablet/tablet_history_gc-test.cc File

[kudu-CR] Use nullptr instead of NULL in compaction

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Use nullptr instead of NULL in compaction .. Use nullptr instead of NULL in compaction No functional changes here. Change-Id:

[kudu-CR] Create randomized tablet history GC itest

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#5). Change subject: Create randomized tablet history GC itest ..

[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file .. Abandoned This might not be needed -- To view, visit http://gerrit.cloudera.org:8080/3972 To unsubscribe,

[kudu-CR] WIP: Fix ordered iterators

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3976 to review the following change. Change subject: WIP: Fix ordered iterators .. WIP: Fix ordered iterators Needs test.

[kudu-CR] Various comment / doc improvements

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3977 to review the following change. Change subject: Various comment / doc improvements .. Various comment / doc

[kudu-CR] Improve some comments in the tablet compaction code

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Improve some comments in the tablet compaction code .. Abandoned Superceded by https://gerrit.cloudera.org/3977 -- To view, visit http://gerrit.cloudera.org:8080/3973 To

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#8). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3962 Change subject: Add regex string match assert helper macros .. Add regex string match assert helper macros Change-Id:

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 6: (11 comments) Posting partially addressed feedback except for 2 comments in compaction.cc and 2 comments in

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3962 to look at the new patch set (#2). Change subject: Add regex string match assert helper macros .. Add regex string

[kudu-CR] Rename raft-remote-bootstrap design doc

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Rename raft-remote-bootstrap design doc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3890 To unsubscribe, visit

[kudu-CR] WIP: KUDU-236. Implement tablet history GC

2016-08-11 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#5). Change subject: WIP: KUDU-236. Implement tablet history GC .. WIP: KUDU-236.

[kudu-CR](gh-pages) www: Add Spark Summit EU talk

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: www: Add Spark Summit EU talk .. www: Add Spark Summit EU talk Change-Id: I575c1ee7219a96a3c019cb2fe0899dfeef66 Reviewed-on:

[kudu-CR](gh-pages) www: Add Spark Summit EU talk

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: www: Add Spark Summit EU talk .. Patch Set 1: Code-Review+2 Verified+1 Tested, looks good -- To view, visit http://gerrit.cloudera.org:8080/3949 To unsubscribe,

[kudu-CR] Add Apache Kudu logo to the source tree

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Add Apache Kudu logo to the source tree .. Abandoned We'll try to find another place for this. -- To view, visit http://gerrit.cloudera.org:8080/3701 To unsubscribe,

[kudu-CR] Rename Remote Bootstrap: some manual changes

2016-08-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Rename Remote Bootstrap: some manual changes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3852 To unsubscribe, visit

[kudu-CR] Rename Remote Bootstrap: some manual changes

2016-08-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Rename Remote Bootstrap: some manual changes .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

2016-08-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3848 To unsubscribe, visit

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 2: (3 comments) Can we add basic test coverage for SetString() and SetBinary()?

[kudu-CR] [client][gutil] introduced ATTRIBUTE DEPRECATED

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: [client][gutil] introduced ATTRIBUTE_DEPRECATED .. [client][gutil] introduced ATTRIBUTE_DEPRECATED The ATTRIBUTE_DEPRECATED macro is to mark deprecated

[kudu-CR] [client][gutil] introduced ATTRIBUTE DEPRECATED

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [client][gutil] introduced ATTRIBUTE_DEPRECATED .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3874 To unsubscribe, visit

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3981 to review the following change. Change subject: Update some comments in Tablet impl and rename a method .. Update

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#13). Change subject: KUDU-236 (part 1). Implement tablet history GC ..

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#6). Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest

[kudu-CR] Various comment / doc improvements

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3977 to look at the new patch set (#2). Change subject: Various comment / doc improvements .. Various

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 13: > Could you also add a GCing thread to mt-tablet-test? It's a good > way to test interactions

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-16 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#17). Change subject: KUDU-236 (part 1). Implement tablet history GC .. KUDU-236

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#7). Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 7: I ran 3000 loops of this with 3000 rounds each and they all passed (in RELEASE mode).

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#14). Change subject: KUDU-236 (part 1). Implement tablet history GC ..

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3983 to review the following change. Change subject: KUDU-236 (part 3). Enable tablet history GC by default .. KUDU-236

[kudu-CR] Add release notes for tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3988 to review the following change. Change subject: Add release notes for tablet history GC .. Add release notes for

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Another pass on 0.10.0 release notes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3979/1/docs/release_notes.adoc File docs/release_notes.adoc:

[kudu-CR] Support downgrade to version that has LocalConsensus

2016-08-15 Thread Mike Percy (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3985 to review the following change. Change subject: Support downgrade to version that has LocalConsensus ..

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3976 To unsubscribe, visit

[kudu-CR](gh-pages) Add weekly update for 8/16

2016-08-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add weekly update for 8/16 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4008 To unsubscribe, visit

[kudu-CR](branch-0.10.x) Change to non-SNAPSHOT version on 0.10.x branch

2016-08-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Change to non-SNAPSHOT version on 0.10.x branch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4001 To unsubscribe, visit

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-08-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 3: Code-Review+2 We can address my previous feedback in a follow-up commit if we want to get the rest of

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-08-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc File docs/index.adoc: PS1,

[kudu-CR] thirdparty: Revert build dir cleanup changes

2017-02-02 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5872 to review the following change. Change subject: thirdparty: Revert build dir cleanup changes .. thirdparty: Revert

[kudu-CR] tablet copy: Include local peer UUID in TabletCopyService log messages

2017-02-02 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/5873 Change subject: tablet copy: Include local peer UUID in TabletCopyService log messages .. tablet copy: Include local peer UUID in

[kudu-CR] [tools] Add missing help text from few tools

2017-02-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [tools] Add missing help text from few tools .. Patch Set 2: LGTM -- To view, visit http://gerrit.cloudera.org:8080/5885 To unsubscribe, visit

[kudu-CR] [thirdparty] fix build-thirdparty.sh for bash 3.x

2017-01-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [thirdparty] fix build-thirdparty.sh for bash 3.x .. Patch Set 1: Code-Review+2 Oops, sorry for breaking Mac! -- To view, visit

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-06 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5919 to look at the new patch set (#2). Change subject: compaction: Add additional validation in DeltaTracker ..

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-06 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5919 to look at the new patch set (#3). Change subject: compaction: Add additional validation in DeltaTracker ..

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 1: (3 comments) > Worth adding a test? I didn't change any functionality, I simply added new

[kudu-CR] compaction: Flush tablet metadata before updating stores

2017-02-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5920 to look at the new patch set (#2). Change subject: compaction: Flush tablet metadata before updating stores ..

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#30). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#31). Change subject: Add Google Breakpad support to Kudu .. Add Google

[kudu-CR] KUDU-1856: always truncate containers when they get full

2017-02-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1856: always truncate containers when they get full .. Patch Set 3: Code-Review+1 (1 comment)

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-07 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: compaction: Add additional validation in DeltaTracker .. compaction: Add additional validation in DeltaTracker This adds DEBUG-mode validation to

[kudu-CR] compaction: Flush tablet metadata before updating stores

2017-02-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5920 to look at the new patch set (#3). Change subject: compaction: Flush tablet metadata before updating stores ..

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 27: (3 comments) http://gerrit.cloudera.org:8080/#/c/5620/27/src/kudu/client/symbols.map File

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#35). Change subject: Add Google Breakpad support to Kudu .. Add Google

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#32). Change subject: Add Google Breakpad support to Kudu .. Add Google

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-08 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#36). Change subject: Add Google Breakpad support to Kudu .. Add Google

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-08 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#37). Change subject: Add Google Breakpad support to Kudu .. Add Google

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 34: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/34/src/kudu/util/minidump.h File

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 37: I tested this latest rev on macOS El Capitan and Ubuntu xenial and both builds pass. -- To view, visit

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad support to Kudu Breakpad creates minidumps upon crash, which are small files that include

[kudu-CR] KUDU-1856: always truncate containers when they get full

2017-02-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1856: always truncate containers when they get full .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5852 To unsubscribe,

[kudu-CR] KUDU-1856: always truncate containers when they get full

2017-02-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1856: always truncate containers when they get full .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5852/3/src/kudu/util/env_posix.cc File

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-06 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5919 to review the following change. Change subject: compaction: Add additional validation in DeltaTracker

[kudu-CR] tablet: Include peer uuid in log prefix

2017-02-06 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5918 to review the following change. Change subject: tablet: Include peer uuid in log prefix .. tablet: Include

[kudu-CR] consensus peers-test: Call FsManager::Open() in SetUp()

2017-01-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: consensus_peers-test: Call FsManager::Open() in SetUp() .. consensus_peers-test: Call FsManager::Open() in SetUp() This test previously neglected to call

[kudu-CR] wal: Include standard prefix on glog lines

2017-01-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: wal: Include standard prefix on glog lines .. Patch Set 4: Code-Review+2 Carrying forward Adar's previous +2 -- To view, visit

[kudu-CR] Upgrade Snappy to 1.1.4

2017-01-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Upgrade Snappy to 1.1.4 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5833 To unsubscribe, visit

[kudu-CR] wal: Include standard prefix on glog lines

2017-01-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: wal: Include standard prefix on glog lines .. wal: Include standard prefix on glog lines Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56 Reviewed-on:

[kudu-CR] consensus peers-test: Call FsManager::Open() in SetUp()

2017-01-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus_peers-test: Call FsManager::Open() in SetUp() .. Patch Set 1: I just don't think this test previously called uuid() or other checked methods. -- To

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Control mutex stack walking in DEBUG mode with a gflag This patch disables the Mutex owner stack

[kudu-CR] Make delete table-test less flaky

2017-01-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Make delete_table-test less flaky .. Make delete_table-test less flaky Add AssertEventually to this DeleteTablet() call so it doesn't race against the

  1   2   3   4   5   6   7   8   9   10   >