[kudu-CR] [security] method to extract public part of RSA key

2017-01-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] method to extract public part of RSA key .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5783/6/src/kudu/security/crypto.cc File

[kudu-CR] tls: hook up internal PKI system to TlsContext

2017-01-27 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5808 to look at the new patch set (#2). Change subject: tls: hook up internal PKI system to TlsContext

[kudu-CR] tls: hook up internal PKI system to TlsContext

2017-01-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tls: hook up internal PKI system to TlsContext .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5808/1/src/kudu/master/master_service.cc File

[kudu-CR] security: initial work on token creation and verification

2017-01-25 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5796 to review the following change. Change subject: security: initial work on token creation and verification

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5775/2/src/kudu/client/client.h File

[kudu-CR] TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes .. Patch Set 10: (1 comment)

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5766 to look at the new patch set (#4). Change subject: security: generate certs on the tserver, sign them on the master

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 4: Nope, just curious if I may have missed something. I guess if it becomes flaky

[kudu-CR] webserver: improve SSL certificate handling

2017-01-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5015 to look at the new patch set (#7). Change subject: webserver: improve SSL certificate handling .. webserver:

[kudu-CR] security: initial work on token creation and verification

2017-01-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5796 to look at the new patch set (#4). Change subject: security: initial work on token creation and verification ..

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5766 To

[kudu-CR] webserver: improve SSL certificate handling

2017-01-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5015 to look at the new patch set (#6). Change subject: webserver: improve SSL certificate handling .. webserver:

[kudu-CR] webserver: improve SSL certificate handling

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: webserver: improve SSL certificate handling .. Patch Set 5: (2 comments) Done those. Next revision is a rebase

[kudu-CR] security: initial work on token creation and verification

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: initial work on token creation and verification .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/5796/2/src/kudu/security/token.proto

[kudu-CR] security: initial work on token creation and verification

2017-01-25 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5796 to look at the new patch set (#2). Change subject: security: initial work on token creation and verification

[kudu-CR] KUDU-1852. KuduTableAlterer should not crash with nullptr arguments

2017-01-25 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5797 to review the following change. Change subject: KUDU-1852. KuduTableAlterer should not crash with nullptr arguments

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5775/2/src/kudu/client/client.h File

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1835 (part 2): enable WAL compression .. Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c/5736/8/src/kudu/consensus/log.cc File

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5736 to look at the new patch set (#9). Change subject: KUDU-1835 (part 2): enable WAL compression .. KUDU-1835 (part

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 4: Not sure how this patch could be causing the Java test to fail, unless it's the

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5760 To unsubscribe, visit

[kudu-CR] KUDU-1852. KuduTableAlterer should not crash with nullptr arguments

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1852. KuduTableAlterer should not crash with nullptr arguments .. KUDU-1852. KuduTableAlterer should not crash with nullptr arguments Change-Id:

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5775/2/src/kudu/client/client.h File

[kudu-CR] security: initial work on token creation and verification

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: initial work on token creation and verification .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5796/2/src/kudu/security/token.proto

[kudu-CR] TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes .. Patch Set 10: (1 comment)

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5750 Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Bump version in branch to 1.2.1-SNAPSHOT Change-Id:

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5752 to review the following change. Change subject: docs: clarify guidelines on boost usage .. docs: clarify

[kudu-CR](gh-pages) Change links for old releases to Apache archive

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5751 to review the following change. Change subject: Change links for old releases to Apache archive .. Change

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Bump version in branch to 1.2.1-SNAPSHOT Change-Id: Ide4527df249f91fe60c19f7a0a7be18a0cb012d5 --- M

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: Yea, I pasted them to the JIRA. I will also include them in the commit message in the next rev of

[kudu-CR] [security] interface for certificate signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] interface for certificate signing service .. Patch Set 3: OK. I'm starting to hack on the tablet server side to generate a cert and CSR and send it to

[kudu-CR] TLS-negotiation [5/n]: Rename sasl [client|server] to [client|server] negotiation

2017-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [5/n]: Rename sasl_[client|server] to [client|server]_negotiation .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] TLS-negotiation [4/n]: rename Negotiation steps

2017-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [4/n]: rename Negotiation steps .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5758 To unsubscribe, visit

[kudu-CR] TLS-negotiation [3/n]: rename negotiation protobuf messages

2017-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [3/n]: rename negotiation protobuf messages .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5757/2/src/kudu/rpc/sasl_server.cc

[kudu-CR] TLS-negotiation [6/n]: Refactor RPC negotiation

2017-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation .. Patch Set 5: (12 comments) Seems like there is some kind of openssl-related leak as well: Direct leak of 4848

[kudu-CR] TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes

2017-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes .. Patch Set 5: (13 comments)

[kudu-CR] TLS-negotiation [8/n]: TLS negotiation

2017-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [8/n]: TLS negotiation .. Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/5762/5//COMMIT_MSG Commit Message: Line 9: This commit

[kudu-CR] TLS-negotiation [2/n]: remove SASL ANONYMOUS mechanism

2017-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [2/n]: remove SASL ANONYMOUS mechanism .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5756 To unsubscribe, visit

[kudu-CR] TLS-negotiation [1/n]: deprecate unused SaslAuth fields

2017-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [1/n]: deprecate unused SaslAuth fields .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5755 To unsubscribe,

[kudu-CR](branch-1.2.x) [util] fixed env-test on OS X

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X Prior to the fix, in some cases the uninitialized portion of 64-bit variable was non-zero

[kudu-CR](branch-1.2.x) [util] fixed env-test on OS X

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5753 To unsubscribe, visit

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] groundwork for cert signing service .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5671/4/src/kudu/security/ca/cert_management.cc

[kudu-CR] [security] interface for certificate signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] interface for certificate signing service .. Patch Set 3: This seems pretty reasonable, but I'm not sure whether this makes sense as a standalone RPC

[kudu-CR] docs: clarify guidelines on boost usage

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: clarify guidelines on boost usage .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5752/1/docs/contributing.adoc File

[kudu-CR] rpc: add basic service and method-level authorization

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4897 to look at the new patch set (#2). Change subject: rpc: add basic service and method-level authorization .. rpc:

[kudu-CR] rpc: add basic service and method-level authorization

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: add basic service and method-level authorization .. Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/4897/1/src/kudu/rpc/protoc-gen-krpc.cc

[kudu-CR] [security] groundwork for cert signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] groundwork for cert signing service .. Patch Set 1: (3 comments)

[kudu-CR] [security] Kudu certificate signing service

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] Kudu certificate signing service .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5674/3/src/kudu/master/master.cc File

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1835 (part 1). Move compression codec classes to util .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5735/4/src/kudu/cfile/cfile-test.cc

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5737 to look at the new patch set (#2). Change subject: KUDU-1836. Enable compression of DeltaFiles ..

[kudu-CR] KUDU-1835 (part 2): enable WAL compression

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5736 to look at the new patch set (#7). Change subject: KUDU-1835 (part 2): enable WAL compression .. KUDU-1835 (part

[kudu-CR] KUDU-1835 (part 1). Move compression codec classes to util

2017-01-20 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5735 to look at the new patch set (#5). Change subject: KUDU-1835 (part 1). Move compression codec classes to util ..

[kudu-CR] webserver: improve SSL certificate handling

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: webserver: improve SSL certificate handling .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5015/7/src/kudu/rpc/rpc-test-base.h File

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-26 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5766 to look at the new patch set (#6). Change subject: security: generate certs on the tserver, sign them on the master

[kudu-CR] security: initial work on token creation and verification

2017-01-26 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5796 to look at the new patch set (#5). Change subject: security: initial work on token creation and verification

[kudu-CR] KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER .. Patch Set 3: Code-Review+2 Carrying David's +2 -- To view, visit

[kudu-CR] KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER .. KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER This adds a test for

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 6: OK, indeed the test was sensitive to slower startup times of the daemons (caused

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-26 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5803 to review the following change. Change subject: Fix flakiness of TestConnectionCache .. Fix flakiness of

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5766 To

[kudu-CR] security: initial work on token creation and verification

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: security: initial work on token creation and verification .. security: initial work on token creation and verification This adds classes for managing

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: security: generate certs on the tserver, sign them on the master .. security: generate certs on the tserver, sign them on the master This adds a bit of

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security: generate certs on the tserver, sign them on the master .. Patch Set 6: Going to commit this even though the test will be flaky for a short period of

[kudu-CR] tls: hook up internal PKI system to TlsContext

2017-01-26 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5808 to review the following change. Change subject: tls: hook up internal PKI system to TlsContext .. tls:

[kudu-CR] [security] method to extract public part of RSA key

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] method to extract public part of RSA key .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5783/4/src/kudu/security/crypto.h File

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5805/2/src/kudu/security/openssl_util.cc File

[kudu-CR] Reduce default RSA key length for tests

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Reduce default RSA key length for tests .. Reduce default RSA key length for tests The default RSA key length for real servers is set to 2048 bits.

[kudu-CR] WIP: Support for enabling webserver SSL in CSD

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5806 Change subject: WIP: Support for enabling webserver SSL in CSD .. WIP: Support for enabling webserver SSL in CSD Needs to be tested, etc.

[kudu-CR] Reduce default RSA key length for tests

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Reduce default RSA key length for tests .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5804/1//COMMIT_MSG Commit Message: PS1, Line 22: This

[kudu-CR] webserver: improve SSL certificate handling

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: webserver: improve SSL certificate handling .. webserver: improve SSL certificate handling * Allows users to specify a separate location for PEM

[kudu-CR] Reduce default RSA key length for tests

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Reduce default RSA key length for tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5804/1/src/kudu/util/test_util.cc File

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5805/2/src/kudu/security/openssl_util.cc File

[kudu-CR] Reduce default RSA key length for tests

2017-01-26 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5804 to review the following change. Change subject: Reduce default RSA key length for tests .. Reduce

[kudu-CR] rpc: add basic service and method-level authorization

2017-01-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: rpc: add basic service and method-level authorization .. rpc: add basic service and method-level authorization This adds some basic authorization support

[kudu-CR] WIP [master] store CA information in the system table

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP [master] store CA information in the system table .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5793/2/src/kudu/master/master.proto File

[kudu-CR] WIP [master] store CA information in the system table

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP [master] store CA information in the system table .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5793/2/src/kudu/master/catalog_manager.h

[kudu-CR] Update Impala docs for upcoming Impala 2.8 release

2017-01-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update Impala docs for upcoming Impala 2.8 release .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5733/1/docs/kudu_impala_integration.adoc File

[kudu-CR] Update Impala docs for upcoming Impala 2.8 release

2017-01-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5733 to look at the new patch set (#2). Change subject: Update Impala docs for upcoming Impala 2.8 release .. Update

[kudu-CR] WIP [openssl util] method to extract public part of RSA key

2017-01-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP [openssl_util] method to extract public part of RSA key .. Patch Set 1: (2 comments)

[kudu-CR] security: generate certs on the tserver, sign them on the master

2017-01-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5766 to look at the new patch set (#3). Change subject: security: generate certs on the tserver, sign them on the master

[kudu-CR] java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: rename GetMasterRegistration -> ConnectToCluster/ConnectToMaster .. Patch Set 3: Code-Review+2 Carrying +2 from earlier pre-rebase -- To view, visit

[kudu-CR] java: redo locking and simplify TabletClient

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: redo locking and simplify TabletClient .. java: redo locking and simplify TabletClient This gets rid of some of the attempts at fancy

[kudu-CR] KUDU-1883. Support Ruby 2.4 in make docs task

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1883. Support Ruby 2.4 in make docs task .. KUDU-1883. Support Ruby 2.4 in make docs task Bumps the json gem to 1.8.5 in order to support ruby 2.4.

[kudu-CR] WIP: java: use new ConnectToMaster RPC with fallback

2017-02-15 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6035 to review the following change. Change subject: WIP: java: use new ConnectToMaster RPC with fallback .. WIP:

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5820 To

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. KUDU-1845: Kerberos client keytab should be periodically renewed With the current

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 10: lgtm, i'll put this on a cluster and see how it goes. -- To view, visit

[kudu-CR] KUDU-1883. Support Ruby 2.4 in make docs task

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1883. Support Ruby 2.4 in make docs task .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6022 To unsubscribe, visit

[kudu-CR] Tag kerberos principal flag as unsafe

2017-02-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6036 to review the following change. Change subject: Tag kerberos_principal flag as unsafe .. Tag kerberos_principal flag

[kudu-CR] Patch : Submit defaultValue, desiredBlockSize, encoding and compressionAlgorithm via metadata in schema when using KuduContext's createTable. Please refer KUDU JIRA https://issues.apache.org

2017-02-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Patch : Submit defaultValue, desiredBlockSize, encoding and compressionAlgorithm via metadata in schema when using KuduContext's createTable. Please refer KUDU JIRA https://issues.apache.org/jira/browse/KUDU-1737.

[kudu-CR] [security] Negotiate authentication type during RPC setup

2017-02-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] Negotiate authentication type during RPC setup .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5988/3/src/kudu/rpc/rpc_header.proto

[kudu-CR] negotiation: add tracing of negotiated authn type

2017-02-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: negotiation: add tracing of negotiated authn type .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6079/1/src/kudu/rpc/negotiation.cc File

[kudu-CR] tserver: fix an error message when failing to trust master CA

2017-02-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tserver: fix an error message when failing to trust master CA .. tserver: fix an error message when failing to trust master CA Change-Id:

[kudu-CR] master: complete hooking up tokens and IPKI

2017-02-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: master: complete hooking up tokens and IPKI .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6075/3/src/kudu/master/catalog_manager.cc File

[kudu-CR] java: add a fake DNS resolver to avoid reverse DNS hangs

2017-02-21 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6076 to look at the new patch set (#4). Change subject: java: add a fake DNS resolver to avoid reverse DNS hangs ..

[kudu-CR] java: fetch and adopt authn token and CA from master

2017-02-21 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6077 to look at the new patch set (#4). Change subject: java: fetch and adopt authn token and CA from master .. java:

[kudu-CR] master: complete hooking up tokens and IPKI

2017-02-21 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6075 to look at the new patch set (#4). Change subject: master: complete hooking up tokens and IPKI .. master: complete

[kudu-CR] negotiation: add tracing of negotiated authn type

2017-02-21 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6079 to look at the new patch set (#2). Change subject: negotiation: add tracing of negotiated authn type

[kudu-CR] java: further cleanup of ConnectToCluster

2017-02-21 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6053 to look at the new patch set (#6). Change subject: java: further cleanup of ConnectToCluster .. java:

<    1   2   3   4   5   6   7   8   9   10   >