[kudu-CR](branch-1.3.x) KUDU-1834 Don't redact KuduRowResult::ToString()
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1834 Don't redact KuduRowResult::ToString() .. KUDU-1834 Don't redact KuduRowResult::ToString() A user on the client side calling ToString on the results of a scan will likely expect the data to not be redacted. This patch forces KuduScanPatch::RowPtr::ToString() to not redact. A test case is added to client-test that turns redaction on and compares the output of ToString with a redacted row. If the row is redacted, this case fill fail. Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324 Reviewed-on: http://gerrit.cloudera.org:8080/6222 Reviewed-by: Adar DemboTested-by: Kudu Jenkins (cherry picked from commit f1da1eb450cb77878d44d1115d64c05f652378f1) Reviewed-on: http://gerrit.cloudera.org:8080/6244 Reviewed-by: Todd Lipcon --- M src/kudu/client/client-test.cc M src/kudu/client/scan_batch.cc 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-1.3.x) KUDU-1834 Don't redact KuduRowResult::ToString()
Todd Lipcon has posted comments on this change. Change subject: KUDU-1834 Don't redact KuduRowResult::ToString() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Todd LipconGerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-1.3.x) KUDU-1834 Don't redact KuduRowResult::ToString()
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6244 Change subject: KUDU-1834 Don't redact KuduRowResult::ToString() .. KUDU-1834 Don't redact KuduRowResult::ToString() A user on the client side calling ToString on the results of a scan will likely expect the data to not be redacted. This patch forces KuduScanPatch::RowPtr::ToString() to not redact. A test case is added to client-test that turns redaction on and compares the output of ToString with a redacted row. If the row is redacted, this case fill fail. Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324 Reviewed-on: http://gerrit.cloudera.org:8080/6222 Reviewed-by: Adar DemboTested-by: Kudu Jenkins (cherry picked from commit f1da1eb450cb77878d44d1115d64c05f652378f1) --- M src/kudu/client/client-test.cc M src/kudu/client/scan_batch.cc 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/6244/1 -- To view, visit http://gerrit.cloudera.org:8080/6244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong