[kudu-CR] [catalog] remove CatalogManager::CheckOnline()
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15977 ) Change subject: [catalog] remove CatalogManager::CheckOnline() .. [catalog] remove CatalogManager::CheckOnline() The implementation of CatalogManager::CheckOnline() was there to verify that the catalog is running. As it turns out, callers of the methods where CheckOnline() was invoked always (except for the code in master_path_handlers.cc) create ScopedLeaderSharedLock instance prior to a call with a follow-up verification of the catalog's status (e.g., see MasterServiceImpl). In other words, CheckOnline() was always performing a verification that has already been done. This patch removes CatalogManager::CheckOnline() along with the extra verification of the catalog's status. Change-Id: I00dd5d1f849d081e6a36190871e352e98f16f0a2 Reviewed-on: http://gerrit.cloudera.org:8080/15977 Tested-by: Alexey Serbin Reviewed-by: Andrew Wong --- M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master_path_handlers.cc 3 files changed, 4 insertions(+), 28 deletions(-) Approvals: Alexey Serbin: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I00dd5d1f849d081e6a36190871e352e98f16f0a2 Gerrit-Change-Number: 15977 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [catalog] remove CatalogManager::CheckOnline()
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15977 ) Change subject: [catalog] remove CatalogManager::CheckOnline() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00dd5d1f849d081e6a36190871e352e98f16f0a2 Gerrit-Change-Number: 15977 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 22 May 2020 04:44:21 + Gerrit-HasComments: No
[kudu-CR] [catalog] remove CatalogManager::CheckOnline()
Alexey Serbin has removed a vote on this change. Change subject: [catalog] remove CatalogManager::CheckOnline() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I00dd5d1f849d081e6a36190871e352e98f16f0a2 Gerrit-Change-Number: 15977 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [catalog] remove CatalogManager::CheckOnline()
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15977 ) Change subject: [catalog] remove CatalogManager::CheckOnline() .. Patch Set 1: Verified+1 Test failure due to known issue: https://issues.apache.org/jira/browse/KUDU-1466 -- To view, visit http://gerrit.cloudera.org:8080/15977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00dd5d1f849d081e6a36190871e352e98f16f0a2 Gerrit-Change-Number: 15977 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 22 May 2020 04:36:47 + Gerrit-HasComments: No
[kudu-CR] [catalog] remove CatalogManager::CheckOnline()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15977 Change subject: [catalog] remove CatalogManager::CheckOnline() .. [catalog] remove CatalogManager::CheckOnline() The implementation of CatalogManager::CheckOnline() was there to verify that the catalog is running. As it turns out, callers of the methods where CheckOnline() was invoked always (except for the code in master_path_handlers.cc) create ScopedLeaderSharedLock instance prior to a call with a follow-up verification of the catalog's status (e.g., see MasterServiceImpl). In other words, CheckOnline() was always performing a verification that has already been done. This patch removes CatalogManager::CheckOnline() along with the extra verification of the catalog's status. Change-Id: I00dd5d1f849d081e6a36190871e352e98f16f0a2 --- M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master_path_handlers.cc 3 files changed, 4 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/15977/1 -- To view, visit http://gerrit.cloudera.org:8080/15977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I00dd5d1f849d081e6a36190871e352e98f16f0a2 Gerrit-Change-Number: 15977 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
