[kudu-CR] [java] Use Assert.assertThrows

2020-02-11 Thread Grant Henke (Code Review) 
Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15196 )

Change subject: [java] Use Assert.assertThrows
..

[java] Use Assert.assertThrows

This patch converts all usage of JUnit expected exception rules
to `Assert.assertThrows`. This is the new way to test expected
exceptions in JUnit 4.13+.

Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Reviewed-on: http://gerrit.cloudera.org:8080/15196
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke 
---
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M 
java/kudu-subprocess-echo/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java
M 
java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/TestMessageIO.java
4 files changed, 82 insertions(+), 69 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Use Assert.assertThrows

2020-02-11 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15196 )

Change subject: [java] Use Assert.assertThrows
..


Patch Set 4: Code-Review+2

carrying the +2 through the rebase.


--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Feb 2020 15:15:37 +
Gerrit-HasComments: No

[kudu-CR] [java] Use Assert.assertThrows

2020-02-10 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15196 )

Change subject: [java] Use Assert.assertThrows
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Feb 2020 05:25:51 +
Gerrit-HasComments: No

[kudu-CR] [java] Use Assert.assertThrows

2020-02-10 Thread Hao Hao (Code Review) 
Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15196 )

Change subject: [java] Use Assert.assertThrows
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Feb 2020 23:50:32 +
Gerrit-HasComments: No

[kudu-CR] [java] Use Assert.assertThrows

2020-02-10 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15196 )

Change subject: [java] Use Assert.assertThrows
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Feb 2020 23:33:44 +
Gerrit-HasComments: No

[kudu-CR] [java] Use Assert.assertThrows

2020-02-10 Thread Grant Henke (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Hao Hao, Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15196

to look at the new patch set (#2).

Change subject: [java] Use Assert.assertThrows
..

[java] Use Assert.assertThrows

This patch converts all usage of JUnit expected exception rules
to `Assert.assertThrows`. This is the new way to test expected
exceptions in JUnit 4.13+.

Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
---
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M 
java/kudu-subprocess-echo/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java
M 
java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/TestMessageIO.java
4 files changed, 82 insertions(+), 69 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/15196/2
--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Use Assert.assertThrows

2020-02-10 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15196 )

Change subject: [java] Use Assert.assertThrows
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15196/1/java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
File 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java:

http://gerrit.cloudera.org:8080/#/c/15196/1/java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java@108
PS1, Line 108: Throwable thrown = 
Assert.assertThrows(IllegalArgumentException.class, new ThrowingRunnable() {
> Some of these lines are too long. Elsewhere in the patch too.
Done



--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Feb 2020 23:02:24 +
Gerrit-HasComments: Yes

[kudu-CR] [java] Use Assert.assertThrows

2020-02-10 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15196 )

Change subject: [java] Use Assert.assertThrows
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15196/1/java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
File 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java:

http://gerrit.cloudera.org:8080/#/c/15196/1/java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java@108
PS1, Line 108: Throwable thrown = 
Assert.assertThrows(IllegalArgumentException.class, new ThrowingRunnable() {
Some of these lines are too long. Elsewhere in the patch too.



--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Feb 2020 21:50:10 +
Gerrit-HasComments: Yes

[kudu-CR] [java] Use Assert.assertThrows

2020-02-10 Thread Bankim Bhavsar (Code Review) 
Bankim Bhavsar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15196 )

Change subject: [java] Use Assert.assertThrows
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Feb 2020 21:18:44 +
Gerrit-HasComments: No

[kudu-CR] [java] Use Assert.assertThrows

2020-02-10 Thread Grant Henke (Code Review) 
Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15196


Change subject: [java] Use Assert.assertThrows
..

[java] Use Assert.assertThrows

This patch converts all usage of JUnit expected exception rules
to `Assert.assertThrows`. This is the new way to test expected
exceptions in JUnit 4.13+.

Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
---
M 
java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M 
java/kudu-subprocess-echo/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java
M 
java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/TestMessageIO.java
4 files changed, 76 insertions(+), 68 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/15196/1
--
To view, visit http://gerrit.cloudera.org:8080/15196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1959d6a33bfd634f01332e3c3ef4d7af77b60fb0
Gerrit-Change-Number: 15196
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke