[kudu-CR] [tools] tooling to set/clear table comments

2021-06-17 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17600 )

Change subject: [tools] tooling to set/clear table comments
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/17600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8ea0ce05c642651eeadc1cb0cc654c5302921c
Gerrit-Change-Number: 17600
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Jun 2021 23:09:15 +
Gerrit-HasComments: No

[kudu-CR] [tools] tooling to set/clear table comments

2021-06-17 Thread Andrew Wong (Code Review) 
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17600 )

Change subject: [tools] tooling to set/clear table comments
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17600/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/17600/1/src/kudu/tools/kudu-tool-test.cc@1180
PS1, Line 1180: "clear_comment.*Clear the comment for a table",
> Would it make sense to add column versions as well?
Yeah, I can add this as a follow-up.



--
To view, visit http://gerrit.cloudera.org:8080/17600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8ea0ce05c642651eeadc1cb0cc654c5302921c
Gerrit-Change-Number: 17600
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Jun 2021 22:18:06 +
Gerrit-HasComments: Yes

[kudu-CR] [tools] tooling to set/clear table comments

2021-06-17 Thread Andrew Wong (Code Review) 
Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/17600 )

Change subject: [tools] tooling to set/clear table comments
..

[tools] tooling to set/clear table comments

This patch introduces the 'kudu table set_comment' and 'kudu table
clear_comment' tools to allow users to alter table comments. I found
this handy in testing out table comments on a real cluster.

Change-Id: I0b8ea0ce05c642651eeadc1cb0cc654c5302921c
Reviewed-on: http://gerrit.cloudera.org:8080/17600
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke 
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 82 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/17600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b8ea0ce05c642651eeadc1cb0cc654c5302921c
Gerrit-Change-Number: 17600
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tools] tooling to set/clear table comments

2021-06-17 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17600 )

Change subject: [tools] tooling to set/clear table comments
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17600/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/17600/1/src/kudu/tools/kudu-tool-test.cc@1180
PS1, Line 1180: "clear_comment.*Clear the comment for a table",
Would it make sense to add column versions as well?



--
To view, visit http://gerrit.cloudera.org:8080/17600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8ea0ce05c642651eeadc1cb0cc654c5302921c
Gerrit-Change-Number: 17600
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Jun 2021 22:07:25 +
Gerrit-HasComments: Yes

[kudu-CR] [tools] tooling to set/clear table comments

2021-06-16 Thread Andrew Wong (Code Review) 
Andrew Wong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/17600


Change subject: [tools] tooling to set/clear table comments
..

[tools] tooling to set/clear table comments

This patch introduces the 'kudu table set_comment' and 'kudu table
clear_comment' tools to allow users to alter table comments. I found
this handy in testing out table comments on a real cluster.

Change-Id: I0b8ea0ce05c642651eeadc1cb0cc654c5302921c
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 82 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/17600/1
--
To view, visit http://gerrit.cloudera.org:8080/17600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b8ea0ce05c642651eeadc1cb0cc654c5302921c
Gerrit-Change-Number: 17600
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong