[kudu-CR] KUDU-2427: fix glog symbolization in certain ASLR environments

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10431 )

Change subject: KUDU-2427: fix glog symbolization in certain ASLR environments
..

KUDU-2427: fix glog symbolization in certain ASLR environments

On Ubuntu 18.04, glog is unable to symbolize the stack frames belonging to
a unit test binary itself, leaving them as "(unknown)". This breaks various
unit tests that check the contents of those frames.

There hasn't been a new glog release in some time, but this upstream patch
fixes the problem.

Change-Id: Iba6f715123ddf41ba67b93860caf7041b8e137c4
Reviewed-on: http://gerrit.cloudera.org:8080/10431
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-fix-symbolization.patch
2 files changed, 214 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Todd Lipcon: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba6f715123ddf41ba67b93860caf7041b8e137c4
Gerrit-Change-Number: 10431
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: fix glog symbolization in certain ASLR environments

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10431 )

Change subject: KUDU-2427: fix glog symbolization in certain ASLR environments
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6f715123ddf41ba67b93860caf7041b8e137c4
Gerrit-Change-Number: 10431
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 17 May 2018 17:49:46 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2427: fix glog symbolization in certain ASLR environments

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10431

to review the following change.


Change subject: KUDU-2427: fix glog symbolization in certain ASLR environments
..

KUDU-2427: fix glog symbolization in certain ASLR environments

On Ubuntu 18.04, glog is unable to symbolize the stack frames belonging to
a unit test binary itself, leaving them as "(unknown)". This breaks various
unit tests that check the contents of those frames.

There hasn't been a new glog release in some time, but this upstream patch
fixes the problem.

Change-Id: Iba6f715123ddf41ba67b93860caf7041b8e137c4
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-fix-symbolization.patch
2 files changed, 214 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/10431/1
--
To view, visit http://gerrit.cloudera.org:8080/10431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba6f715123ddf41ba67b93860caf7041b8e137c4
Gerrit-Change-Number: 10431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon