[kudu-CR] WIP: Kudu table schema in Avro format

[Bankim Bhavsar (Code Review)]

Bankim Bhavsar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18121 )

Change subject: WIP: Kudu table schema in Avro format
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18121/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18121/1//COMMIT_MSG@17
PS1, Line 17: The output is a single line JSON string. Do we prefer multiline
: JSON string?
Yeah a pretty printer on the json would be preferred.


http://gerrit.cloudera.org:8080/#/c/18121/1/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/18121/1/src/kudu/tools/tool_action_table.cc@245
PS1, Line 245: FLAGS_avro_format_schema
Looks like the data displayed with avro_format_schema is very different from 
the current implementation which includes owner, partition etc. Ideally I think 
both should display same overall data just that the avro one is in avro format.
Is it possible to update code in such a way?


http://gerrit.cloudera.org:8080/#/c/18121/1/src/kudu/tools/tool_action_table.cc@280
PS1, Line 280: } else {
better to move the else block in a separate function



--
To view, visit http://gerrit.cloudera.org:8080/18121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98194739e8132f93e916d1a78d338d28dd9e8075
Gerrit-Change-Number: 18121
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 Jan 2022 19:11:52 +
Gerrit-HasComments: Yes

[kudu-CR] WIP: Kudu table schema in Avro format

[Abhishek Chennaka (Code Review)]

Abhishek Chennaka has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/18121


Change subject: WIP: Kudu table schema in Avro format
..

WIP: Kudu table schema in Avro format

This patch introduces a new flag -avro_format_schema to the existing
"kudu table describe" CLI tool to output the table schema in Avro
format along with a test case.

Inputs needed on:
1. In this current implementation -show_attributes optional flag
will do nothing when used along with -avro_format_schema. Is this
a limitation we can have for optional flags?
2. The output is a single line JSON string. Do we prefer multiline
JSON string?
3. The decimal type in avro has additional optional attributes
namely precision and scale. Do we want to include them in the
schema?

Change-Id: I98194739e8132f93e916d1a78d338d28dd9e8075
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
2 files changed, 133 insertions(+), 32 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/18121/1
--
To view, visit http://gerrit.cloudera.org:8080/18121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98194739e8132f93e916d1a78d338d28dd9e8075
Gerrit-Change-Number: 18121
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka