[kudu-CR] server: offer a flag to completely disable the web server

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged.

Change subject: server: offer a flag to completely disable the web server
..


server: offer a flag to completely disable the web server

This adds a new --webserver_enabled flag, which can be used to
completely disable the embedded web server. When disabled, the web
server does not listen at all.

The patch required a bit of cleanup to other spots in the code that
required all servers to have associated HTTP addresses. A new unit test
smoke tests a cluster configured in this manner.

Change-Id: I97dacfff075f21cde9248a11fcf19efefb030aec
Reviewed-on: http://gerrit.cloudera.org:8080/6216
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert 
---
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/server/server_base.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/util/net/net_util.h
M src/kudu/util/thread.cc
M src/kudu/util/thread.h
11 files changed, 100 insertions(+), 46 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97dacfff075f21cde9248a11fcf19efefb030aec
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] server: offer a flag to completely disable the web server

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: server: offer a flag to completely disable the web server
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97dacfff075f21cde9248a11fcf19efefb030aec
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] server: offer a flag to completely disable the web server

[Todd Lipcon (Code Review)]

Hello Dan Burkert, Hao Hao,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/6216

to review the following change.

Change subject: server: offer a flag to completely disable the web server
..

server: offer a flag to completely disable the web server

This adds a new --webserver_enabled flag, which can be used to
completely disable the embedded web server. When disabled, the web
server does not listen at all.

The patch required a bit of cleanup to other spots in the code that
required all servers to have associated HTTP addresses. A new unit test
smoke tests a cluster configured in this manner.

Change-Id: I97dacfff075f21cde9248a11fcf19efefb030aec
---
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/server/server_base.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/util/net/net_util.h
M src/kudu/util/thread.cc
M src/kudu/util/thread.h
11 files changed, 100 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/6216/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I97dacfff075f21cde9248a11fcf19efefb030aec
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao