[kudu-CR] log block manager: fix invalid pointer
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12477 ) Change subject: log_block_manager: fix invalid pointer .. log_block_manager: fix invalid pointer We saw a core dump after enabling VLOGing caused by an invalid pointer during OpenBlock(). We seem to be dereferencing a block that has been moved already. Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a Reviewed-on: http://gerrit.cloudera.org:8080/12477 Reviewed-by: Adar Dembo Reviewed-by: Hao Hao Tested-by: Kudu Jenkins --- M src/kudu/fs/log_block_manager.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Hao Hao: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a Gerrit-Change-Number: 12477 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] log block manager: fix invalid pointer
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12477 ) Change subject: log_block_manager: fix invalid pointer .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a Gerrit-Change-Number: 12477 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Feb 2019 23:50:20 + Gerrit-HasComments: No
[kudu-CR] log block manager: fix invalid pointer
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12477 ) Change subject: log_block_manager: fix invalid pointer .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12477/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/12477/1/src/kudu/fs/log_block_manager.cc@2063 PS1, Line 2063: VLOG(3) << "Opened block " << block_id > You don't need the ToString() call; there's an operator<< overload for Bloc Done http://gerrit.cloudera.org:8080/#/c/12477/1/src/kudu/fs/log_block_manager.cc@2065 PS1, Line 2065: block->reset(new internal::LogReadableBlock(std::move(lb))); > Hmm, I bet someone reordered this w.r.t. the VLOG. That's an alternative so This seems simpler, given the std::move(lb) -- To view, visit http://gerrit.cloudera.org:8080/12477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a Gerrit-Change-Number: 12477 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Feb 2019 23:33:58 + Gerrit-HasComments: Yes
[kudu-CR] log block manager: fix invalid pointer
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12477 ) Change subject: log_block_manager: fix invalid pointer .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a Gerrit-Change-Number: 12477 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Feb 2019 23:42:59 + Gerrit-HasComments: No
[kudu-CR] log block manager: fix invalid pointer
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12477 to look at the new patch set (#2). Change subject: log_block_manager: fix invalid pointer .. log_block_manager: fix invalid pointer We saw a core dump after enabling VLOGing caused by an invalid pointer during OpenBlock(). We seem to be dereferencing a block that has been moved already. Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a --- M src/kudu/fs/log_block_manager.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/12477/2 -- To view, visit http://gerrit.cloudera.org:8080/12477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a Gerrit-Change-Number: 12477 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] log block manager: fix invalid pointer
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12477 ) Change subject: log_block_manager: fix invalid pointer .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12477/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/12477/1/src/kudu/fs/log_block_manager.cc@2063 PS1, Line 2063: VLOG(3) << "Opened block " << block_id.ToString() You don't need the ToString() call; there's an operator<< overload for BlockId. http://gerrit.cloudera.org:8080/#/c/12477/1/src/kudu/fs/log_block_manager.cc@2065 PS1, Line 2065: block->reset(new internal::LogReadableBlock(std::move(lb))); Hmm, I bet someone reordered this w.r.t. the VLOG. That's an alternative solution if you prefer. -- To view, visit http://gerrit.cloudera.org:8080/12477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a Gerrit-Change-Number: 12477 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Feb 2019 23:21:37 + Gerrit-HasComments: Yes
[kudu-CR] log block manager: fix invalid pointer
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12477 Change subject: log_block_manager: fix invalid pointer .. log_block_manager: fix invalid pointer We saw a core dump after enabling VLOGing caused by an invalid pointer during OpenBlock(). We seem to be dereferencing a block that has been moved already. Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a --- M src/kudu/fs/log_block_manager.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/12477/1 -- To view, visit http://gerrit.cloudera.org:8080/12477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6567f43a30c74abc4fcf677671737035e845c1a Gerrit-Change-Number: 12477 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
