[kudu-CR] [catalog manager] correct the wrong comment
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14241 ) Change subject: [catalog_manager] correct the wrong comment .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I8b5dd17e8bc5d7034ff078da05abd62c111bec8c Gerrit-Change-Number: 14241 Gerrit-PatchSet: 1 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo
[kudu-CR] [catalog manager] correct the wrong comment
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14241 ) Change subject: [catalog_manager] correct the wrong comment .. Patch Set 1: Verified+1 Overriding Jenkins, unrelated test failure. -- To view, visit http://gerrit.cloudera.org:8080/14241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5dd17e8bc5d7034ff078da05abd62c111bec8c Gerrit-Change-Number: 14241 Gerrit-PatchSet: 1 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Sep 2019 21:52:06 + Gerrit-HasComments: No
[kudu-CR] [catalog manager] correct the wrong comment
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14241 ) Change subject: [catalog_manager] correct the wrong comment .. [catalog_manager] correct the wrong comment Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 Change-Id: I8b5dd17e8bc5d7034ff078da05abd62c111bec8c --- M src/kudu/master/catalog_manager.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Adar Dembo: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8b5dd17e8bc5d7034ff078da05abd62c111bec8c Gerrit-Change-Number: 14241 Gerrit-PatchSet: 1 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo
[kudu-CR] [catalog manager] correct the wrong comment
honeyhexin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14233 ) Change subject: [catalog_manager] correct the wrong comment .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14233/1/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/14233/1/src/kudu/master/catalog_manager.h@141 PS1, Line 141: . > nit: while you are at it, maybe change this comma (,) into period (.) as we Done -- To view, visit http://gerrit.cloudera.org:8080/14233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 Gerrit-Change-Number: 14233 Gerrit-PatchSet: 2 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: honeyhexin Gerrit-Comment-Date: Mon, 16 Sep 2019 23:38:55 + Gerrit-HasComments: Yes
[kudu-CR] [catalog manager] correct the wrong comment
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14233 ) Change subject: [catalog_manager] correct the wrong comment .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 Gerrit-Change-Number: 14233 Gerrit-PatchSet: 2 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: honeyhexin Gerrit-Comment-Date: Mon, 16 Sep 2019 23:39:04 + Gerrit-HasComments: No
[kudu-CR] [catalog manager] correct the wrong comment
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14233 ) Change subject: [catalog_manager] correct the wrong comment .. [catalog_manager] correct the wrong comment Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 Reviewed-on: http://gerrit.cloudera.org:8080/14233 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/master/catalog_manager.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 Gerrit-Change-Number: 14233 Gerrit-PatchSet: 3 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: honeyhexin
[kudu-CR] [catalog manager] correct the wrong comment
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14233 to look at the new patch set (#2). Change subject: [catalog_manager] correct the wrong comment .. [catalog_manager] correct the wrong comment Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 --- M src/kudu/master/catalog_manager.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14233/2 -- To view, visit http://gerrit.cloudera.org:8080/14233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 Gerrit-Change-Number: 14233 Gerrit-PatchSet: 2 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [catalog manager] correct the wrong comment
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14241 ) Change subject: [catalog_manager] correct the wrong comment .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5dd17e8bc5d7034ff078da05abd62c111bec8c Gerrit-Change-Number: 14241 Gerrit-PatchSet: 1 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Sep 2019 22:51:23 + Gerrit-HasComments: No
[kudu-CR] [catalog manager] correct the wrong comment
honeyhexin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14241 Change subject: [catalog_manager] correct the wrong comment .. [catalog_manager] correct the wrong comment Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 Change-Id: I8b5dd17e8bc5d7034ff078da05abd62c111bec8c --- M src/kudu/master/catalog_manager.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/14241/1 -- To view, visit http://gerrit.cloudera.org:8080/14241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8b5dd17e8bc5d7034ff078da05abd62c111bec8c Gerrit-Change-Number: 14241 Gerrit-PatchSet: 1 Gerrit-Owner: honeyhexin
[kudu-CR] [catalog manager] correct the wrong comment
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14233 ) Change subject: [catalog_manager] correct the wrong comment .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14233/1/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/14233/1/src/kudu/master/catalog_manager.h@141 PS1, Line 141: , nit: while you are at it, maybe change this comma (,) into period (.) as well? -- To view, visit http://gerrit.cloudera.org:8080/14233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 Gerrit-Change-Number: 14233 Gerrit-PatchSet: 1 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Sep 2019 16:49:33 + Gerrit-HasComments: Yes
[kudu-CR] [catalog manager] correct the wrong comment
honeyhexin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14233 Change subject: [catalog_manager] correct the wrong comment .. [catalog_manager] correct the wrong comment Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 --- M src/kudu/master/catalog_manager.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14233/1 -- To view, visit http://gerrit.cloudera.org:8080/14233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6 Gerrit-Change-Number: 14233 Gerrit-PatchSet: 1 Gerrit-Owner: honeyhexin