[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-03-02 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#5). Change subject: [catalog_manager] proper handling of catalog shutdown

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 4: (1 comment)

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 4: (4 comments) In general I'm not a fan of the additional bool* out params, when the callers

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#4). Change subject: [catalog_manager] proper handling of catalog shutdown

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 3: (2 comments)

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#3). Change subject: [catalog_manager] proper handling of catalog shutdown

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6170/2/src/kudu/master/catalog_manager.h

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 2: > Will defer to Mike and/or David; I bet they have stronger opinions > on this than I do.

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 2: Code-Review+1 Will defer to Mike and/or David; I bet they have stronger opinions on this than

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#2). Change subject: [catalog_manager] proper handling of catalog shutdown ..

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 1: (5 comments) > (4 comments) > > As a general point, it sucks that Status isn't

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 1: (4 comments) As a general point, it sucks that Status isn't full-featured enough to include

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6170 Change subject: [catalog_manager] proper handling of catalog shutdown .. [catalog_manager] proper handling of catalog shutdown