[kudu-CR] [java] excluded slf4j from async dependency

2017-06-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] excluded slf4j from async dependency .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7320 To unsubscribe, visit http://gerr

[kudu-CR] [java] excluded slf4j from async dependency

2017-06-29 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java] excluded slf4j from async dependency .. [java] excluded slf4j from async dependency The slf4j-api dependency defined by async uses a range-based ve

[kudu-CR] [java] excluded slf4j from async dependency

2017-06-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] excluded slf4j from async dependency .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7320 To unsubscribe, visit http://gerrit.

[kudu-CR] [java] excluded slf4j from async dependency

2017-06-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] excluded slf4j from async dependency .. Patch Set 2: I don't have any formal write up on version ranges advice. But essentially the advice is that though r

[kudu-CR] [java] excluded slf4j from async dependency

2017-06-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] excluded slf4j from async dependency .. Patch Set 2: Seems find to me, but I don't really understand the effect of version ranges in Maven. Is there somet

[kudu-CR] [java] excluded slf4j from async dependency

2017-06-29 Thread Grant Henke (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7320 to look at the new patch set (#2). Change subject: [java] excluded slf4j from async dependency .. [jav

[kudu-CR] [java] excluded slf4j from async dependency

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] excluded slf4j from async dependency .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7320/1//COMMIT_MSG Commit Message: Line

[kudu-CR] [java] excluded slf4j from async dependency

2017-06-28 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7320 Change subject: [java] excluded slf4j from async dependency .. [java] excluded slf4j from async dependency The slf4j-api dependency define