[kudu-CR] [java-client] address follow-up comments to c7dab4
Todd Lipcon has posted comments on this change. Change subject: [java-client] address follow-up comments to c7dab4 .. Patch Set 1: How about this comment? https://gerrit.cloudera.org/#/c/4299/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java@99 -- To view, visit http://gerrit.cloudera.org:8080/4442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9c071b8c267ed86f74c6d13b49d4c4693fddc94 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] address follow-up comments to c7dab4
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] address follow-up comments to c7dab4 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9c071b8c267ed86f74c6d13b49d4c4693fddc94 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] address follow-up comments to c7dab4
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4442 to review the following change. Change subject: [java-client] address follow-up comments to c7dab4 .. [java-client] address follow-up comments to c7dab4 Change-Id: Id9c071b8c267ed86f74c6d13b49d4c4693fddc94 --- M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java M java/kudu-client/src/main/java/org/apache/kudu/util/ByteVec.java M java/kudu-client/src/test/java/org/apache/kudu/util/TestByteVec.java 5 files changed, 10 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/4442/1 -- To view, visit http://gerrit.cloudera.org:8080/4442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9c071b8c267ed86f74c6d13b49d4c4693fddc94 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Todd Lipcon