[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-09 Thread Todd Lipcon (Code Review) 
Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8886 )

Change subject: Add some DVLOG statements to help in debugging compaction issues
..

Add some DVLOG statements to help in debugging compaction issues

This adds some DVLOG statemenst that were crucial in debugging
KUDU-2233, particularly aroung merge compactions, clock advancement
and log gc.

Change-Id: I958045a75feceee19c09961de106bbacd343c739
Reviewed-on: http://gerrit.cloudera.org:8080/8886
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/tablet_replica.cc
3 files changed, 21 insertions(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Todd Lipcon: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/8886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I958045a75feceee19c09961de106bbacd343c739
Gerrit-Change-Number: 8886
Gerrit-PatchSet: 6
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-09 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8886 )

Change subject: Add some DVLOG statements to help in debugging compaction issues
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I958045a75feceee19c09961de106bbacd343c739
Gerrit-Change-Number: 8886
Gerrit-PatchSet: 5
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 09 Jan 2018 20:15:14 +
Gerrit-HasComments: No

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-08 Thread David Ribeiro Alves (Code Review) 
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8886

to look at the new patch set (#5).

Change subject: Add some DVLOG statements to help in debugging compaction issues
..

Add some DVLOG statements to help in debugging compaction issues

This adds some DVLOG statemenst that were crucial in debugging
KUDU-2233, particularly aroung merge compactions, clock advancement
and log gc.

Change-Id: I958045a75feceee19c09961de106bbacd343c739
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/tablet_replica.cc
3 files changed, 21 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8886/5
--
To view, visit http://gerrit.cloudera.org:8080/8886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I958045a75feceee19c09961de106bbacd343c739
Gerrit-Change-Number: 8886
Gerrit-PatchSet: 5
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-08 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8886 )

Change subject: Add some DVLOG statements to help in debugging compaction issues
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8886/4/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:

http://gerrit.cloudera.org:8080/#/c/8886/4/src/kudu/tablet/compaction.cc@507
PS4, Line 507: 3
> why's this one 3 instead of 4 like the rest?
Done



--
To view, visit http://gerrit.cloudera.org:8080/8886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I958045a75feceee19c09961de106bbacd343c739
Gerrit-Change-Number: 8886
Gerrit-PatchSet: 4
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 09 Jan 2018 01:27:17 +
Gerrit-HasComments: Yes

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-08 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8886 )

Change subject: Add some DVLOG statements to help in debugging compaction issues
..


Patch Set 4:

I've had to rewrite a version of these in some form between 3 and 5 times, so I 
just figured I should make them permanent. These are DVLOG and a high level at 
that, so they're precisely to be used in unite test scenarios.


--
To view, visit http://gerrit.cloudera.org:8080/8886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I958045a75feceee19c09961de106bbacd343c739
Gerrit-Change-Number: 8886
Gerrit-PatchSet: 4
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 09 Jan 2018 01:26:11 +
Gerrit-HasComments: No

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8886 )

Change subject: Add some DVLOG statements to help in debugging compaction issues
..


Patch Set 4:

(1 comment)

seems fine, but do you think these are useful enough to commit or were they 
one-offs for debugging this issue? it seems like enabling them outside of a 
unit test scenario would probably be so noisy as to be not useful

http://gerrit.cloudera.org:8080/#/c/8886/4/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:

http://gerrit.cloudera.org:8080/#/c/8886/4/src/kudu/tablet/compaction.cc@507
PS4, Line 507: 3
why's this one 3 instead of 4 like the rest?



--
To view, visit http://gerrit.cloudera.org:8080/8886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I958045a75feceee19c09961de106bbacd343c739
Gerrit-Change-Number: 8886
Gerrit-PatchSet: 4
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 08 Jan 2018 23:59:20 +
Gerrit-HasComments: Yes

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2017-12-22 Thread David Ribeiro Alves (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8886

to look at the new patch set (#2).

Change subject: Add some DVLOG statements to help in debugging compaction issues
..

Add some DVLOG statements to help in debugging compaction issues

This adds some DVLOG statemenst that were crucial in debugging
KUDU-2233, particularly aroung merge compactions, clock advancement
and log gc.

Change-Id: I958045a75feceee19c09961de106bbacd343c739
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/tablet_replica.cc
3 files changed, 21 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8886/2
--
To view, visit http://gerrit.cloudera.org:8080/8886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I958045a75feceee19c09961de106bbacd343c739
Gerrit-Change-Number: 8886
Gerrit-PatchSet: 2
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2017-12-19 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8886


Change subject: Add some DVLOG statements to help in debugging compaction issues
..

Add some DVLOG statements to help in debugging compaction issues

This adds some DVLOG statemenst that were crucial in debugging
KUDU-2233, particularly aroung merge compactions, clock advancement
and log gc.

Change-Id: I958045a75feceee19c09961de106bbacd343c739
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/tablet_replica.cc
3 files changed, 15 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8886/1
--
To view, visit http://gerrit.cloudera.org:8080/8886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I958045a75feceee19c09961de106bbacd343c739
Gerrit-Change-Number: 8886
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves