[kudu-CR] Fixup DeltaStats::ToString

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8988 )

Change subject: Fixup DeltaStats::ToString
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
Gerrit-Change-Number: 8988
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 10 Jan 2018 01:56:24 +
Gerrit-HasComments: No


[kudu-CR] Fixup DeltaStats::ToString

2018-01-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8988 )

Change subject: Fixup DeltaStats::ToString
..

Fixup DeltaStats::ToString

Simplifies the implementation and fixes the mismatched delimiters.

Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
Reviewed-on: http://gerrit.cloudera.org:8080/8988
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M src/kudu/tablet/delta_stats.cc
1 file changed, 8 insertions(+), 12 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Todd Lipcon: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/8988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
Gerrit-Change-Number: 8988
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR] Fixup DeltaStats::ToString

2018-01-09 Thread Dan Burkert (Code Review)
Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/8988

to review the following change.


Change subject: Fixup DeltaStats::ToString
..

Fixup DeltaStats::ToString

Simplifies the implementation and fixes the mismatched delimiters.

Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
---
M src/kudu/tablet/delta_stats.cc
1 file changed, 8 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/8988/1
--
To view, visit http://gerrit.cloudera.org:8080/8988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
Gerrit-Change-Number: 8988
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon