[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. KUDU-1657: read-only FsManager::Open on active tablet can crash This fixes a race

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 7: Verified+1 Jenkins is completely hosed and I'm tired of waiting. -- To view,

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4551 To

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4551 to look at the new patch set (#7). Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 6: (4 comments)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 6: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 5: Code-Review+2 +2 from me, once Adar's nits get addressed. Thanks for

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4551 to look at the new patch set (#4). Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 2: (3 comments) Test added in slow mode.

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4551 to look at the new patch set (#3). Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 2: > that being said, maybe you could just insert the block that causes > the test

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 2: (1 comment) that test is going to bit rot super quickly and this seems

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-28 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4551 To

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 2: Two reasons: It's typically about 35 seconds to repro on ve0158; when we fix it

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 2: why not include the test and only run it in slow mode? jenkins runs tests

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-28 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4551 to look at the new patch set (#2). Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-27 Thread Dan Burkert (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4551 to review the following change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash