[kudu-CR] KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11916 ) Change subject: KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 Gerrit-Change-Number: 11916 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 13 Nov 2018 14:27:38 + Gerrit-HasComments: No
[kudu-CR] KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11916 ) Change subject: KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation .. KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation This test is just about checking the propagation of an option from the DefaultSource to the KuduRelation. However, building a DataFrame involves a connection to the cluster, and if we set socketReadTimeoutMs to 1, it's going to be very difficult to connect, especially if we're testing TSAN-instrumented binaries whose thread creation is inherently slower. The fix? Use a magic number larger than '1'. It's that simple. Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 Reviewed-on: http://gerrit.cloudera.org:8080/11916 Reviewed-by: Andrew Wong Tested-by: Kudu Jenkins Reviewed-by: Grant Henke --- M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 Gerrit-Change-Number: 11916 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11916 ) Change subject: KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation .. Patch Set 1: I did see that the client cache object is not being cleared between tests. This might have an impact on tests isolation and could be the cause for some tests affecting others. We can submit this and I will add a follow on patch to clear the cache between tests. -- To view, visit http://gerrit.cloudera.org:8080/11916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 Gerrit-Change-Number: 11916 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Tue, 13 Nov 2018 14:27:33 + Gerrit-HasComments: No
[kudu-CR] KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11916 ) Change subject: KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation .. Patch Set 1: It's unclear why these tests could potentially fail other tests. Is there some state being shared between tests? The jira mentioned `testTableScanWithProjectionAndPredicateDecimal128` and I think I saw others. -- To view, visit http://gerrit.cloudera.org:8080/11916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 Gerrit-Change-Number: 11916 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Fri, 09 Nov 2018 20:38:19 + Gerrit-HasComments: No
[kudu-CR] KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11916 ) Change subject: KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation .. Patch Set 1: > Did you run a dist_test loop to prove this works? I tried this change and > still saw flakiness. I looped all DefaultSourceTest 1000 times with TSAN binaries. All passed. http://dist-test.cloudera.org/job?job_id=adar.1541790130.63678 -- To view, visit http://gerrit.cloudera.org:8080/11916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 Gerrit-Change-Number: 11916 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Fri, 09 Nov 2018 19:47:22 + Gerrit-HasComments: No
[kudu-CR] KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11916 ) Change subject: KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation .. Patch Set 1: Did you run a dist_test loop to prove this works? I tried this change and still saw flakiness. -- To view, visit http://gerrit.cloudera.org:8080/11916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 Gerrit-Change-Number: 11916 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Fri, 09 Nov 2018 12:55:26 + Gerrit-HasComments: No
[kudu-CR] KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11916 ) Change subject: KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11916/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: http://gerrit.cloudera.org:8080/#/c/11916/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@907 PS1, Line 907: 6 Edgy. -- To view, visit http://gerrit.cloudera.org:8080/11916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 Gerrit-Change-Number: 11916 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Fri, 09 Nov 2018 06:03:08 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation
Hello Mike Percy, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11916 to review the following change. Change subject: KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation .. KUDU-2599: fix flaky DefaultSourceTest.testSocketReadTimeoutPropagation This test is just about checking the propagation of an option from the DefaultSource to the KuduRelation. However, building a DataFrame involves a connection to the cluster, and if we set socketReadTimeoutMs to 1, it's going to be very difficult to connect, especially if we're testing TSAN-instrumented binaries whose thread creation is inherently slower. The fix? Use a magic number larger than '1'. It's that simple. Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 --- M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/11916/1 -- To view, visit http://gerrit.cloudera.org:8080/11916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I81a20f776c115caf3bd720bc532bbeb5fc69bc42 Gerrit-Change-Number: 11916 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Mike Percy
